From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org
Cc: robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run,
airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org,
dianders@chromium.org, david@ixit.cz,
krzysztof.kozlowski+dt@linaro.org, swboyd@chromium.org,
konrad.dybcio@somainline.org, agross@kernel.org,
andersson@kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC
Date: Wed, 18 Jan 2023 05:29:17 +0200 [thread overview]
Message-ID: <7bfd7a4b-95fd-0e95-70a9-7287ddbd3a8c@linaro.org> (raw)
In-Reply-To: <20230116225217.1056258-2-bryan.odonoghue@linaro.org>
On 17/01/2023 00:52, Bryan O'Donoghue wrote:
> Currently we do not differentiate between the various users of the
> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one
> compatible string but, the hardware does have some significant differences
> in the number of clocks.
>
> To facilitate documenting the clocks add the following compatible strings
>
> - qcom,apq8064-dsi-ctrl
> - qcom,msm8916-dsi-ctrl
> - qcom,msm8953-dsi-ctrl
> - qcom,msm8974-dsi-ctrl
> - qcom,msm8996-dsi-ctrl
> - qcom,msm8998-dsi-ctrl
> - qcom,sc7180-dsi-ctrl
> - qcom,sc7280-dsi-ctrl
> - qcom,sdm660-dsi-ctrl
> - qcom,sdm845-dsi-ctrl
> - qcom,sm8150-dsi-ctrl
> - qcom,sm8250-dsi-ctrl
> - qcom,sm8350-dsi-ctrl
> - qcom,sm8450-dsi-ctrl
> - qcom,sm8550-dsi-ctrl
> - qcom,qcm2290-dsi-ctrl
>
> Deprecate qcom,dsi-ctrl-6g-qcm2290 in favour of the desired format while we
> do so.
>
> Several MDSS yaml files exist which document the dsi sub-node.
> For each existing SoC MDSS yaml, provide the right dsi compat string.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../display/msm/dsi-controller-main.yaml | 30 ++++++++++++++++---
> .../bindings/display/msm/qcom,mdss.yaml | 3 +-
> .../display/msm/qcom,msm8998-mdss.yaml | 8 +++--
> .../display/msm/qcom,sc7180-mdss.yaml | 6 ++--
> .../display/msm/qcom,sc7280-mdss.yaml | 6 ++--
> .../display/msm/qcom,sdm845-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8150-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8250-mdss.yaml | 8 +++--
> .../display/msm/qcom,sm8350-mdss.yaml | 6 ++--
> .../display/msm/qcom,sm8450-mdss.yaml | 4 ++-
> 10 files changed, 63 insertions(+), 24 deletions(-)
[skipped]
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> index c268e0b662cf9..599a6bad80f43 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8450-mdss.yaml
> @@ -46,7 +46,9 @@ patternProperties:
> type: object
> properties:
> compatible:
> - const: qcom,mdss-dsi-ctrl
> + items:
> + - const: qcom,sm8450-dsi-ctrl
> + - const: qcom,mdss-dsi-ctrl
>
> "^phy@[0-9a-f]+$":
> type: object
The example also should be updated in this file to include
qcom,sm8450-dsi-ctrl for DSI nodes
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-18 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 22:52 [PATCH v8 0/3] mdss-dsi-ctrl binding and dts fixes Bryan O'Donoghue
2023-01-16 22:52 ` [PATCH v8 1/3] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC Bryan O'Donoghue
2023-01-17 20:21 ` Rob Herring
2023-01-18 3:29 ` Dmitry Baryshkov [this message]
2023-01-16 22:52 ` [PATCH v8 2/3] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis Bryan O'Donoghue
2023-01-18 2:31 ` Dmitry Baryshkov
2023-01-18 2:50 ` Dmitry Baryshkov
2023-01-16 22:52 ` [PATCH v8 3/3] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in Bryan O'Donoghue
2023-01-17 18:17 ` [PATCH v8 0/3] mdss-dsi-ctrl binding and dts fixes David Heidelberg
2023-01-18 2:06 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfd7a4b-95fd-0e95-70a9-7287ddbd3a8c@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®