From: Frederic Barrat <fbarrat@linux.ibm.com>
To: Li zeming <zeming@nfschina.com>,
ajd@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: ocxl: context: Remove unnecessary (void*) conversions
Date: Tue, 14 Nov 2023 13:52:03 +0100 [thread overview]
Message-ID: <7c03da2d-b62b-4b1d-ad55-2399c2b163c4@linux.ibm.com> (raw)
In-Reply-To: <20231113011543.6940-1-zeming@nfschina.com>
On 13/11/2023 02:15, Li zeming wrote:
> The ctx pointer does not need to cast the type.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
Indeed, it's useless.
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ocxl/context.c b/drivers/misc/ocxl/context.c
> index 7f83116ae11a6..cded7d1caf328 100644
> --- a/drivers/misc/ocxl/context.c
> +++ b/drivers/misc/ocxl/context.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(ocxl_context_alloc);
> */
> static void xsl_fault_error(void *data, u64 addr, u64 dsisr)
> {
> - struct ocxl_context *ctx = (struct ocxl_context *) data;
> + struct ocxl_context *ctx = data;
>
> mutex_lock(&ctx->xsl_error_lock);
> ctx->xsl_error.addr = addr;
next prev parent reply other threads:[~2023-11-14 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 1:15 Li zeming
2023-11-14 12:52 ` Frederic Barrat [this message]
2023-11-20 4:06 ` Andrew Donnellan
2023-12-07 12:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c03da2d-b62b-4b1d-ad55-2399c2b163c4@linux.ibm.com \
--to=fbarrat@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®