mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Fuad Tabba <tabba@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, maz@kernel.org,
	will@kernel.org, catalin.marinas@arm.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, steven.price@arm.com,
	aneesh.kumar@kernel.org, oupton@kernel.org, gshan@redhat.com,
	joey.gouly@arm.com, yuzenghui@huawei.com,
	linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com,
	sdonthineni@nvidia.com, alpergun@google.com,
	fj0570is@fujitsu.com, WeiLin.Chang@arm.com,
	lpieralisi@kernel.org, enju.kohei@fujitsu.com,
	sudeep.holla@arm.com, jonathan.cameron@oss.qualcomm.com
Subject: Re: [PATCH v21 18/23] KVM: arm64: CCA: Don't expose unsupported capabilities for realm guests
Date: Fri, 2 Oct 2026 10:36:34 +0100	[thread overview]
Message-ID: <7c0846df-97ff-4461-98fc-7d094c91ba29@arm.com> (raw)
In-Reply-To: <CA+EHjTyyKxW2TT9XpjSDkdjWEuGyWmA_isDpOnoyri8ikxZN4A@mail.gmail.com>

On 02/10/2026 10:34, Fuad Tabba wrote:
> Hi Suzuki,
> 
> On Thu, 01 Oct 2026 22:06:58 +0100, Suzuki K Poulose
> <suzuki.poulose@arm.com> wrote:
> [...]
>> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> [...]
>> +static inline bool kvm_vm_ioctl_allowed(struct kvm *kvm, unsigned int ioctl)
> [...]
>> +       r = kvm_get_cap_for_kvm_ioctl(ioctl, &ext);
>> +       if (WARN_ON_ONCE(r < 0))
>> +               return false;
> 
> The fix [1] is in -rc5, so a rebase conflicts here. Please make sure
> to carry it into this copy, i.e., a plain "if (r < 0)".


> 
> With that:
> Reviewed-by: Fuad Tabba <fuad.tabba@linux.dev>

Thanks Fuad, like I mentioned, I have flagged this with Marc and he was 
happy to fix as part of the conflict resolution.

Suzuki

> 
> Cheers,
> /fuad
> 
> [1] https://lore.kernel.org/all/20260914093838.1082637-1-fuad.tabba@linux.dev/


  reply	other threads:[~2026-10-02  9:36 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 21:06 [PATCH v21 00/23] KVM: arm64: CCA: Add basic plumbing for Realms Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 01/23] KVM: arm64: protected VM: Handle user writes to CNTVCT_EL0/CNTPCT_EL0 Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 02/23] KVM: arm64: Disable Steal time accounting for protected guests Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 03/23] KVM: arm64: Include kvm_emulate.h in kvm/arm_psci.h Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 04/23] KVM: arm64: Avoid including linux/kvm_host.h in kvm_pgtable.h Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 05/23] KVM: arm64: Track the type of VM in kvm_arch Suzuki K Poulose
2026-10-02 10:06   ` Fuad Tabba
2026-10-02 12:57     ` Marc Zyngier
2026-10-02 13:05       ` Fuad Tabba
2026-10-02 13:10         ` Suzuki K Poulose
2026-10-02 13:34         ` Marc Zyngier
2026-10-02 14:15         ` Marc Zyngier
2026-10-02 14:37           ` Fuad Tabba
2026-10-02 15:29             ` Marc Zyngier
2026-10-02 15:30               ` Fuad Tabba
2026-10-03  5:53               ` Suzuki K Poulose
2026-10-02 15:15           ` Suzuki K Poulose
2026-10-02 15:40             ` Marc Zyngier
2026-10-02 15:42               ` Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 06/23] KVM: arm64: Don't call vcpu_set_pauth_traps for pKVM host Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 07/23] KVM: arm64: Refactor the vcpu_load to allow for VM specific callbacks Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 08/23] KVM: arm64: Add vcpu load/put call backs for flavors Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 09/23] KVM: arm64: Reuse kvm_stage2_unmap_range in kvm_unmap_gfn_range Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 10/23] KVM: arm64: Add VM specific callback for S2 MMU operations Suzuki K Poulose
2026-10-02 10:19   ` Fuad Tabba
2026-10-02 10:29     ` Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 11/23] KVM: arm64: Use a local kvm pointer in kvm_handle_guest_abort() Suzuki K Poulose
2026-10-02  9:14   ` Fuad Tabba
2026-10-01 21:06 ` [PATCH v21 12/23] KVM: arm64: Abstract out memory abort handling Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 13/23] KVM: arm64: Mandate VGIC v3 for pKVM VMs and Realms Suzuki K Poulose
2026-10-02  9:23   ` Fuad Tabba
2026-10-01 21:06 ` [PATCH v21 14/23] KVM: arm64: CCA: Add a new mode for supporting Realm guests Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 15/23] KVM: arm64: CCA: Add VCPU load/put for Realms Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 16/23] KVM: arm64: CCA: Add bare minimal S2 operations for Realm Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 17/23] KVM: arm64: CCA: Introduce Realms Suzuki K Poulose
2026-10-01 21:06 ` [PATCH v21 18/23] KVM: arm64: CCA: Don't expose unsupported capabilities for realm guests Suzuki K Poulose
2026-10-02  9:34   ` Fuad Tabba
2026-10-02  9:36     ` Suzuki K Poulose [this message]
2026-10-01 21:06 ` [PATCH v21 19/23] KVM: arm64: Prevent unsupported vcpu features for VM types Suzuki K Poulose
2026-10-01 21:07 ` [PATCH v21 20/23] KVM: arm64: CCA: WARN on injected undef exceptions Suzuki K Poulose
2026-10-01 21:07 ` [PATCH v21 21/23] KVM: arm64: CCA: Support timers in realm RECs Suzuki K Poulose
2026-10-01 21:07 ` [PATCH v21 22/23] KVM: arm64: CCA: Expose SVE VL register before VCPU finalization Suzuki K Poulose
2026-10-01 21:07 ` [PATCH v21 23/23] KVM: arm64: CCA: Control user register access for Realms Suzuki K Poulose
2026-10-01 21:41 ` [PATCH v21 00/23] KVM: arm64: CCA: Add basic plumbing " Gavin Shan
2026-10-02  6:13   ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c0846df-97ff-4461-98fc-7d094c91ba29@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=WeiLin.Chang@arm.com \
    --cc=alpergun@google.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=enju.kohei@fujitsu.com \
    --cc=fj0570is@fujitsu.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=gshan@redhat.com \
    --cc=joey.gouly@arm.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@kernel.org \
    --cc=sdonthineni@nvidia.com \
    --cc=steven.price@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®