From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162263AbdAJCiR (ORCPT ); Mon, 9 Jan 2017 21:38:17 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:59020 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932584AbdAJCiO (ORCPT ); Mon, 9 Jan 2017 21:38:14 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: wxt@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <2e63582819e7946ee3beacaab9aa1334> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3] arm64: dts: rockchip: add "rockchip, grf" property for RK3399 PMUCRU/CRU To: Xing Zheng , heiko@sntech.de References: <1484011661-13474-1-git-send-email-zhengxing@rock-chips.com> Cc: shawn.lin@rock-chips.com, Mark Rutland , devicetree@vger.kernel.org, Elaine Zhang , linux-kernel@vger.kernel.org, Catalin Marinas , Michael Turquette , Brian Norris , Stephen Boyd , Douglas Anderson , Will Deacon , dianders@google.com, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , David Wu , Jianqun Xu , linux-arm-kernel@lists.infradead.org, Caesar Wang From: Shawn Lin Message-ID: <7c0ebe60-ac6e-0f82-bb5f-97919f812a56@rock-chips.com> Date: Tue, 10 Jan 2017 10:37:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484011661-13474-1-git-send-email-zhengxing@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/10 9:27, Xing Zheng wrote: > The structure rockchip_clk_provider needs to refer the GRF regmap > in somewhere, if the CRU node has not "rockchip,grf" property, > calling syscon_regmap_lookup_by_phandle will return an invalid GRF > regmap, and the MUXGRF type clock will be not supported. > > Therefore, we need to add them. > > Signed-off-by: Xing Zheng > --- > > Changes in v3: > - add optional roperty rockchip,grf in rockchip,rk3399-cru.txt > > Changes in v2: > - referring pmugrf for PMUGRU > - fix the typo "invaild" in COMMIT message > > Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt | 5 +++++ > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt > index 3888dd3..f476b3d 100644 > --- a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt > +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt > @@ -13,6 +13,11 @@ Required Properties: > - #clock-cells: should be 1. > - #reset-cells: should be 1. > > +Optional Properties: > + > +- rockchip,grf: phandle to the syscon managing the "general register files" > + If missing pll rates are not changable, due to the missing pll lock status. > + It twists my tongue w/o proper punctuation:) - rockchip,grf: phandle to the syscon managing the "general register files". If missing, pll rates are not changable due to the missing pll lock status. > Each clock is assigned an identifier and client nodes can use this identifier > to specify the clock which they consume. All available clocks are defined as > preprocessor macros in the dt-bindings/clock/rk3399-cru.h headers and can be > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index c928015..081621b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1077,6 +1077,7 @@ > pmucru: pmu-clock-controller@ff750000 { > compatible = "rockchip,rk3399-pmucru"; > reg = <0x0 0xff750000 0x0 0x1000>; > + rockchip,grf = <&pmugrf>; > #clock-cells = <1>; > #reset-cells = <1>; > assigned-clocks = <&pmucru PLL_PPLL>; > @@ -1086,6 +1087,7 @@ > cru: clock-controller@ff760000 { > compatible = "rockchip,rk3399-cru"; > reg = <0x0 0xff760000 0x0 0x1000>; > + rockchip,grf = <&grf>; > #clock-cells = <1>; > #reset-cells = <1>; > assigned-clocks = > -- Best Regards Shawn Lin