From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0D6209F51 for ; Thu, 6 Mar 2025 09:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254208; cv=none; b=SF941Ch6iUsdvAc9Se3Quj0z61h9ZXJNk6DSy176hMOZc4UnvjDMQ1NOH259l2Z9JhrQ5wGreGllPyW47VYsXRFgiKf40ZRZZxBYzjPSeATN8suTIlR3bTTUUx6X0ZiYvDwoLFmVsjM7H91IXxQG4SUVZu+u9fksE8c7SU0pPWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741254208; c=relaxed/simple; bh=ij6pw+xGtu8hU4opSEKUyYQbYkETiMrkgi1ZrVOSFIA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n36zSW9mv3HXOJ9GUoR8AjeuULnXGXtVFv/XscB+psED59MaGSyadUCN9knh294fplLe22BrkipF9YBOoSSFZ3pE4Nx/PHelIrvDqIgve63UOpY2cBPGTrdjUc6ACMuTZ8BdIBxfvSwNCTetqMk2p7VAZrbc5KZnA802i/4SroY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gMcrM5eS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gMcrM5eS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741254205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XX3dakY8scOT7Ne2j8d44b9U4MvBllULAE0kKWIQm8s=; b=gMcrM5eSJlyr7/ocMVePdC0Zk2xP04hLyXI8Hok1W+x+1ZryHIZnZIsilpdYVmAuaBglKu YlgJXDfmi+1ai/+MQByuNl9sy1aV/7+TuGW0rpjvwhAXPuYXiMtdG8BAvIjT5mkuO92R94 uGyUgn8kowpEvqbTIr5OO6ZIrvNmV0g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-376-Fer2u3LGNhK0kKFTCpJjuA-1; Thu, 06 Mar 2025 04:43:12 -0500 X-MC-Unique: Fer2u3LGNhK0kKFTCpJjuA-1 X-Mimecast-MFC-AGG-ID: Fer2u3LGNhK0kKFTCpJjuA_1741254191 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-390f365274dso222998f8f.0 for ; Thu, 06 Mar 2025 01:43:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741254191; x=1741858991; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XX3dakY8scOT7Ne2j8d44b9U4MvBllULAE0kKWIQm8s=; b=sRmMrcn/ldCO8ItKbNetZr8I9yF1/zXUJ14gajBRUwlBGad7IpNzqW/+F9rbAFy5WR HqTC0y37NctvnGasmbv0PxhMOwQhGQqKbdvlzfxmILKf0fxmGHjPZiO55zStnBmtrf8O aGyFVl2sNsC2HOJazivsbJzMIRKb4xNTRFy5tEVS9xuH4JGw5s2V+JsVWUrU0g17OII1 owwnKecPlr3Y+tx5aexjSWbSWtsXmimi852YNtz+QaUPACuf5XdtxaQwCusyJbT6sh/D XjhTXz3ovRaJE4Gka7XRpITpMaFgWgSxUbarX4S+sK/M/ernUPOGrJ4yziU/5sqn6Tc6 jwPQ== X-Forwarded-Encrypted: i=1; AJvYcCUQaDkYBi0tV7VDl2vifIpAoBacHBHAYOZarilIdyV8QEEuU2tH7oXNXSsm5sooAFPcnfL053OEbOaRgO4=@vger.kernel.org X-Gm-Message-State: AOJu0YyFvinCeqKjtNE2qP2ulr66NZyfXHlH01ttPIsqAu6C1buYEhTg A5sNa3UFLbLAeHq1jQ+7vDX/yHHPWwkYTU/CHMecOqG6+2d7JuorsIcDUnHrwf+72YY3sIRXBVB Wt5Kotm+gj22nMVXq9qAKts9u5xnd3EPhqBesIr5ublwZeBdqA1MWJ7XT0ZIFOA== X-Gm-Gg: ASbGncsVTzuGnh1DJ+gHofoZwu80d2EI5to4J/KaXwJTcuwbSsfKDsKmMbPNR+36D6c PuZ5r7RnbyPpletsQK0VlS+pNRctGZ1QuPHMJquYNbHYxujs4oYvDhUyt+Y5L7Q9rHKuC4QWOLp 041JeqYaIL6uQOXlVutbckjRy1OpmsnzSbgjLbJC6ccKv0iJv2iiOCl57hA1UcKwZX4yMx3hGKp ZwNCP3pSqyJYv7PcFOdapjdJklk+izXdzfbmVk8SDy61I/HYTfhsqox1P8C+0nfVO2jiw9XL8DR JTBN40FPlNqSCDP0qg/CyTeZImCTk/Dp1uUO+/w784KvIQ== X-Received: by 2002:a05:6000:1888:b0:391:b93:c971 with SMTP id ffacd0b85a97d-3912982e94amr1698932f8f.20.1741254191201; Thu, 06 Mar 2025 01:43:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuWB1xxLyGYJud3m2Orc+jQD9bwgMtC8fEkj+pgDtO5dg4XKxw8lCcj7dXngVsWSVLL5GgjQ== X-Received: by 2002:a05:6000:1888:b0:391:b93:c971 with SMTP id ffacd0b85a97d-3912982e94amr1698907f8f.20.1741254190790; Thu, 06 Mar 2025 01:43:10 -0800 (PST) Received: from [192.168.88.253] (146-241-81-153.dyn.eolo.it. [146.241.81.153]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912bfdfde7sm1507615f8f.32.2025.03.06.01.43.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Mar 2025 01:43:10 -0800 (PST) Message-ID: <7c14179c-0262-47e5-a13e-a53c2061da9b@redhat.com> Date: Thu, 6 Mar 2025 10:43:09 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 1/2] net: phy: nxp-c45-tja11xx: add TJA112X PHY configuration errata To: Andrei Botila , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, s32@nxp.com, Christophe Lizzi , Alberto Ruiz , Enric Balletbo , stable@vger.kernel.org References: <20250304160619.181046-1-andrei.botila@oss.nxp.com> <20250304160619.181046-2-andrei.botila@oss.nxp.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250304160619.181046-2-andrei.botila@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/4/25 5:06 PM, Andrei Botila wrote: > diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c > index 34231b5b9175..709d6c9f7cba 100644 > --- a/drivers/net/phy/nxp-c45-tja11xx.c > +++ b/drivers/net/phy/nxp-c45-tja11xx.c > @@ -22,6 +22,11 @@ > #define PHY_ID_TJA_1103 0x001BB010 > #define PHY_ID_TJA_1120 0x001BB031 > > +#define VEND1_DEVICE_ID3 0x0004 > +#define TJA1120_DEV_ID3_SILICON_VERSION GENMASK(15, 12) > +#define TJA1120_DEV_ID3_SAMPLE_TYPE GENMASK(11, 8) > +#define DEVICE_ID3_SAMPLE_TYPE_R 0x9 > + > #define VEND1_DEVICE_CONTROL 0x0040 > #define DEVICE_CONTROL_RESET BIT(15) > #define DEVICE_CONTROL_CONFIG_GLOBAL_EN BIT(14) > @@ -1593,6 +1598,50 @@ static int nxp_c45_set_phy_mode(struct phy_device *phydev) > return 0; > } > > +/* Errata: ES_TJA1120 and ES_TJA1121 Rev. 1.0 — 28 November 2024 Section 3.1 */ > +static void nxp_c45_tja1120_errata(struct phy_device *phydev) > +{ > + int silicon_version, sample_type; > + bool macsec_ability; > + int phy_abilities; > + int ret = 0; > + > + ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, VEND1_DEVICE_ID3); > + if (ret < 0) > + return; > + > + sample_type = FIELD_GET(TJA1120_DEV_ID3_SAMPLE_TYPE, ret); > + if (sample_type != DEVICE_ID3_SAMPLE_TYPE_R) > + return; > + > + silicon_version = FIELD_GET(TJA1120_DEV_ID3_SILICON_VERSION, ret); > + > + phy_abilities = phy_read_mmd(phydev, MDIO_MMD_VEND1, > + VEND1_PORT_ABILITIES); > + macsec_ability = !!(phy_abilities & MACSEC_ABILITY); > + if ((!macsec_ability && silicon_version == 2) || > + (macsec_ability && silicon_version == 1)) { > + /* TJA1120/TJA1121 PHY configuration errata workaround. > + * Apply PHY writes sequence before link up. > + */ > + if (!macsec_ability) { > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 0x4b95); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 0xf3cd); > + } else { > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 0x89c7); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 0x0893); > + } > + > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x0476, 0x58a0); > + > + phy_write_mmd(phydev, MDIO_MMD_PMAPMD, 0x8921, 0xa3a); > + phy_write_mmd(phydev, MDIO_MMD_PMAPMD, 0x89F1, 0x16c1); > + > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 0x0); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 0x0); Please add macro with meaningful names for all the magic numbers used above, thanks! Paolo