From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 280E73BCD1C for ; Fri, 29 May 2026 09:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045827; cv=none; b=anw8NjukMaalUzJFZtV8AFVAR9/JxR0hZGIDMnO+mCThJDeNwPGT6SC2WJdKZ9xX83sOvlEhwY5WBuHzsdk2F1bRQMMwIqc3dFLXvBnu/i3BYmz5OqX/W8qmeKHbNp2cc6Rn4HUX3MYVeZDVQLmQYi3gXMuby/mE53CTheZYu5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780045827; c=relaxed/simple; bh=ZUdviwf+NwGuQT5/MopQk2BDrQNeUZb8qGipi8+XsPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rHSWY7uuCqze9UrRWpPRwC5y80yKvVzeuy1k7BrJOw47DppnusvrUQRhsGyLHJ6tHGY4Vvh4W6d4s0JWg1kyllDOJz43prICfEui1J1g5DoNBvoV8Vo6LEpb/Ho2T4IOtmdhzO74URMxkHHu8R+2gFgo1LjrUJmhBp/d+H0sCcw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=npqlHZhf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="npqlHZhf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC0201F00893; Fri, 29 May 2026 09:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780045824; bh=S8RgkVBDzDG3YaYzhTa4ISLM+K3g4AZuNYjWiAh67ao=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=npqlHZhfv7Tx5WB+QmIVjPtAAEh9WWZ2VppHuNVru6ulksxMr965VBErPcNNlz+eN 8ZDAwHiGR9rM0otdBqNZlKrgCk7dpmZ16UkDszKLMwS9lOylRmV/sJMkt+k1VMV9AY pG4vvSe8M4LirIFvLguXN1OkTyDGj61UM99uLqCqgWTJywYC/AAgD+I01eGxVg+izU x4UX/rMw0ZsfZ+5kQpambEzdIKi9zUVEq9tzU73sFs4r0jcv33owHSWNXC7hdhwa1K tCD/Ap15yHyaVxE1GOo+PQU8ZdWQhmLtA5ubviH5g/lvUFXi616tPdMewA5fDBWFGM qRkZqMrm+u4fg== Message-ID: <7c1a04f3-caa8-4200-a4ee-55cd2cc28461@kernel.org> Date: Fri, 29 May 2026 11:10:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc/boot: remove unused min_t/max_t macros To: Thorsten Blum , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260525091839.817778-3-thorsten.blum@linux.dev> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260525091839.817778-3-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 25/05/2026 à 11:18, Thorsten Blum a écrit : > The min_t() and max_t() macros are no longer used by the boot wrapper, > remove them. Did you test your change ? BOOTCC arch/powerpc/boot/decompress.o In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:241, from arch/powerpc/boot/decompress.c:37: arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c: In function 'fill_temp': arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:158:28: error: implicit declaration of function 'min_t'; did you mean 'min'? [-Wimplicit-function-declaration] 158 | size_t copy_size = min_t(size_t, | ^~~~~ | min arch/powerpc/boot/../../../lib/xz/xz_dec_stream.c:158:34: error: expected expression before 'size_t' 158 | size_t copy_size = min_t(size_t, | ^~~~~~ In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:242: arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c: In function 'dict_repeat': arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c:357:22: error: expected expression before 'size_t' 357 | left = min_t(size_t, dict->limit - dict->pos, *len); | ^~~~~~ arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c: In function 'xz_dec_lzma2_run': arch/powerpc/boot/../../../lib/xz/xz_dec_lzma2.c:1101:52: error: expected expression before 'size_t' 1101 | dict_limit(&s->dict, min_t(size_t, | ^~~~~~ In file included from arch/powerpc/boot/../../../lib/decompress_unxz.c:243: arch/powerpc/boot/../../../lib/xz/xz_dec_bcj.c: In function 'bcj_flush': arch/powerpc/boot/../../../lib/xz/xz_dec_bcj.c:469:27: error: expected expression before 'size_t' 469 | copy_size = min_t(size_t, s->temp.filtered, b->out_size - b->out_pos); | ^~~~~~ make[2]: *** [arch/powerpc/boot/Makefile:235: arch/powerpc/boot/decompress.o] Error 1 make[1]: *** [arch/powerpc/Makefile:236: zImage] Error 2 make: *** [Makefile:248: __sub-make] Error 2 > > Signed-off-by: Thorsten Blum > --- > arch/powerpc/boot/types.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/powerpc/boot/types.h b/arch/powerpc/boot/types.h > index 8a4c418b7260..c5085c2632bf 100644 > --- a/arch/powerpc/boot/types.h > +++ b/arch/powerpc/boot/types.h > @@ -37,9 +37,6 @@ typedef s64 int64_t; > (void) (&_x == &_y); \ > _x > _y ? _x : _y; }) > > -#define min_t(type, a, b) min(((type) a), ((type) b)) > -#define max_t(type, a, b) max(((type) a), ((type) b)) > - > typedef int bool; > > #ifndef true