mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mathew McBride" <matt@traverse.com.au>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] hwmon: add Microchip EMC230X fan controller driver
Date: Wed, 14 Sep 2022 20:24:12 +1000	[thread overview]
Message-ID: <7c1c705f-65b4-47d3-afae-68e70b85ab3b@www.fastmail.com> (raw)
In-Reply-To: <20220914101207.GA938301@roeck-us.net>

On Wed, Sep 14, 2022, at 8:12 PM, Guenter Roeck wrote:
> On Wed, Sep 14, 2022 at 05:30:27AM +0000, Mathew McBride wrote:
> > The Microchip EMC230X (formerly made by SMSC) family of fan controllers
> > provide PWM control for up to 5 fans (in the EMC2305). The EMC230X is
> > capable of maintaining (closed-loop) a target RPM speed through PWM.
> > 
> > This driver has been tested with the EMC2301 (on our Traverse Ten64
> > appliance) and with the EMC2305 demo board (ADM00879).
> > 
> > The driver is by no means complete, for example, further work would
> > be required to support the different PWM output frequencies for
> > voltage-based fan speed control. (So far this driver has only been
> > tested with direct PWM capable fans, like the 4 pin fans found
> > in recent PCs)
> > 
> > The emc230x driver also has thermal subsystem integration which allows
> > the emc230x-controlled fan(s) to be used as cooling devices.
> 
> I just accepted a driver or emc2301/2/3/5. Please submit improvements
> on top of that driver if needed; we won't have competing drivers
> for the same chip in the kernel, and replacing a just accepted driver
> smply does not make any sense.

My apologies, I was unaware of the separate effort! 
Mine has been out of tree for a long time and I finally had time to work on it recently.

There are several changes I can see that need to be made to the accepted one to work for our usecase.

> Guenter
> 

      reply	other threads:[~2022-09-14 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  5:30 Mathew McBride
2022-09-14  5:30 ` [PATCH 1/3] hwmon: (emc230x) add Microchip (SMSC) EMC230X fan controller support Mathew McBride
2022-09-14  5:30 ` [PATCH 2/3] dt-bindings: add binding for Microchip EMC230X fan controller family Mathew McBride
2022-09-14  5:30 ` [PATCH 3/3] arm64: dts: ten64: add configuration for fan controller Mathew McBride
2022-09-14 10:12 ` [PATCH 0/3] hwmon: add Microchip EMC230X fan controller driver Guenter Roeck
2022-09-14 10:24   ` Mathew McBride [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c1c705f-65b4-47d3-afae-68e70b85ab3b@www.fastmail.com \
    --to=matt@traverse.com.au \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®