From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219372561A7 for ; Mon, 2 Mar 2026 10:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772448697; cv=none; b=TqgUCBCL5+XT7MhuGVvDAL0rtz7nyLchBT3edEjw4jV4YvKJjMK1ptmzIgpsh1EIlc91Aoa3g3+cfP9ByO5S+HodBWMWeNixfI2vWXC/oaSekU19DM/It2Rj/Nm9AB1acIjv7vsCsdDF69KItVO7i10vcTSPg2sD4rtRsnhfAW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772448697; c=relaxed/simple; bh=YbNlWU+LXhiLPh5IlWgzvOAEn7YydIRKlxSLyxLijnU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=djT/T227InkOmIWyxk81IbV6QAcMZAow5BinyrixCHl96GS7NJjaU+14IN50RWBwokpa90fMf56liSCoxVClVj6EH2GTSFh7OJSEImynjI68y9zoE6pHubjxX5pa4vXc0CU8T9hAKFEk5onD9TxZVqHy3+bal+xQYNEzzucFR8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IV7mNZx8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WGoezZ3L; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IV7mNZx8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WGoezZ3L" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6229K36L782736 for ; Mon, 2 Mar 2026 10:51:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KMdp7LO8XhUCSDsvFwoC4/b9hnTA/D9rEddSM6zJVvs=; b=IV7mNZx8ZwPpAmEQ KZs1C0/AD815DphLF2Dh7vF8sAHMuATbAuVvMJ+KycMgH2BOxzUKgPDKWtZ4nQrg +YbZmMk0b2jfDh25pJkvrkiOo7HZUcMKpZvqD8v8Xz1X7fnSGZ7TW79K9WMPdKLH tsLzbUF36cjfotbi+WPAWOXqBEYmkiKlpanH62ij7rR9W/mgkPx4SvWfb/XEOdOv Ia32RVzaMDniUDr8nl4MUDX4TGxZgZob0c/5fuH85/yRCe++lDtdvGaCZX/zMUUo /LaxYttlIERRBM/K6IUszAiK9BpLLdaq6VmzB27Q++Rf7kOXGUUnHlRLs0JhJIQL P4Rwzw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn7u00auj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 10:51:35 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c70f8010fc0so16806368a12.2 for ; Mon, 02 Mar 2026 02:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772448694; x=1773053494; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KMdp7LO8XhUCSDsvFwoC4/b9hnTA/D9rEddSM6zJVvs=; b=WGoezZ3LESzRqDvHySCPaQG734YESMYUxXG33W1qz3w39jnwwbou3ppJjuEVoRPUAA GQdoC+Z86upN10N9hZ36xO8P5skWsmqovVHFXaZiQc/o2Ui7KTYLAANVCbEBEmSBYR6z wX59+f5z5b+yenxB4vvLi9pEL0aSHny/vHguEsVyVdqBrv8Or22eBO6Kusz8MXYWAajv shnM86BDATSflrVpp89jE2Ks79bIDiqRj/Nibl7SGokCS5oSFFIEDXwo2hjS/pYGCb2t hJgDV1SJ9nu7TbXZ8Tt15qKSzETgQIcqJvkDeSN2+XA5/QWN/6C7zY8amps9okwPKcGt u1Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772448694; x=1773053494; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KMdp7LO8XhUCSDsvFwoC4/b9hnTA/D9rEddSM6zJVvs=; b=aBlJa+Trb45rsatZP2r4kx4NsBdxukL6TomDzt0WnZfuX0+qWtiRZpI3dww5feFiSp P8OBlxBVuR96jSLaaQUfMB+YhMoocWesKyECXsIK7oyqo3ksJsXJJSm7v0L+XQCiLPfX tD+k1WuZRt0f43tOgCBVDmZpaWTO5I/3anAoD9QfWQQL9DfOZfZekmz0w9pvlhv0og/b eGOGsjWSzpHUOFIZ8d8hwjBnR4Qbkq642zIZyFZBzpvURV9tS9w1PSfi5+S1OuTU2QxN GjgJfzrfMF/9C0ouMg0L+vRY++4Zv+J+/wVvxlcVgTA+hdr3fEP1YRLRRRUAeohyCYpC kcTA== X-Forwarded-Encrypted: i=1; AJvYcCWcUf4LuzMqQUshjSUYQZOhb/d4L6ZS6n3DViSAyyl6xYIy/lMXyblz1b+BccSvivP6TyHJyVCCrVOhwxA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9H9ckhijswuMGtiq/QjC7Jxuu12A6drr76Eng23pR4gxDOngP DiInF8et8lz+bEyB6w4g/oa0cNqDFij3oJE/qZm4gqf0fkhslUthndYyjv7/15W1L2lXNbXOBys JDc2aoRLwsUsEg2JJSPat2rTUtAjjKFth9B1rr+v1LYo0LYlOPi530pYfASWuc2bfEus= X-Gm-Gg: ATEYQzwAk3IzmySB905tyaeGFgfD/l8IUDvQ3ngURoz1+X3O2cimBpsMtECpAmCMPK5 ODdW0t8CNm4xHX52/dcdscSA+igp+VJ0WaRH1UD+Imoc3gT1rSwMxN3sdHBV+6yItd64zuMDyNv C7wXaK1xTN5dHnvCPtRzBeAOWdeKX82g/SH9y3zSmwctmD0OSRC8/Gp6rlv9CY6X/odQxRx/WmM hjS/JM+4tdOIWrsAgrYvzUcX/GHGhHjK6bGtPTRbDc8zPolq5SCLC7ZrWQDHf6okq9kIxZfTb8S SZ6oxCGCE13KTKqphhcckEEjEthwvldPG03QRQxh4+Xw2CjGqFOpjhGVUOwtDZ1za1rPob2IfrY HXOT7cA8X0DNyDKeWDXp7wDtafxIOIEZGfBVA5O7G3xjLYhD3b4SeXg== X-Received: by 2002:a05:6a00:1c8e:b0:823:1c3e:95cf with SMTP id d2e1a72fcca58-8274d9b4f5amr10137875b3a.18.1772448694175; Mon, 02 Mar 2026 02:51:34 -0800 (PST) X-Received: by 2002:a05:6a00:1c8e:b0:823:1c3e:95cf with SMTP id d2e1a72fcca58-8274d9b4f5amr10137856b3a.18.1772448693727; Mon, 02 Mar 2026 02:51:33 -0800 (PST) Received: from [10.0.0.3] ([106.222.233.219]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a05cbe6sm12948221b3a.59.2026.03.02.02.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 02:51:33 -0800 (PST) Message-ID: <7c1cd1ef-6d4c-c4c3-9f2d-02f28fdd82fe@oss.qualcomm.com> Date: Mon, 2 Mar 2026 16:21:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] media: venus: fix QCOM_MDT_LOADER dependency Content-Language: en-US To: Arnd Bergmann , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Arnd Bergmann , Robin Murphy , Robert Foss , Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260216121525.2311140-1-arnd@kernel.org> From: Dikshita Agarwal In-Reply-To: <20260216121525.2311140-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GMMF0+NK c=1 sm=1 tr=0 ts=69a56bb7 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Rcr8AszoUWCL+GUTnXSVkw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=xq3W2uTSAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=TxWHU2ARYOkZREXtdToA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=P5L7wpMTXyg1GfFA3Gwx:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA4OCBTYWx0ZWRfX0Al71QvOm4r6 L763My9jhpIBM7dc0GtepkgKLxFhxS5LpkgM+gJk1Bg9nTHUlYvS8OnfCVOlAfrimaAlpFvM1fT McF2TvKsjc0KPjxIce3SemcLbg+U+vIUXwxc9L1Okzs+n3cyO93pnPPYRomVWucDpD5Lm5jnaqF ++lj3RjbIBFoVO2pjIUCnJAgDJTMaTC18pc4nA5I4qvaSS47II69v+Kkx268WravJTVW0z71m9/ xa7FR3FsF4yxWj0KVxuaLtT1Stv5PASyRT/i/TGQaIj+EYqit1Wf5uLnEU2X1a5Ov+BNytHsXvu Vinguf7uGYIDwZVP0j2Rg9DEK40n4Kxh4wXW/n7TeAXz+dYJJqhgsIC/ATddCtNFA6xaXO+SAeq HPmCnKAUEU1H8IcaOxBLUSkKqV/fouy1kccwsYW59BOSfWdCpIWHmjh0f15JbqXk/d6wcqasNDM IebJoks4GwbxrcXX53w== X-Proofpoint-GUID: UB6C5wxtoBAqLfFy29kmhL9L947IlY3C X-Proofpoint-ORIG-GUID: UB6C5wxtoBAqLfFy29kmhL9L947IlY3C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 priorityscore=1501 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020088 On 2/16/2026 5:45 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y, > the kernel fails to link: > > x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot': > firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size' > firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load' > firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init' > > The problem is the conditional 'select' statement. Change this to > make the driver built-in here regardless of CONFIG_ARCH_QCOM, > same as for the similar IRIS driver. > > Signed-off-by: Arnd Bergmann > --- > See https://patchwork.linuxtv.org/project/linux-media/patch/20260205145623.1360105-1-arnd@kernel.org/ > for the corresponding iris patch I sent earlier > --- > drivers/media/platform/qcom/venus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig > index 164491c5c374..075e08eaceda 100644 > --- a/drivers/media/platform/qcom/venus/Kconfig > +++ b/drivers/media/platform/qcom/venus/Kconfig > @@ -6,7 +6,7 @@ config VIDEO_QCOM_VENUS > depends on ZONE_DMA > select DMA_MASK_31 # technically 0xdfffffff > select OF_DYNAMIC if ARCH_QCOM > - select QCOM_MDT_LOADER if ARCH_QCOM > + select QCOM_MDT_LOADER > select QCOM_SCM > select VIDEOBUF2_DMA_CONTIG > select V4L2_MEM2MEM_DEV Reviewed-by: Dikshita Agarwal Thanks, Dikshita