From: Markus Elfring <Markus.Elfring@web.de>
To: Song jeonghak <thdwjdgkr123@gmail.com>,
linux-fsdevel@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Viacheslav Dubeyko <slava@dubeyko.com>,
Yangtao Li <frank.li@vivo.com>
Cc: syzbot+98547b0428b6a6a3467c@syzkaller.appspotmail.com,
LKML <linux-kernel@vger.kernel.org>,
Edward Adam Davis <eadavis@qq.com>,
Shardul Bankar <shardul.b@mpiricsoftware.com>
Subject: Re: [PATCH v2] hfsplus: free failed b-tree nodes in hfs_bnode_put()
Date: Tue, 3 Nov 2026 09:19:41 +0100 [thread overview]
Message-ID: <7c1d70fc-ea04-4338-b1d8-f2ad12123cf6@web.de> (raw)
In-Reply-To: <20261103022522.21918-1-thdwjdgkr123@gmail.com>
…
> +++ b/fs/hfsplus/bnode.c
> @@ -702,6 +702,14 @@ void hfs_bnode_put(struct hfs_bnode *node)
> hfs_bnode_free(node);
> return;
> }
> +
> + if (test_bit(HFS_BNODE_ERROR, &node->flags)) {
> + hfs_bnode_unhash(node);
> + spin_unlock(&tree->hash_lock);
> + hfs_bnode_free(node);
> + return;
> + }
> +
> spin_unlock(&tree->hash_lock);
> }
> }
Would you dare to use an additional label in such a function implementation?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.4-rc1#n526
https://elixir.bootlin.com/linux/v7.3/source/fs/hfs/bnode.c#L513-L542
Regards,
Markus
prev parent reply other threads:[~2026-11-03 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 2:25 Song jeonghak
2026-11-03 8:19 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1d70fc-ea04-4338-b1d8-f2ad12123cf6@web.de \
--to=markus.elfring@web.de \
--cc=eadavis@qq.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shardul.b@mpiricsoftware.com \
--cc=slava@dubeyko.com \
--cc=syzbot+98547b0428b6a6a3467c@syzkaller.appspotmail.com \
--cc=thdwjdgkr123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®