From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7B3F1E9905 for ; Mon, 18 Aug 2025 12:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521167; cv=none; b=uGZiDORn6c/vQ6lakq5+KqSSnuKG67dE2pGO7csKHJWfpGN7lIRr4VNhwTW5Ce+L50hmsbZjCUvir3BqckU7aVmb3CzV8ZMuSaup8wTejNHmybNAVJrGw1SHMC8bGuBJrzVnC10qnUSj9MWfJFJWqhs6WmcS7y3Xae4Yqh6HceI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755521167; c=relaxed/simple; bh=xOSBC4XrMZ8JAupJZmPq6It+DWa+bypcke8bHJybzYg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F1eGpyV2UaphTLHY+7ig7jjRz9jM0G2GlrxSp2z2uI09jTI1eK86Moc2aDNKb49h4/GEkWehYSau4LCgtwEjxMRcDHK7yRekaPOz3HyutiArH1y8JEE4kLXZ62SvUbWv+pi06OfdYcRVGGEKAXUrY+Xcy1M87WJ2RXxuMZDhckE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iUEsdV2+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=AqAnuQfh; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=iUEsdV2+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=AqAnuQfh; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iUEsdV2+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AqAnuQfh"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="iUEsdV2+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AqAnuQfh" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 22C0621202; Mon, 18 Aug 2025 12:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755521164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZyTaJV4H2K1FdAE1ksZTx4V5FzCI7Mttwmp8s0NSmLE=; b=iUEsdV2+ChkIQA0SzYMWcyWMjcps0SL7S5CegkYTFeWgU8nZVoFh9W5kNXBisO+YQ9B1eX mSTFCsR7H0E8rxOGqmrkDZbEiRyoGHqzlshEAwiReKVkQL3OognDAtkhV6od2SwnIh9kTM RvmiKxd+9KYdyO0Jdl9Bo5Q7aCSpI3w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755521164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZyTaJV4H2K1FdAE1ksZTx4V5FzCI7Mttwmp8s0NSmLE=; b=AqAnuQfhuvpzjyQvAwc3VRdBGhUaakPMmd2PVcmZKNNB3Xjhx26usfLdsaNmdSCGZxLulZ UTYUhIeQsE3kXRBQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755521164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZyTaJV4H2K1FdAE1ksZTx4V5FzCI7Mttwmp8s0NSmLE=; b=iUEsdV2+ChkIQA0SzYMWcyWMjcps0SL7S5CegkYTFeWgU8nZVoFh9W5kNXBisO+YQ9B1eX mSTFCsR7H0E8rxOGqmrkDZbEiRyoGHqzlshEAwiReKVkQL3OognDAtkhV6od2SwnIh9kTM RvmiKxd+9KYdyO0Jdl9Bo5Q7aCSpI3w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755521164; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZyTaJV4H2K1FdAE1ksZTx4V5FzCI7Mttwmp8s0NSmLE=; b=AqAnuQfhuvpzjyQvAwc3VRdBGhUaakPMmd2PVcmZKNNB3Xjhx26usfLdsaNmdSCGZxLulZ UTYUhIeQsE3kXRBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BFE8C13686; Mon, 18 Aug 2025 12:46:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id prFpLYsgo2iqeQAAD6G6ig (envelope-from ); Mon, 18 Aug 2025 12:46:03 +0000 Message-ID: <7c2d8894-7eb5-4c86-a80a-935fcf24ef83@suse.de> Date: Mon, 18 Aug 2025 14:46:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/amdgpu: Pin buffer while vmap'ing exported dma-buf objects To: =?UTF-8?Q?Christian_K=C3=B6nig?= , sumit.semwal@linaro.org, oushixiong@kylinos.cn, alexander.deucher@amd.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org References: <20250818084148.212443-1-tzimmermann@suse.de> <6f409954-2e01-4e87-b8b7-5688bea837f6@amd.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <6f409954-2e01-4e87-b8b7-5688bea837f6@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWELVE(0.00)[13]; FREEMAIL_TO(0.00)[amd.com,linaro.org,kylinos.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -4.30 Hi Am 18.08.25 um 14:40 schrieb Christian König: [...] >> +static int amdgpu_dma_buf_vmap(struct dma_buf *dma_buf, struct iosys_map *map) >> +{ >> + struct drm_gem_object *obj = dma_buf->priv; >> + struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj); >> + int ret; >> + >> + /* >> + * Pin to keep buffer in place while it's vmap'ed. The actual >> + * location is not important as long as it's mapable. > Yeah, exactly that won't work here. Most of the locations are not CPU accessible. > > You could use AMDGPU_GEM_DOMAIN_GTT, that should most likely work in all cases but isn't necessarily the most optimal solution. No problem about that, but why not a bit more flexibility? When udl copies from the buffer, it is likely pinned to VRAM. A bit mask of _CPU, _GTT, and _VRAM should work fine. The other domains are probably irrelevant for our use case. Best regards Thomas > > Regards, > Christian. > >> + * >> + * This code is required for exporting to GEM-SHMEM without S/G table. >> + * Once GEM-SHMEM supports dynamic imports, it should be dropped. >> + */ >> + ret = amdgpu_bo_pin(bo, AMDGPU_GEM_DOMAIN_MASK); >> + if (ret) >> + return ret; >> + ret = drm_gem_dmabuf_vmap(dma_buf, map); >> + if (ret) >> + amdgpu_bo_unpin(bo); >> + >> + return ret; >> +} >> + >> +static void amdgpu_dma_buf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map) >> +{ >> + struct drm_gem_object *obj = dma_buf->priv; >> + struct amdgpu_bo *bo = gem_to_amdgpu_bo(obj); >> + >> + drm_gem_dmabuf_vunmap(dma_buf, map); >> + amdgpu_bo_unpin(bo); >> +} >> + >> const struct dma_buf_ops amdgpu_dmabuf_ops = { >> .attach = amdgpu_dma_buf_attach, >> .pin = amdgpu_dma_buf_pin, >> @@ -294,8 +326,8 @@ const struct dma_buf_ops amdgpu_dmabuf_ops = { >> .release = drm_gem_dmabuf_release, >> .begin_cpu_access = amdgpu_dma_buf_begin_cpu_access, >> .mmap = drm_gem_dmabuf_mmap, >> - .vmap = drm_gem_dmabuf_vmap, >> - .vunmap = drm_gem_dmabuf_vunmap, >> + .vmap = amdgpu_dma_buf_vmap, >> + .vunmap = amdgpu_dma_buf_vunmap, >> }; >> >> /** -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)