From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazon11020131.outbound.protection.outlook.com [52.101.191.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C70A32D45C for ; Tue, 17 Mar 2026 15:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.191.131 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773761564; cv=fail; b=lcU9fMujyS3wsjf+h38/sw5NbXgQS52GQpcNbp76h8CfhiqDuOMuqczB47AWjZFDVadzyUXWOjS2ugs+6Ty1wwB9RrwgjywqQ3oBrVBR7PcAeD/a65MhkekjxOjVwVI7edIoaP/d963+9b8jbIkZ6LRZDI8OatRr4QPGqIZkCts= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773761564; c=relaxed/simple; bh=MRZCa0ABs5n087BtRsmxfkFVjSLc8b5IG1h1Tyzq1ps=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=OxSsbKbhqLxcESjOQH5Zk/jI26QxjiGcAHH/sWgbKmgnRE6poN/DJc2aEHsvl93KkAlnd7RTt9TZShf/6Nqq+NNXMqDfK9KhzqoqKAGW07cCg4OazPdI3OtrmP0TaGXIGX4ce5KIMvkvCkdvbFIrApAvCvGiMFuIg1+iam323fU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=t1Uxv9Qh; arc=fail smtp.client-ip=52.101.191.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="t1Uxv9Qh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=V/7P+PQkIGyBr5+01oKsDfFitc2EtfWW75ECAGSMGejLxl7jY8CN6A99y+dj+vRLt/SGz29Kuqlk0JEy6aGrlfgtl1tL7E99fu24wHZwNu6PJhEcM1G4EH6y3dE97NJ4g19AdgRQGYdsZJrvk0tZOqfU6PHDGMHW4cXNJVrfyA84vss/7bP5JvUDcU0Z/9V7RkjHeswbASIUgW8EIvBhPKTp+k5uJdvYJSRR+0DDBOeLJljK0pfFQttUuGRs2YJLGP+SkwE4gyNHNfjn3kFQacDZmZowAZSDHq4Ad2loK8YTWAUiQvr7O8S9p+PE1QF6CIWZtlo8mzdAAMzVrnNnfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5FGP2HeWOXj+rjKHH8VIryfT8ZnCLBHodxHRUY6uPls=; b=o4HSog0YZCRuCGAqufs22a/zMmufUeADVDkSw6WDr+qleX8zZ+I1IlTLUufjGSx+brqO/M7OSf4fdUYkxnMeOswhPL3eGeFkjEZxSdr3h1AwR4Due+65W6ehPsKCw0DRC/A6M2oi5svBWUjD6yEDuKpNORkMCfiJRl4cBaYrGLa9tfI71OM0o6NHH1a6YOA96SgSxBTipGB+LWX2sifAvR63d4y5fHYUAeLLnHnELnz+1LA2klRSzuCD5khwHRah6B09IYlzF7+IPhLFgS8/PP1jFv3Xr0UQFF2R76BkYH4gs2QKJNhyUmcYMKMW5gf4rjrtBasMaX/Kk+2RTIUgTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5FGP2HeWOXj+rjKHH8VIryfT8ZnCLBHodxHRUY6uPls=; b=t1Uxv9QhU9RTaX8PglTZahsGChrp1Cd4rd4yoee4Vpy4KFQ57PPTA/MfrJPnvu381+Cw/PupF/p4R2Gq3h6WbjkNjjAZU4MaNxko0sKiem88npI2gxo4KmmeNbZb8QowvnupPxSg85o2A1IP239cYR+ioYg2acI4DAN11MEGm6C64EMCFD6OX2aX6lwI+iQu6LgYQBMDj7vcQGjNLxuJRJ1qdw6KI0kGE2JMeWLsnm+tsUixuIoGHr4zuN+rsdpWYRW/+x/Iv8tCrh0AHRo1bI0oODVJz8T2Rm8WkhjJQvAtwb4SKGI97BwfelpfDwmiGcSw9IWWutAct8ItdHQx2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) by YT1PR01MB8860.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:cb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 17 Mar 2026 15:32:35 +0000 Received: from YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1]) by YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM ([fe80::6004:a862:d45d:90c1%3]) with mapi id 15.20.9700.024; Tue, 17 Mar 2026 15:32:33 +0000 Message-ID: <7c30cd2d-8d90-484e-82c4-4f79e9bf8698@efficios.com> Date: Tue, 17 Mar 2026 11:32:33 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] lib: skip percpu_counter_tree boundary kunit tests on single-CPU To: David Carlier , Andrew Morton , Josh Law , Mark Brown Cc: linux-kernel@vger.kernel.org References: <20260317150638.37438-1-devnexen@gmail.com> Content-Language: en-US From: Mathieu Desnoyers In-Reply-To: <20260317150638.37438-1-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0040.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:1::17) To YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:be::5) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB9175:EE_|YT1PR01MB8860:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cb62ca0-4c0f-4c54-2281-08de843a6899 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016|22082099003|56012099003|18002099003|7053199007; X-Microsoft-Antispam-Message-Info: 9Kh5nkDMxxYW8EIytdINKeBcOAQb3vRpchl/5BpqxBy+sUteb2hBd9nb6mdN6UEmn292Hk+bcjqcNQ/UvlSLNwLmqkY01eUy0FIlHat2ZIlnSUUs7QA//NMIY55AxjeA4EiyCdxGeerDaGmRJDWKs8UADxROK/iV5xCUkLeFMrfxBW8cR0MIbFxCF50J3Micd5HUr0UXoGI1/VAQ0CxzK/swIu7CBc+nn4HV2ZLB/D4pyu3V0IyYmZvNyIhz9x/9TliLFMeBUNcEbAKy+OovhKNttBJlta+WZBSZSpJxMoAtXRtS3bCoy40yaa26dc2G9ppnScykNB5TxUrnVFW8PgDg5bD3VexNETtCz9oNFALTIboFaD/yQKJPDh7QmXhOP8m5QUyXbAOCibaLpDCPrtrlHWS6hq8MA/Nr6onrqzDcLsLneQMQ2mx2tY5N7npFgiFJGYeIFXUD18L/6TBLXsHg+R1aU+aRQ7hWMtpFmiosuyORgwfKM3RnG8QW0mLY+ScJECf9Um70/a43q97BAFkPWTfytTHcounmSh067ipwg7nsklzrh3AEoy6lTlpoLqLHiboRtx71+4l3HRPDqu513jizRs4RbLx92bsB9VbeesqjP5gEODzvMRpJCery7vvVYqGGsHIR+PojkP8BVftRHy6wKaGchG8rjJHqiGA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(22082099003)(56012099003)(18002099003)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2xxUzFKb2tLbWNnNDNadnJPRzFaYS9OUGRLVmpwL2lnYnFjQkJ3YTBJMUcv?= =?utf-8?B?YW5OS2U0SitSYTBQc1FMelRET3dWakVYL21qbUsrc0NWcEd0bVZyTjJ2b3B5?= =?utf-8?B?U3BMRlZ5RnhKNmJ6T1JGbEs1WFMrRG9Wc0ZUQUw4OHRYa0tnZEF2eEtYRTNF?= =?utf-8?B?akxQKytzT1ZLVlFyZFJHYWtlaC9FdDdLcUtFRmtVRyt5UnVmWnVidXBqZ2dW?= =?utf-8?B?cnhxalhSSDFaUjBnZjdIZ1Q0MmpSNmlxekVUL3dVNVlUSzl5dDJNMVRyQnht?= =?utf-8?B?bVMwREw0dVBBMU9CWXNWOWtGUlluanY1b21xWDVITkoyaTZjRFE4ZW5taXFG?= =?utf-8?B?SHNpUldMSlVWV0VieUE4cDdFUkVaWnd4M0pUcWFhUXBVbWFFdjhTQko5N2Vm?= =?utf-8?B?LzFZMnNKVkY1NnRjOHdyZ0R6ek03TFVzMjBMUjZXNmIvOXRNZmt3MnVQeXpM?= =?utf-8?B?NHR3dEdsc3I5NXR5ck1zQ1R0eWMxajViSGgvclZzRFJuZ3FBSFBZRWNRaVNZ?= =?utf-8?B?aG40Q2had0VBYS9qZWgyV2NzNDJVRTNYYkovNzM4enhxR3VkZ2MzbDlTREpT?= =?utf-8?B?cUpKZEJ5ekNHWXZGQ2dRYjJGRUxZWkVoaElJaTNyL1F6NXdWTXlYdHVBOGpk?= =?utf-8?B?dFVyTGdoNkp1Q2dqTzhVZVJTeWVsOUFGUkMxWkczd0lmTTlLajdqbUVqcUhk?= =?utf-8?B?dEVCSFBCNWJkdDVxWTNMUXljcHJZZlFHdllwZU1TR202c3NWYkduVWVxWk90?= =?utf-8?B?dUY3cG5pZGN1Q2MrUWNJbzc2RWdodXJMMmNxRVNNeVgvQzM2TXBMMVZoMnlk?= =?utf-8?B?czRBUjBSVWNsd2g5U2Y0SzJQZ3pvQVNkamVWOVBOYXczZVExa25pcmhpNWFG?= =?utf-8?B?WUJ0SWdnRWxtOFJ5alE4QlZsTlFMYTJCMGNpdVhoSnphM3c1U2NSeGZYM0RZ?= =?utf-8?B?dStjVTZjTnJsNW4rSElIYVNzdkVXN2hsQmFUK0FxRDA5MmdSZEJuTy9DdkdR?= =?utf-8?B?ZEgvb0tzcGJIT2RIc3BsSnBXV1hybGRoRFBPZjc4UWQ0UXdGazAzTFRsRERT?= =?utf-8?B?RkJSWWh0RkFhT2xXZUkwK3dkU09DVmhzMDcvNk5mbEtrZDZIaWtrbk5YNExv?= =?utf-8?B?bjlaRHFIZmMyT1NmVEZFUHpMN3daWmFjZ0Y5MG1XYmFROVRVR0k2cURJNGJM?= =?utf-8?B?LzR3Y2FpSnI3ZTZENS9melpta0k1WHRzbDRSWjFGajN2aGJHUFZjTGlaY2Mv?= =?utf-8?B?SnRPSENwZDlKdVVTZlIzU0hSUUlNVnJLVjhJeVh5RjRhR2VibU9zMHhJNllX?= =?utf-8?B?SnA4bUs4cUNicDJKUXFObkpnMVVEaFdSYjhGbURRaWZDNHRVTG1oeFB3YUdO?= =?utf-8?B?aENhRElpVWRlV2NmbWl6UGtnNUpjY2ppUlorSGlXdTlKdVlUMklEeXFLN0d0?= =?utf-8?B?TklRbG1CQ1p3M2FJSUpUdkErUlVCYU1WTm1WMis2dDlZc1ZRTkF6bC9jVTV2?= =?utf-8?B?MkM2cVZBRG10bWxSUXhPOVVCYmd1QnFJanhrZnF0T2dLaTY5SXZ1Zjg0MUtP?= =?utf-8?B?dkVia0UycTJpUElmK2IrZ3c2U1FqZFppaTlnUEpqVC85TFIyMDd6bTU4ZVZH?= =?utf-8?B?U0hGeldVNE5VR3lVajRGNnhxMnBDS0dBNkcrYnNxYXkxdU5Jb1lKbXpPbXd4?= =?utf-8?B?SEtXSFhTOFoyNmIwUjhIc0RPaG9WU2ZvT0dsTjJ4K2xSdEl6ZDh6MEhwd2Fy?= =?utf-8?B?aUd5QTh5Z1BWdWcrdFJwOTlQWUpEYmRrYjI2MDVFcXZncWZCQU16Q0xEWVIr?= =?utf-8?B?Wk45MVIwcGw3YW5renFBRDFXSFM5NWtpSTZ3S3NyNFNXNlVVZVlITnBJT0M2?= =?utf-8?B?MUxCV0RnMldYMUdLU1hCUWNvM0Y5dkd1c3A3bVFGZ2JGc3ltNHNsY0I4Qy96?= =?utf-8?B?QUViRWdLREdLR3BqY3lGaVpUQTF3aGpSSjgwL0FreGdNaXJPZ284U3RqUEI0?= =?utf-8?B?SlVWTUhieU0zK0szbldOWDg1Y1dVSUJHbmx2ano1Nm4xRVk1RXVkVVo0bVZ0?= =?utf-8?B?TGNSdy93SllFVFZkYnp6VWs5NzNicHNvOURYUytvSjlHK25Sc1BZTXBBanZn?= =?utf-8?B?S0dUaWc1dGJySCs2b3QrOHRuUi9Tb0ZWdEI3Ry9XTkhhWmpmUjVHT3gwbkhZ?= =?utf-8?B?Q2hRZHVFS3FYSFBST3pGeUpYZjlpL212cjhybkpwNjdJZHlwUmxabEtGcGcv?= =?utf-8?B?a3pIQW9YRUVPQVQ4MitUUjhRaW9HZkh5SHkxcEVxaTZWTWpMb0RHMXU1Qm01?= =?utf-8?B?bG1sQ2M0ZkF5b0J6Umh4OFlqemJzcndvZXJPTkpVVmpKZUlIblV0c05aK3lB?= =?utf-8?Q?gm3eqoqAq0UiaLqpWDIXwqTN0kFUBPyn597Ke?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb62ca0-4c0f-4c54-2281-08de843a6899 X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB9175.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 15:32:33.2318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j+xH9aMUvhTSuhY+wnoN8zPjFP2X6IjrQE75t8R6wwMrWGR/TcABcjklDzBp8zSh14XNbZ0na6gY9YNZA7O7hG/7H8plTNwzAaJNhTE/r8M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8860 On 2026-03-17 11:06, David Carlier wrote: > On single-CPU topologies, accuracy_multiplier is zero, making both > approx_accuracy_range.under and .over zero. The boundary tests in > hpcc_test_compare_value_boundaries and hpcc_test_compare_counter_boundaries > then degenerate to comparing 0 vs 0, which correctly returns 0 (equal) > but the tests expect nonzero results. > > Skip these boundary tests with kunit_skip() when accuracy is zero, > since approximation boundaries are meaningless without multi-CPU carry > propagation. AFAIU kunit_skip is implemented with kunit_try_catch_throw, which aborts the specific test function. The placement of those kunit_skip appears to leak memory allocated with kzalloc(). Am I missing something ? Thanks, Mathieu > > Fixes: ebc1ff504f55 ("lib: add kunit boundary tests for percpu_counter_tree comparisons") > Signed-off-by: David Carlier > --- > lib/tests/percpu_counter_tree_kunit.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/tests/percpu_counter_tree_kunit.c b/lib/tests/percpu_counter_tree_kunit.c > index 4d058bc78f7d..609992bfaa21 100644 > --- a/lib/tests/percpu_counter_tree_kunit.c > +++ b/lib/tests/percpu_counter_tree_kunit.c > @@ -101,6 +101,9 @@ static void hpcc_test_compare_value_boundaries(struct kunit *test) > percpu_counter_tree_set(&pct, 0); > percpu_counter_tree_approximate_accuracy_range(&pct, &under, &over); > > + if (!under && !over) > + kunit_skip(test, "no approximation accuracy on single-CPU topology"); > + > /* > * With approx_sum = precise_sum = 0, from the accuracy invariant: > * approx_sum - over <= precise_sum <= approx_sum + under > @@ -214,6 +217,9 @@ static void hpcc_test_compare_counter_boundaries(struct kunit *test) > */ > combined = under + over; > > + if (!combined) > + kunit_skip(test, "no approximation accuracy on single-CPU topology"); > + > /* --- percpu_counter_tree_approximate_compare --- */ > > /* At boundary: indeterminate */ -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com