From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347BE3859F5 for ; Wed, 3 Jun 2026 14:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495464; cv=none; b=IGrfrjTr41Q57tE35SMJuayiXfayP8H3lvrN3SMnX82oQ88nIXQRWxWhQk1sjJsT98WFYHO3kgZywFbfIEi/+v0fNCKyMb83pUB9ofdB1vrsTnSb7IQXQaVTiPoVUlR9/QmLTh0oDk3enwyHOkjXSV14JNY4XLNDwTrjNKUWlys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780495464; c=relaxed/simple; bh=xYkbXhu7MDhbg/KOcFclCa+1Zm4Y9NpS4pWis5ZBpkc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u22n5jYMDs1lC/qw+aPFh8f/FROpIV6GPKNOwgzwuioX10yoJRdqybQV5P0+7d94UknmN04oQqQ3dD7UXB1jbJV78SZMiNA8YBmP7FVrsaT1uRUEsoIvX6QBdEr2Fsh4y2MdUKLWnzvNvNP8Oeml5DZAtwikx8MzQJAKco3gWX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KFGZv6Pw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IQ04PDYc; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KFGZv6Pw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IQ04PDYc" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6539vYh92368138 for ; Wed, 3 Jun 2026 14:04:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jOMKa2J8SL3wZtOufHuOjFi4CgBpP5AYCYvYXdxBH2Y=; b=KFGZv6PwieYvHGIJ U2qQ3s3X4/PejNKI/Xd5OxgGLEAHRrKdqc+bbVd2VcG1hA4Ucvi9nxXEp4xBDxLv VJ/y1L34uzYZllelJEuxGiF2WkYEjQ5elrjfo+ygImnct/qwxPA8/3FJbEeFafIX dYhDiY8VhhqcDWqMzBTv8L8Oue+LhmY+UVVuXMEBtopVLbFTaVkBjuOgJiIwVi9O 5dfNLcO6W5EzSeAGLFT15uOvkWZEBgt2Li4/DLPXxgjLDecItNs3K5J36UkW5dfx zBjzwnVCyuP74+nsx9xz2UdEGf+MCwF6q+9U8fJosedgn+G6N0Y9ZauML5cA62yj Z3Foig== Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejj3ggwea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 03 Jun 2026 14:04:19 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-48611bf4ddbso603717b6e.2 for ; Wed, 03 Jun 2026 07:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780495459; x=1781100259; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jOMKa2J8SL3wZtOufHuOjFi4CgBpP5AYCYvYXdxBH2Y=; b=IQ04PDYc5NneEttXLZcQ831lruqg1X1PRaJ7ycpOsDONUBt5A5EyV9Ndyupy6iGl5z gxeDQ2e5TNznKtEOCeXqf8SCSLxkr2qLep6qF+upaNQcBKyMvc5nTAFGGLJQGgnHtt6P JJyEqZfI5r9u3TJrUZWfXo57cTKKz5M8VCbUcMbMGfvRWs8heHW0shXkofRqDsvbI/GY 8xr0d4vDXtsIeY4IgOI7Vi9eMPIuJ8qp/5ru0V/lBctYVGQljb2P1kkMgb7TDFy2nwIe JS+8uHGWH1JlLPrP3CTlZgBEBzvHkI4BJWIH6IIzpOkcE0GZIKIh6Wd1kIkcpvr6iapR j7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780495459; x=1781100259; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jOMKa2J8SL3wZtOufHuOjFi4CgBpP5AYCYvYXdxBH2Y=; b=DSLi9hvHjaKaZJ0xc+ovTGhnk8bTCVxfGDuUN7IDXbo2OyOHuD1+U8E5xWuC3Jf/fr gSBfEWxy2vj09Zb5ETXMdHdilFzQVnlKuGsdeTAgNGpjwUCPvf2VvDRMd3cIPoU8ndFc TWpoj+oGwv3fJxDg8Atjj7uB34uZIQAF8eULZWtppYRXxaaPgpaiJ1fAnxzV/IBfYx+d HSV/kyunWo/HJThTkXUw4vyefeIV+eL9Ue5q1KW9khIWJD85yxwLDA68yrSF9ekBGWyU vUFKHW7n9IoL3RHdANzggOByKmhedPuvbV52TtJ89WTGObLc+Ahc+RdCegzJD2oGg8hy JfHw== X-Forwarded-Encrypted: i=1; AFNElJ+Gw38kJf1TKOvjzOc5e3sLxPuMy7RDFrHzsNzmwyBUdHF9zmYpemTtsX5yjYv4NQFjXoPM65BK151TFB0=@vger.kernel.org X-Gm-Message-State: AOJu0YworKjyz7+8d2QA74qbXlKYs+KaOd5k6bL1tnHNXyIJ6vTDbaCK N4Ldjq8IRL6kKDAN/U13iWupu1NnU2z9p2/6z84WZQGyNYMXTtbIGicyVEUOWlcfXxdIVPLABTF J8pM4Kgj+EiX+bTjxKI8QZ7Rhs7syW2OfJxiCHZTjyH9Bwzff4Psnv07uM5iP0O6PLUM= X-Gm-Gg: Acq92OEsmHMxo7Mu+mwls8N++HvVjzIIS4KsApQnaysQuA6IuCYoYaYtBJGN43a/Lh+ aAmMZtxdCOHrjTY6vBIg/+HJovgkIIasSzn+jOos5DFoweqCJcpnrD1XMB4qq0e8DuGLUr1gegA u34N0wGT3sE3L0UbPx1sJtN7v9kZwt6w0vPgKHnLg8PPjHUjSgX0DMEXNTpwK0wczBKwLR929UE MqAVj94xBVywPEpHXLz2RrwLJq0ddXrHdHuSejVfbf7phBdqMiRo70fTHTpQAqgZGGchim1nd74 hLCEG1gPRJ11ys3hknX02kbq2WR/UtSqC4Tr9IZQ8UUngKcaoT0lZylpKknL6pd3iIwj/KjV7n1 v9Sid9lfRfH0ezEpPvZNsC4zJKjDr2fqdv/RFg5I2liQSLvXa7sNQXLy9oKeoH8cSgQrobMDdWB Ut92jAkc9tVZY= X-Received: by 2002:a05:6808:2219:b0:486:4ae9:f9b6 with SMTP id 5614622812f47-486574df950mr1368423b6e.6.1780495459026; Wed, 03 Jun 2026 07:04:19 -0700 (PDT) X-Received: by 2002:a05:6808:2219:b0:486:4ae9:f9b6 with SMTP id 5614622812f47-486574df950mr1368391b6e.6.1780495458579; Wed, 03 Jun 2026 07:04:18 -0700 (PDT) Received: from [10.100.11.76] (public.toolboxoffice.it. [213.215.163.27]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65867e67sm1200920a12.21.2026.06.03.07.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 07:04:17 -0700 (PDT) Message-ID: <7c33cf4d-4281-4e26-b1cf-fb6635b01b72@oss.qualcomm.com> Date: Wed, 3 Jun 2026 16:03:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] arm64: dts: qcom: monaco-arduino-monza: Add QCNFA725B WiFi support To: Qian Zhang , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org References: <20260531071409.3557734-1-qian.zhang@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260531071409.3557734-1-qian.zhang@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDEzNSBTYWx0ZWRfX5zrnY6yAuzPv vnmgl1BBeq6lYHNqJoMIP+hkIEQPIBwWH17OHlrOqucDa+rnz0VZTnx9Qzm3Jv9m/Fa5qWVLl2P HRLNVIsL/YqlkgH5YeDo3bm0w13Mc65AepKuZ0NvQBl6Ul1cR4Y6anddJznqY8dcm3ggcnXlB11 BBUHf+to9Ne2jf2ufhVWMpoSzS8fKY3Sd2RbMBfaFkyAOk5mscqDRrqgC7lsgdJ5vJJx+KvfBw7 E94s7Ly3vYJfoAjJ3Wm4+HNdq6fWcXtQkrCEO4CKs/BGL1IetTY3WdzQDTAP5yCbPOaMchiZqLz 64LF+7bZ1kbSF7BCjd8k5/ERbDAfSxhPWfEazmrmshT8eKDVtM0MpkdAlzT51e2uWM5nQp4jD6z AI6sdd/463s9FOY4dNoWCSHpxIHp6k5Eba/F8N4AbUP7Q1y4cYELD6Y2rlgpARkfRDh46LXJo4i egI2A3jiw1KJ96hoR1A== X-Proofpoint-GUID: YqW8tHsmDLO_4tHpOEJeTzROOHlkrwx- X-Proofpoint-ORIG-GUID: YqW8tHsmDLO_4tHpOEJeTzROOHlkrwx- X-Authority-Analysis: v=2.4 cv=UvhT8ewB c=1 sm=1 tr=0 ts=6a203463 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=aBIYUfOEhgoR9egqXYNcqA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=e5wiE9tdTxe0cX7xfckA:9 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_04,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030135 On 31-May-26 09:14, Qian Zhang wrote: > Add support for the QCNFA725B M.2 WiFi module (WCN6855-based) connected > to PCIe0 on the Arduino VENTUNO Q board. The following DT nodes are > required: > > - qcom,wcn6855-pmu: manages GPIO56 (wlan_en) through the > pwrseq-qcom-wcn power sequencer, and exposes the WCN6855 internal > LDO regulators consumed by the wifi@0 node. > > - rfkill-gpio: exposes GPIO54 to the rfkill subsystem for RF state > management. > > - wifi@0: describes the WCN6855 endpoint on the PCI tree. > > Signed-off-by: Qian Zhang > --- [...] > + rfkill-wlan { > + compatible = "rfkill-gpio"; > + label = "wlan"; > + radio-type = "wlan"; > + shutdown-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&wlrfkill_default_state>; property-n property-names in this order, please, everywhere [...] > + vddio-supply = <&vdc_3v3>; Just one space before the equal sign and one space after [...] > + pci@1,0 { pcie@ [...] > + wlan_en_state: wlan-en-state { > + pins = "gpio56"; > + function = "gpio"; > + output-low; The driver that you pass a reference to GPIO56 already controls the output state, drop output-low Konrad