From: Joe Perches <joe@perches.com>
To: "Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Andy Whitcroft" <apw@canonical.com>,
"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Louis Peens" <louis.peens@corigine.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Simon Horman" <horms@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Cc: Junio C Hamano <gitster@pobox.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Also accept commit ids with 13-40 chars of sha1
Date: Tue, 05 Dec 2023 12:05:37 -0800 [thread overview]
Message-ID: <7c353e1ba4025dfce4c4789033f5779c4371f048.camel@perches.com> (raw)
In-Reply-To: <62f82b0308de05f5aab913392049af15d53c777d.1701804489.git.geert+renesas@glider.be>
On Tue, 2023-12-05 at 20:34 +0100, Geert Uytterhoeven wrote:
> Documentation/dev-tools/checkpatch.rst says:
>
> **GIT_COMMIT_ID**
> The proper way to reference a commit id is:
> commit <12+ chars of sha1> ("<title line>")
It's not just checkpatch.
Documentation/process/submitting-patches.rst:``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
So that would need to be updated as well.
And 12 still has quite some headroom.
$ git rev-list --all --abbrev=0 --abbrev-commit | \
awk '{ a[length] += 1 } END { for (len in a) print len, a[len] }'
5 107
6 684276
7 505734
8 41769
9 2665
10 174
11 8
next prev parent reply other threads:[~2023-12-05 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 19:34 Geert Uytterhoeven
2023-12-05 20:05 ` Joe Perches [this message]
2023-12-06 7:45 ` Geert Uytterhoeven
2023-12-10 21:56 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c353e1ba4025dfce4c4789033f5779c4371f048.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gitster@pobox.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=lukas.bulwahn@gmail.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=philippe.schenker@toradex.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®