From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751401AbdHXIF7 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 04:05:59 -0400
Received: from hermes.aosc.io ([199.195.250.187]:46123 "EHLO hermes.aosc.io"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751183AbdHXIF5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 04:05:57 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Thu, 24 Aug 2017 16:05:54 +0800
From: icenowy@aosc.io
To: Andrew Lunn <andrew@lunn.ch>
Cc: devicetree@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, linux-sunxi@googlegroups.com,
        linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Icenowy Zheng <icenowy@aosc.xyz>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay
 mode
In-Reply-To: <20170822133906.GG24555@lunn.ch>
References: <20170822040400.12166-1-icenowy@aosc.io>
 <20170822040400.12166-4-icenowy@aosc.io> <20170822133906.GG24555@lunn.ch>
Message-ID: <7c43220aef447e5cf21e48a9eca18535@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

在 2017-08-22 21:39，Andrew Lunn 写道：
> On Tue, Aug 22, 2017 at 12:03:59PM +0800, Icenowy Zheng wrote:
>> From: Icenowy Zheng <icenowy@aosc.xyz>
>> 
>> Some RTL8211E chips have broken GbE function, which needs a hack to
>> fix. It's said that this fix will affect the performance on not-buggy
>> PHYs, so it should only be enabled on boards with the broken PHY.
> 
> I would not call this a broken PHY. It is a question of board
> design. If you have shorter tracks, you need a delay. If you have long
> tracks, you don't. Hence the four RGMII modes, so you can select if
> the delay is needed or not, depending on your board design.
> 
>> Currently only some Pine64+ boards are known to have this issue.
> 
> Design feature.
> 
> Please remove all reference to bug.
> 
>> This hack is said to disable RX relay for RTL8211E according to 
>> Realtek.
>> So implement it as RGMII-TXID mode.
> 
> Do we know that the TX lines do have a delay after making this change?
> We need to be careful here. We will get into a mess if this is
> actually RGMII not RGMII_TXID, and somebody designs a board which
> needs RGMII-TXID.

In fact I'm not sure -- I'm even not sure that after making this change
there's no TX delay. The change is totally not documented, so I choose
to use a custom property in v1.

But Florian required me to use RGMII-TXID instead.

> 
>> +#include <linux/of.h>
>>  #include <linux/phy.h>
>>  #include <linux/module.h>
> 
>> +static int rtl8211e_config_init(struct phy_device *phydev)
>> +{
>> +	struct device *dev = &phydev->mdio.dev;
>> +	struct device_node *of_node = dev->of_node;
> 
> You don't appear to use of_node, nor dev. Please remove, along with
> the header file.
> 
>     Andrew
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel