From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>, <kexec@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Will Deacon <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Randy Dunlap <rdunlap@infradead.org>,
Feng Zhou <zhoufeng.zf@bytedance.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Chen Zhou <dingguo.cz@antgroup.com>,
John Donnelly <John.p.donnelly@oracle.com>,
"Dave Kleikamp" <dave.kleikamp@oracle.com>
Subject: Re: [PATCH v3 1/2] arm64: kdump: Provide default size when crashkernel=Y,low is not specified
Date: Wed, 16 Nov 2022 19:50:03 +0800 [thread overview]
Message-ID: <7c474745-1bec-93d6-0b82-9171e8149c0d@huawei.com> (raw)
In-Reply-To: <Y2kRC7JALMQQRsxE@arm.com>
On 2022/11/7 22:07, Catalin Marinas wrote:
> On Mon, Jul 11, 2022 at 05:03:18PM +0800, Zhen Lei wrote:
>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
>> index 339ee84e5a61a0b..5390f361208ccf7 100644
>> --- a/arch/arm64/mm/init.c
>> +++ b/arch/arm64/mm/init.c
>> @@ -96,6 +96,14 @@ phys_addr_t __ro_after_init arm64_dma_phys_limit = PHYS_MASK + 1;
>> #define CRASH_ADDR_LOW_MAX arm64_dma_phys_limit
>> #define CRASH_ADDR_HIGH_MAX (PHYS_MASK + 1)
>>
>> +/*
>> + * This is an empirical value in x86_64 and taken here directly. Please
>> + * refer to the code comment in reserve_crashkernel_low() of x86_64 for more
>> + * details.
>> + */
>> +#define DEFAULT_CRASH_KERNEL_LOW_SIZE \
>> + max(swiotlb_size_or_default() + (8UL << 20), 256UL << 20)
>
> I agree with Will here, we need a better comment and we might as well
> change the default value to something else until someone tells us that
> the default is not large enough. The default swiotlb size is 64M, so we
> need to cover that. The extra 8MB for any additional low allocations are
> ok as well but the 256MB doesn't make much sense to me, or at least not
> together with the rest.
>
> If the main kernel got a command line option for a larger swiotlb, does
> the crash kernel boot with the same command line? If not, we can just go
Sometimes the image is shared, but the command line is often different.
The command line of the crash kernel is specified by kexec --append=.
> for a fixed 128M value here, which is double the default swiotlb buffer.
Sorry, I missed this e-mail. Yes, fixed 128M would be better. I haven't
seen anyone adding "swiotlb=" to the crash kernel. And, if the default size
isn't enough, he can use crashkernel=Y,low.
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2022-11-16 11:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 9:03 [PATCH v3 0/2] arm64: kdump: Function supplement and performance optimization Zhen Lei
2022-07-11 9:03 ` [PATCH v3 1/2] arm64: kdump: Provide default size when crashkernel=Y,low is not specified Zhen Lei
2022-08-02 8:37 ` Will Deacon
2022-08-02 10:12 ` Leizhen (ThunderTown)
2022-08-02 12:46 ` Baoquan He
2022-11-07 14:07 ` Catalin Marinas
2022-11-16 11:50 ` Leizhen (ThunderTown) [this message]
2022-11-07 17:18 ` Catalin Marinas
2022-11-08 2:47 ` Leizhen (ThunderTown)
2022-07-11 9:03 ` [PATCH v3 2/2] arm64: kdump: Support crashkernel=X fall back to reserve region above DMA zones Zhen Lei
2022-11-07 17:13 ` Catalin Marinas
2022-11-08 2:06 ` Leizhen (ThunderTown)
2022-08-01 8:20 ` [PATCH v3 0/2] arm64: kdump: Function supplement and performance optimization Baoquan He
2022-08-02 2:47 ` Leizhen (ThunderTown)
2022-10-06 14:55 ` john.p.donnelly
2022-10-13 10:46 ` Baoquan He
2022-10-14 16:25 ` John Donnelly
2022-10-14 16:29 ` Catalin Marinas
2022-10-26 19:41 ` john.p.donnelly
2022-11-15 11:58 ` Will Deacon
2022-11-15 12:18 ` Leizhen (ThunderTown)
2022-11-15 13:30 ` Catalin Marinas
2022-11-15 13:40 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c474745-1bec-93d6-0b82-9171e8149c0d@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=John.p.donnelly@oracle.com \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=dave.kleikamp@oracle.com \
--cc=dingguo.cz@antgroup.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=vgoyal@redhat.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=zhoufeng.zf@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®