From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Jemmy Wong <jemmywong512@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
Tim Chen <tim.c.chen@linux.intel.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/cache: Avoid publishing partial LLC utilization
Date: Mon, 12 Oct 2026 09:04:55 +0530 [thread overview]
Message-ID: <7c4dbf1d-ba28-484d-b7e1-a713414c284d@amd.com> (raw)
In-Reply-To: <20261010113425.34829-1-jemmywong512@gmail.com>
Hello Jemmy,
On 10/10/2026 5:04 PM, Jemmy Wong wrote:
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -12121,6 +12121,13 @@ static void record_sg_llc_stats(struct lb_env *env,
> if (env->sd->child != rcu_dereference_all(per_cpu(sd_llc, env->dst_cpu)))
> return;
>
> + /*
> + * Affinity retries can remove CPUs from env->cpus. Do not publish
> + * partial utilization against the capacity of the whole group.
> + */
> + if (!cpumask_subset(sched_group_span(group), env->cpus))
> + return;
> +
nit.
When sched_balance_rq() does a "redo" and arrives here, env->flags
will always have LBF_ALL_PINNED set.
That would be a much cheaper check compared to cpumask_subset() to
ensure env->cpus covers all CPUs.
Thoughts?
> /*
> * At this point we know this group spans a LLC domain.
> * Record the statistic of this group in its corresponding
> --
> 2.25.1
--
Thanks and Regards,
Prateek
prev parent reply other threads:[~2026-10-12 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 11:34 Jemmy Wong
2026-10-12 3:34 ` K Prateek Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c4dbf1d-ba28-484d-b7e1-a713414c284d@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jemmywong512@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®