From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5D811DFE26 for ; Sat, 6 Dec 2025 03:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764993299; cv=none; b=epU/Su71SyGsrNbcvMJvih6OnpDNMZ40pRCorNxSsWo6M7Mlkyk8BpHa8lEqlsmFqumlpZgOvksDdE/AQlthgPxdH4RZaq1AVem346aj2mVJVRfs2JHpmmFawa/Wqjq8JVqwrDQXAi1mI75wMo8VYxhzOlj4dO4qlSyCCu02qvc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764993299; c=relaxed/simple; bh=J8uprbH8ZrtQtllNe0ANd6MXhGs3gViM8cbLJX7l2CQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=thA/a4sIGS2TKd0UgGw3ZbOMM2qz7dffMZKf0mpv/8gmpK/kyRcQ8Ktm9IMv4n+XDCg6oIKJGnSib4xrMr1cI3sb49gKOeWOa0VgOkNX74eSrhVck2R0UQE88dCj9D83A1NcFkPCXRK2jK+LdVFccyH8v9+a1WS6jxkk+oPrKgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fvr3tZmN; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fvr3tZmN" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-297d4a56f97so35601835ad.1 for ; Fri, 05 Dec 2025 19:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764993297; x=1765598097; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ng59e0pypFuKOiBmMzueIT3kCDd4YPpY7yGIqW1d8Wo=; b=Fvr3tZmNcY75sCVDGmJt1MQGqjGZyverZQS+na2pljj4YMs7T+Vek+cn39H25HF8FG XkL6+A/yKS+r77vZLwdBT+FQ7S9FznrjJH8cAOwpxaSeR7Mv/I9i7cRXNA0u4k8IiCc2 2NNELkAELaX3SseLC4bIoaMiiNbY6HfN1yxJwbBlkh0j4wmCKwfOa1mDiEIY9QRECOKA XMpyoB4Degxv8c6CuR7QcYgyWiDeTUZ3+ByyAyn7YaMHAWC7uxTnM5ELM6BjzfU5P8HR CK2ZtaFkHd2QjH/uFVzroHuhEQHgrG1XCalI2kRbi8EZMaM1uCF2gE7rWZOs+krKfEQN Ozpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764993297; x=1765598097; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ng59e0pypFuKOiBmMzueIT3kCDd4YPpY7yGIqW1d8Wo=; b=SZq1OwOBhN2ff7MFkSAgUiUolcAOcgzGx09zQpzXrJFM4vcRxc/kH5LlDGcpabesAT 8XRaqQbScoiiMmxOoT9Q13pUF8BsdL25mSXr53zyAVKrD05K6ouRf/FxWuagMIpCErvN 7hGPIx+hYiM/oIQ6Nf5JmuKcpVzopY7qYtvVjoq3RTvUgXiFusAcWsvmjX0MH0VuA1s6 6SWRkzPeBG8eNu0EUdxaCNvl13MzNRrVzrsP0FUEIUpsxwg0VYAemKvV8bv4z4Xym97v TJiM1V/9LxGeBP+/NgPHJ8GLwmt25rHRkD1rObTakAwmvyeID/oDHqo5oTcfEkVN0bYs 2oLw== X-Forwarded-Encrypted: i=1; AJvYcCWjIYS1sGZjx9QM4ge2Ma8B1Yp9Q3wFUveEnVCkzrG9l6V4YgzPwpz5Pu4Rr7a6wOQQ8wc29sBYEHzpHpo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx537wg19gZySpOpaJ9Glv7QQojhWvY4tJDumduo9gw2CJPy5u/ FhE06K2sEaaCrxuAPG8wVmUfWiP/DFbuZ71s5oCfpT64FmjzUcDUPi6S9XSCIdcbImI= X-Gm-Gg: ASbGncuFHm+PQhpXYI5y/gyrLWenTZ2ERsa6n2BFuuuLlZTnVw1u91eyZA7ivzB64lY k0rQrTe+YgbV7TXi//NsIhGlHGtH6SEdn6rtKjTnY0xAjlXRedk0OYMNGkKhwLmZaowYwLLUZXH fJWvtjZDv47KDKmI+/FaE3uARc4slf4FpqkV/c69cbFAGWGflD+WJEHGZAoNiNiuERS+mlafutA 7qkeSI3aL6GCorp/RfoIk4MmW2dvON1eFN2aGzuTbDzY3EWI4IdqGcf6LUoMNAISazcsyg6siVO Do2zQ80qsB3Uq1Impq7lJmpVg3g8TD3NMsfaaMWhaitXxQbEEI2MtIjw1Iw/5mz+J8JbrwB2cvV QxRacoLcB3DUo9i8duz9SiSIjyDP6UIh2KiSUt9p8NOI4YUe9m0aXfa13XCNRH9QFDCwHW5sVJ1 H8cRxAZNp+fNCtDE9nHb+sMfujBnQ/LAg2Hkb8g5nYxvM4AaWQehEOkbN4+uO0JtMrng== X-Google-Smtp-Source: AGHT+IFG/hzUjar5fFu8j9ERHWWpR9Pv5VwyPV0sXgp2FH3uasyw4TvbU/VvQYbRn3w2rYfGGhYing== X-Received: by 2002:a05:7022:a93:b0:119:e569:f277 with SMTP id a92af1059eb24-11e032b330emr1036342c88.32.1764993296945; Fri, 05 Dec 2025 19:54:56 -0800 (PST) Received: from [192.168.68.63] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df76e2eefsm24165193c88.6.2025.12.05.19.54.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 19:54:56 -0800 (PST) Message-ID: <7c54fd46-d17a-4ee8-ad9f-e98546958dd5@gmail.com> Date: Fri, 5 Dec 2025 19:54:55 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: qcom: msm8960: expressatt: Add coreriver,tc360-touchkey To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251205-expressatt-touchkey-v1-1-1444b927c9f3@gmail.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >> + sda-gpios = <&tlmm 71 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; >> + scl-gpios = <&tlmm 72 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > I don't have docs at hand, but it looks like these pins belong to > GSBI10. Have you tried using it directly? This is the log when I use GSBI10: samsung-expressatt:~$ dmesg | grep tm2 [   79.555802] input: tm2-touchkey as /devices/platform/soc/1a200000.gsbi/1a280000.i2c/i2c-4/4-0020/input/input3 [  110.242881] leds tm2-touchkey: Setting an LED's brightness failed (-110) [  167.074920] tm2-touchkey 4-0020: failed to read i2c data: -110 [  182.435009] tm2-touchkey 4-0020: failed to read i2c data: -110 I could be doing something wrong, so here are the changes I made on top of this diff diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index c4b98af6955d..fde5f739a314 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -60,33 +60,6 @@ touchkey_enable: touchkey-enable {          enable-active-high;          regulator-boot-on;      }; - -    i2c-gpio-touchkey { -        compatible = "i2c-gpio"; -        #address-cells = <1>; -        #size-cells = <0>; -        sda-gpios = <&tlmm 71 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; -        scl-gpios = <&tlmm 72 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; -        pinctrl-names = "default"; -        pinctrl-0 = <&touchkey_i2c_pins>; -        status = "okay"; -        i2c-gpio,delay-us = <2>; - -        touchkey@20 { -            compatible = "coreriver,tc360-touchkey"; -            reg = <0x20>; - -            interrupts-extended = <&tlmm 52 IRQ_TYPE_EDGE_FALLING>; -            pinctrl-names = "default"; -            pinctrl-0 = <&touchkey_irq_pin>; - -            vddio-supply = <&touchkey_enable>; -            vdd-supply = <&pm8921_l29>; -            vcc-supply = <&pm8921_l29>; - -            linux,keycodes = ; -        }; -    };  };  &gsbi2 { @@ -572,3 +545,28 @@ magnetometer@2e {          /* TODO: Figure out Mount Matrix */      };  }; + +&gsbi10 { +    qcom,mode = ; + +    status = "okay"; +}; + +&gsbi10_i2c { +    status = "okay"; + +    touchkey@20 { +        compatible = "coreriver,tc360-touchkey"; +        reg = <0x20>; + +        interrupts-extended = <&tlmm 52 IRQ_TYPE_EDGE_FALLING>; +        pinctrl-names = "default"; +        pinctrl-0 = <&touchkey_irq_pin>; + +        vddio-supply = <&touchkey_enable>; +        vdd-supply = <&pm8921_l29>; +        vcc-supply = <&pm8921_l29>; + +        linux,keycodes = ; +    }; +}; diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi index fd28401cebb5..c598fb324e7d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi @@ -223,7 +223,7 @@ i2c8-pins {              i2c10_default_state: i2c10-default-state {                  i2c10-pins { -                    pins = "gpio73", "gpio74"; +                    pins = "gpio71", "gpio72";                      function = "gsbi10";                      drive-strength = <8>;                      bias-disable; @@ -232,7 +232,7 @@ i2c10-pins {              i2c10_sleep_state: i2c10-sleep-state {                  i2c10-pins { -                    pins = "gpio73", "gpio74"; +                    pins = "gpio71", "gpio72";                      function = "gpio";                      drive-strength = <2>;                      bias-bus-hold; diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig index 29a1dea500f0..49baa91937ca 100644 --- a/arch/arm/configs/qcom_defconfig +++ b/arch/arm/configs/qcom_defconfig @@ -321,3 +321,4 @@ CONFIG_MAGIC_SYSRQ=y  CONFIG_DEBUG_FS=y  # CONFIG_SLUB_DEBUG is not set  # CONFIG_SCHED_DEBUG is not set +CONFIG_KEYBOARD_TM2_TOUCHKEY=m \ No newline at end of file