From: Christian Loehle <christian.loehle@arm.com>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <len.brown@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Ricardo Neri <ricardo.neri@intel.com>
Subject: Re: [PATCH 1/2] arch_topology: Relocate cpu_scale to topology.[h|c]
Date: Fri, 25 Apr 2025 17:31:01 +0100 [thread overview]
Message-ID: <7c583e2e-14b6-40e5-8e12-01584b817e4c@arm.com> (raw)
In-Reply-To: <20250419025504.9760-2-ricardo.neri-calderon@linux.intel.com>
On 4/19/25 03:55, Ricardo Neri wrote:
> arch_topology.c provides functionality to parse and scale CPU capacity. It
> also provides a corresponding sysfs interface. Some architectures parse
> and scale CPU capacity differently as per their own needs. On Intel
> processors, for instance, it is responsibility of the Intel P-state driver.
>
> Relocate the implementation of that interface to a common location in
> topology.c. Architectures can use the interface and populate it using their
> own mechanisms.
>
> An alternative approach would be to compile arch_topology.c even if not
> needed only to get this interface. This approach would create duplicated
> and conflicting functionality and data structures.
>
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Maybe an FYI for the non-x86 folks, this doesn't break anything on the
usual arm64 setup:
Tested-by: Christian Loehle <christian.loehle@arm.com>
next prev parent reply other threads:[~2025-04-25 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 2:55 [PATCH 0/2] topology/sysfs, cpufreq/intel_pstate: Populate cpu_capacity Ricardo Neri
2025-04-19 2:55 ` [PATCH 1/2] arch_topology: Relocate cpu_scale to topology.[h|c] Ricardo Neri
2025-04-25 16:31 ` Christian Loehle [this message]
2025-05-07 21:18 ` Ricardo Neri
2025-04-19 2:55 ` [PATCH 2/2] cpufreq: intel_pstate: Populate the cpu_capacity sysfs entries Ricardo Neri
2025-05-07 20:00 ` [PATCH 0/2] topology/sysfs, cpufreq/intel_pstate: Populate cpu_capacity Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c583e2e-14b6-40e5-8e12-01584b817e4c@arm.com \
--to=christian.loehle@arm.com \
--cc=dakr@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=ricardo.neri@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®