From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6150C4363A for ; Mon, 26 Oct 2020 13:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97A452467A for ; Mon, 26 Oct 2020 13:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1780107AbgJZNbV (ORCPT ); Mon, 26 Oct 2020 09:31:21 -0400 Received: from smtprelay0135.hostedemail.com ([216.40.44.135]:59740 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1780098AbgJZNbV (ORCPT ); Mon, 26 Oct 2020 09:31:21 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 07C8612C7; Mon, 26 Oct 2020 13:31:20 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: son43_0c10b2927273 X-Filterd-Recvd-Size: 2426 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Mon, 26 Oct 2020 13:31:18 +0000 (UTC) Message-ID: <7c592b6b4cc3bc4e629e35445fa76cf07b5482a6.camel@perches.com> Subject: Re: [PATCH 1/1] s390: correct __bootdata / __bootdata_preserved macros From: Joe Perches To: Vasily Gorbik , Michal Kubecek Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Date: Mon, 26 Oct 2020 06:31:17 -0700 In-Reply-To: References: <20201026104811.22ta4pby2chmz4pv@lion.mk-sys.cz> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-10-26 at 13:49 +0100, Vasily Gorbik wrote: > Currently s390 build is broken. > >   SECTCMP .boot.data > error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux > make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1 >   SECTCMP .boot.preserved.data > error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux > make[2]: *** [arch/s390/boot/section_cmp.boot.preserved.data] Error 1 > make[1]: *** [bzImage] Error 2 > > Commit 33def8498fdd ("treewide: Convert macro and uses of __section(foo) > to __section("foo")") converted all __section(foo) to __section("foo"). > This is wrong for __bootdata / __bootdata_preserved macros which want > variable names to be a part of intermediate section names .boot.data. name> and .boot.preserved.data.. Those sections are later > sorted by alignment + name and merged together into final .boot.data > / .boot.preserved.data sections. Those sections must be identical in > the decompressor and the decompressed kernel (that is checked during > the build). > > Fixes: 33def8498fdd ("treewide: Convert macro and uses of __section(foo) to __section("foo")") > Signed-off-by: Vasily Gorbik Apologies and thank you. I believed the robot had done these compilation tests.