From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E44C433DF for ; Mon, 25 May 2020 08:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02D7B207FB for ; Mon, 25 May 2020 08:38:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590395892; bh=Iu3Bf6K8xAknpcdpi+/p3IjPL1Y2521MLs3/DHEjTLU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=w6kkOmxJUu7oEzf07vlaFJdRed9UsLzLjy7CqIpU3+6JmSCF4VyzviaP/kS+TbYz2 sOqTJ0f9jrhCCODuM+F5mbvGWztfpXTQNoyD8eZeevc44cmpHERVe7Q+4nEHG+g3te dLVWVpRrTuQCbrN1WsgHKIHREVBtfm128Mgl6g3g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388827AbgEYIiL (ORCPT ); Mon, 25 May 2020 04:38:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:41500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387973AbgEYIiK (ORCPT ); Mon, 25 May 2020 04:38:10 -0400 Received: from [192.168.0.50] (89-70-52-201.dynamic.chello.pl [89.70.52.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79D292070A; Mon, 25 May 2020 08:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590395890; bh=Iu3Bf6K8xAknpcdpi+/p3IjPL1Y2521MLs3/DHEjTLU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Ivm7FSYUh2nqsjE+OblssRVQFhjQhZGa3VSt8396z3VYi0wiK1zj7mAPXIJMXcuR8 UVTL52rRVV9wpm1xhWmmPV9Ht4KgxcyKB4ybjIYrzTXalOCJHxFlZbTaASFYMiEwc6 2Hakkt6Vaz6YqU2RCoDO0ENXRZ8y8w9ZRqtFUa3o= Subject: Re: [PATCH] media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe To: Dinghao Liu , kjlu@umn.edu Cc: Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200524025903.17219-1-dinghao.liu@zju.edu.cn> From: Sylwester Nawrocki Message-ID: <7c5931a5-4355-be85-d61d-908afc8f7a19@kernel.org> Date: Mon, 25 May 2020 10:38:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200524025903.17219-1-dinghao.liu@zju.edu.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/24/20 04:59, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. For all error > paths after pm_runtime_get_sync(), things are the same. > > Signed-off-by: Dinghao Liu Reviewed-by: Sylwester Nawrocki