From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932559AbdJ0VyK (ORCPT ); Fri, 27 Oct 2017 17:54:10 -0400 Received: from mga06.intel.com ([134.134.136.31]:41881 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbdJ0VyH (ORCPT ); Fri, 27 Oct 2017 17:54:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,305,1505804400"; d="scan'208";a="166058217" Subject: Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow() To: SF Markus Elfring , Leon Romanovsky , Doug Ledford , linux-rdma@vger.kernel.org Cc: Hal Rosenstock , Sean Hefty , Yishai Hadas , Yuval Shaia , LKML , kernel-janitors@vger.kernel.org References: <0bcea3cf-91e3-01d5-8d80-34cd6b611fb1@users.sourceforge.net> <20171027193902.GJ16127@mtr-leonro.local> <5cc2ecf7-cc6e-76e0-c73b-08ce717fef83@users.sourceforge.net> From: Dennis Dalessandro Message-ID: <7c5a7827-209c-9bb7-5b77-ac62d3d54604@intel.com> Date: Fri, 27 Oct 2017 17:54:04 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5cc2ecf7-cc6e-76e0-c73b-08ce717fef83@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2017 4:53 PM, SF Markus Elfring wrote: >> This change adds nothing except code churn. > > I guess that the shown change possibility can reduce the object code size > for the affected function. > Do you care for such an detail? > > Regards, > Markus > You guess? Well perhaps you should find out for certain. Is it an appreciable impact? -Denny