From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C225FC25B48 for ; Thu, 26 Oct 2023 16:12:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231354AbjJZQM2 (ORCPT ); Thu, 26 Oct 2023 12:12:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230507AbjJZQM0 (ORCPT ); Thu, 26 Oct 2023 12:12:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F122893; Thu, 26 Oct 2023 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698336744; x=1729872744; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=NTn3zQpXQ4OY6HxUDLvEa4CHByRqTBVp52gG5dvy8+c=; b=Ky/c4f7CeXhuf+BhCPsnfWfkjl69cQLtbaWFRouj0KG0ZDrrZV8SQjjl YUc3haz9nSMpG6lu7n9p5PIvcti4f+HqotwyNr1/QQBW51vEoaDkdf9tN 1vv7+1smBTjz5FesULPSFToSBO6JwC1SPgMVBbTW88oJRt4JwRU6rAT3B fz/QtvEiSnlRpe+sdhpyG9ykcdndkWAV3tZzBQg3TTe/z1VnpKPx2Ehr5 5EL+JjOozQpy23vPLLMzJY5h1ZL6kcUyn296I2mQMLgNowbBgNkcVdupl 14VqfehnOBvWt4DQYiRCBXXt+zjdFvOhnypzAwDZzLZi+4TwV8MqD/B1B Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="366936418" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="366936418" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 09:09:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="555229" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.251.211.218]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 09:09:21 -0700 Message-ID: <7c5b626c-1de9-4c12-a781-e44985b4a797@intel.com> Date: Thu, 26 Oct 2023 19:09:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] perf tools: Add get_unaligned_leNN() Content-Language: en-US To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org References: <20231005190451.175568-1-adrian.hunter@intel.com> <20231005190451.175568-2-adrian.hunter@intel.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/23 16:44, Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 05, 2023 at 04:38:05PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Oct 05, 2023 at 10:04:47PM +0300, Adrian Hunter escreveu: >>> Add get_unaligned_le16(), get_unaligned_le32 and get_unaligned_le64, same >>> as include/asm-generic/unaligned.h. >>> >>> Use diagnostic pragmas to ignore -Wpacked used by perf build. >> >> Can we get the tools copy of include/asm-generic/unaligned.h closer and >> have it in check-headers.sh? > > And this is not building when cross building to mips, mips64 and mipsel > on debian:experimental: > > In file included from util/intel-pt-decoder/intel-pt-pkt-decoder.c:10: > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le16': > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:29: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] So I guess another diagnostic pragma is needed, perhaps the following works? #pragma GCC diagnostic ignored "-Wattributes" > 13 | const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ > | ^ > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:27:28: note: in expansion of macro '__get_unaligned_t' > 27 | return le16_to_cpu(__get_unaligned_t(__le16, p)); > | ^~~~~~~~~~~~~~~~~ > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le32': > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:29: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] > 13 | const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ > | ^ > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:32:28: note: in expansion of macro '__get_unaligned_t' > 32 | return le32_to_cpu(__get_unaligned_t(__le32, p)); > | ^~~~~~~~~~~~~~~~~ > > > Ditto for some other distros when cross building on ubuntu:18.04 > > MKDIR /tmp/build/perf/util/perf-regs-arch/ > In file included from /usr/sparc64-linux-gnu/include/bits/byteswap.h:34:0, > from /usr/sparc64-linux-gnu/include/endian.h:60, > from util/intel-pt-decoder/intel-pt-pkt-decoder.c:9: > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h: In function 'get_unaligned_le16': > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:13:22: error: packed attribute causes inefficient alignment for 'x' [-Werror=attributes] > const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ > ^ > /git/perf-6.6.0-rc1/tools/include/asm-generic/unaligned.h:27:21: note: in expansion of macro '__get_unaligned_t' > return le16_to_cpu(__get_unaligned_t(__le16, p)); > ^~~~~~~~~~~~~~~~~ > > 37 14.17 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > 38 13.56 ubuntu:18.04-x-arm64 : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) > 42 12.70 ubuntu:18.04-x-riscv64 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) > 44 13.95 ubuntu:18.04-x-sh4 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) > 45 13.08 ubuntu:18.04-x-sparc64 : FAIL gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04) > >> - Arnaldo >> >>> Signed-off-by: Adrian Hunter >>> --- >>> tools/include/asm-generic/unaligned.h | 20 ++++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/tools/include/asm-generic/unaligned.h b/tools/include/asm-generic/unaligned.h >>> index 47387c607035..9140bb4e16c6 100644 >>> --- a/tools/include/asm-generic/unaligned.h >>> +++ b/tools/include/asm-generic/unaligned.h >>> @@ -6,6 +6,9 @@ >>> #ifndef __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H >>> #define __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H >>> >>> +#pragma GCC diagnostic push >>> +#pragma GCC diagnostic ignored "-Wpacked" >>> + >>> #define __get_unaligned_t(type, ptr) ({ \ >>> const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr); \ >>> __pptr->x; \ >>> @@ -19,5 +22,22 @@ >>> #define get_unaligned(ptr) __get_unaligned_t(typeof(*(ptr)), (ptr)) >>> #define put_unaligned(val, ptr) __put_unaligned_t(typeof(*(ptr)), (val), (ptr)) >>> >>> +static inline u16 get_unaligned_le16(const void *p) >>> +{ >>> + return le16_to_cpu(__get_unaligned_t(__le16, p)); >>> +} >>> + >>> +static inline u32 get_unaligned_le32(const void *p) >>> +{ >>> + return le32_to_cpu(__get_unaligned_t(__le32, p)); >>> +} >>> + >>> +static inline u64 get_unaligned_le64(const void *p) >>> +{ >>> + return le64_to_cpu(__get_unaligned_t(__le64, p)); >>> +} >>> + >>> +#pragma GCC diagnostic pop >>> + >>> #endif /* __TOOLS_LINUX_ASM_GENERIC_UNALIGNED_H */ >>> >>> -- >>> 2.34.1 >>> >> >> -- >> >> - Arnaldo >