mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Leo Yan <leo.yan@linaro.org>, Huacai Chen <chenhuacai@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, loongarch@lists.linux.dev,
	linux-kernel@vger.kernel.org, loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH] perf symbol: Add LoongArch case in get_plt_sizes()
Date: Tue, 23 May 2023 17:02:32 +0800	[thread overview]
Message-ID: <7c5ca655-dd68-b67a-0674-de624bf10752@loongson.cn> (raw)
In-Reply-To: <20230523073007.GB1969788@leoy-yangtze.lan>



On 05/23/2023 03:30 PM, Leo Yan wrote:
> On Tue, May 23, 2023 at 09:47:19AM +0800, Huacai Chen wrote:
>
> [...]
>
>>>> I'm very sorry that this patch breaks cross-build. We need some
>>>> additional modification.
>>>>
>>>> diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
>>>> index 5d409c26a22e..b3dbf6ca99a7 100644
>>>> --- a/tools/perf/util/symbol-elf.c
>>>> +++ b/tools/perf/util/symbol-elf.c
>>>> @@ -35,6 +35,10 @@
>>>>  #define EM_AARCH64     183  /* ARM 64 bit */
>>>>  #endif
>>>>
>>>> +#ifndef EM_LOONGARCH
>>>> +#define EM_LOONGARCH   258
>>>> +#endif
>>>> +
>
> I confirmed that we must apply this change, otherwise, it will
> introduce perf building failure on Ubuntu 22.04 (jammy) with my Arm64
> machine.
>
> Sorry I didn't detect the building failure when reviewed this patch!
>

Sorry for that, EM_LOONGARCH was added in binutils in 2020 [1],
and then it was added in glibc in 2022 [2], so it may be not
exist on some systems.

For now, I do not find the related commit of this patch in any
branch of acme/linux.git, so it is better to send v2 to avoid
the build error, I will do it as soon as possible.

[1] 
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=4cf2ad720078
[2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=2d83247d90c9

Thanks,
Tiezhu


      reply	other threads:[~2023-05-23  9:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  6:55 Tiezhu Yang
2023-05-18  2:11 ` Huacai Chen
2023-05-18  3:06   ` Leo Yan
2023-05-18  3:12     ` Huacai Chen
2023-05-18  3:21       ` Leo Yan
2023-05-18  3:57         ` Huacai Chen
2023-05-18  4:05           ` Leo Yan
2023-05-18 12:16             ` Arnaldo Carvalho de Melo
2023-05-22  3:50               ` Huacai Chen
2023-05-22  7:58                 ` Tiezhu Yang
2023-05-23  1:47                   ` Huacai Chen
2023-05-23  7:30                     ` Leo Yan
2023-05-23  9:02                       ` Tiezhu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c5ca655-dd68-b67a-0674-de624bf10752@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=chenhuacai@kernel.org \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®