From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA66DC4332F for ; Tue, 15 Nov 2022 16:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238505AbiKOQeP (ORCPT ); Tue, 15 Nov 2022 11:34:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbiKOQeM (ORCPT ); Tue, 15 Nov 2022 11:34:12 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB7B8DEA9; Tue, 15 Nov 2022 08:34:11 -0800 (PST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AFFmW5O018678; Tue, 15 Nov 2022 16:34:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Wm1+y7h+8+ad0XSzXIUKyjqonxjk1+rSNFMyO+x8w4U=; b=bBZuolwy/xCzKq1kTvZV+3YnOCU/0VKQDvPnYs5m0qvDG58G673VFZrdfhQA78vwcJpj V0WCZKi/Xg5eOD+36TLDVWTsc3fRwnsq6UJHpg+feXEi7NC9m5qu9CTxW97SmOQeWRp3 Va7SOfZ92GjcvGH+POg//NP5mGGs35gLkjwTeglPzUzHQX95atZicS7eeuuEc3nnXjbr 3nJFGu7+ddVEcfz0X7Lrk+uQkZ6ZdUwieJA30zHgZRa9WTj8HY7XF9iJ38q5mBpnOo/d UeS3l4yUW2Chq8fi7va7oX6SNN1Alxt7LOCHPYD3yMdod9z4vT46L04FoVVcjo2gRTmh eQ== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kvdr299fm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 16:34:07 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AFGKdQs012832; Tue, 15 Nov 2022 16:34:05 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06ams.nl.ibm.com with ESMTP id 3kt2rjcms9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Nov 2022 16:34:05 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AFGY1ih62652676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Nov 2022 16:34:01 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC6DB5204F; Tue, 15 Nov 2022 16:34:01 +0000 (GMT) Received: from [9.171.35.73] (unknown [9.171.35.73]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5E4815204E; Tue, 15 Nov 2022 16:34:01 +0000 (GMT) Message-ID: <7c5e7e69-6b94-4e74-ad80-b90d27047dfc@linux.ibm.com> Date: Tue, 15 Nov 2022 17:34:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2] perf list: Add PMU pai_ext event description for IBM z16 Content-Language: en-US To: Arnaldo Carvalho de Melo Cc: Andreas Krebbel , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, svens@linux.ibm.com, gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com, Ingo Molnar References: <20221111135402.858623-1-tmricht@linux.ibm.com> From: Thomas Richter Organization: IBM In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 6KbBI5OhvIiLkHJBWmAJqpV6wFvKbsOY X-Proofpoint-ORIG-GUID: 6KbBI5OhvIiLkHJBWmAJqpV6wFvKbsOY Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-15_08,2022-11-15_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211150111 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/22 14:10, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 15, 2022 at 09:58:22AM +0100, Thomas Richter escreveu: >> On 11/14/22 17:06, Arnaldo Carvalho de Melo wrote: >>> Em Fri, Nov 11, 2022 at 02:54:02PM +0100, Thomas Richter escreveu: >>>> Add the event description for the IBM z16 pai_ext PMU released with >>>> commit c432fefe8e62 ("s390/pai: Add support for PAI Extension 1 NNPA counters") > >>>> The document SA22-7832-13 "z/Architecture Principles of Operation", >>>> published May, 2022, contains the description of the Processor >>>> Activity Instrumentation Facility and the NNPA counter set., See >>>> Pages 5-113 to 5-116. > >>>> Signed-off-by: Thomas Richter > >>>> --- /dev/null >>>> +++ b/tools/perf/pmu-events/arch/s390/cf_z16/pai_ext.json >>>> @@ -0,0 +1,198 @@ >>>> +[ >>>> + { >>>> + "Unit": "PAI-EXT", >>>> + "EventCode": "6144", >>>> + "EventName": "NNPA_ALL", >>>> + "BriefDescription": "NNPA ALL", >>>> + "PublicDescription": "Sum of all non zero NNPA counters" >>>> + }, > >>> Since the Brief description mentions NNPA, shouldn't the Public >>> Description expand on this "NNPA" acronym?, something like: > >>> Oops, can't expand on that since there isn't a link to that SA22-7832-13 >>> document. > >>> Googling for it... > >>> https://www-40.ibm.com/servers/resourcelink/svc03100.nsf/pages/zResourceLinkUrl?OpenDocument&url=http://www.ibm.com/servers/resourcelink/lib03010.nsf/0/B9DE5F05A9D57819852571C500428F9A/$file/SA22-7832-13.pdf > >>> Ok, requires registration. > >>> I wonder what is the value of these descriptions then :-\ > >>> I miss Ingo jumping into these discussions :-) > >> I added Andreas Krebbel to the discussion, he knows more than I on this counters. > >> NNPA stands for Neural Networks Processing Assist. This is a new feature in >> the IBM z16. Here is a quote from Document SG2489-51 IBM z16 (3931) Technical Guide: > >> >> "The new IBM z16 microprocessor chip, also called the IBM Telum processor, integrates a >> new AI accelerator. This innovation brings incredible value to applications and workloads that >> are running on IBM Z platform. >> Customers can benefit from the integrated AI accelerator by adding AI operations that are >> used to perform fraud prevention and fraud detection, customer behavior predictions, and >> supply chain operations. All of these operations are done in real time and fully integrated in >> transactional workloads. As a result, valuable insights are gained from their data instantly. >> >> ... >> The AI accelerator is driven by the new Neural Networks Processing Assist (NNPA) >> instruction. >> NNPA is a new nonprivileged Complex Instruction Set Computer (CISC) memory-to-memory >> instruction that operates on tensor objects that are in user program’s memory. AI functions >> and macros are abstracted by NNPA." >> >> >> This intension of this patch is to give a small hint on what these NNPA counters are >> supposed to count and operate on. A full explanation is given in the document >> SA22-7832-13 "z/Architecture Principles of Operation", Chapter 26, pp 26-1 to 26-115. >> >> If you think this small description is not worth it, then we can drop the patch. > > So perhaps: > > + { > + "Unit": "PAI-EXT", > + "EventCode": "6144", > + "EventName": "NNPA_ALL", > + "BriefDescription": "NNPA ALL", > + "PublicDescription": "Sum of all non zero NNPA (Neural Networks Processing Assist) counters" > + }, > > ? > > - Arnaldo Ahhh, now I get it. Yes I will provide a patch with the first mention of NNPA have the abbreviation explained, as you pointed out. Thanks. -- Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany -- Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294