From: Jacob Keller <jacob.e.keller@intel.com>
To: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Ariel Elior <aelior@marvell.com>,
Manish Chopra <manishc@marvell.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Tony Nguyen" <anthony.l.nguyen@intel.com>
Cc: <netdev@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 5/8] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities
Date: Wed, 14 Feb 2024 16:00:10 -0800 [thread overview]
Message-ID: <7c5fb62b-1414-4547-bbb2-93d0ca866c89@intel.com> (raw)
In-Reply-To: <20240214-keee-u32-cleanup-v2-5-4ac534b83d66@lunn.ch>
On 2/14/2024 3:13 PM, Andrew Lunn wrote:
> Energy Efficient Ethernet should always be negotiated with the link
> peer. Don't include SUPPORTED_Autoneg in the results of get_eee() for
> supported, advertised or lp_advertised, since it is
> assumed. Additionally, ethtool(1) ignores the set bit, and no other
> driver sets this.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
I checked the git blame for both igc, and i40e both in-tree and in our
out-of-tree drivers which have this code. There is no explanation given
and it was just part of the original commits for implementing EEE
support for these two drivers.
I can't find any trace of a justification for this.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-02-15 0:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 23:13 [PATCH net-next v2 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 1/8] net: usb: r8152: Use linkmode helpers for EEE Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 2/8] net: usb: ax88179_178a: " Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 3/8] net: qlogic: qede: " Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 4/8] net: ethernet: ixgbe: Convert EEE to use linkmodes Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 5/8] net: intel: i40e/igc: Remove setting Autoneg in EEE capabilities Andrew Lunn
2024-02-15 0:00 ` Jacob Keller [this message]
2024-02-14 23:13 ` [PATCH net-next v2 6/8] net: intel: e1000e: Use linkmode helpers for EEE Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 7/8] net: intel: igb: " Andrew Lunn
2024-02-14 23:13 ` [PATCH net-next v2 8/8] net: intel: igc: " Andrew Lunn
2024-02-15 7:00 ` [Intel-wired-lan] [PATCH net-next v2 0/8] drivers: net: Convert EEE handling to use linkmode bitmaps Paul Menzel
2024-02-16 0:15 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c5fb62b-1414-4547-bbb2-93d0ca866c89@intel.com \
--to=jacob.e.keller@intel.com \
--cc=aelior@marvell.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®