From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A65DBC28D13 for ; Thu, 25 Aug 2022 05:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232648AbiHYF1s (ORCPT ); Thu, 25 Aug 2022 01:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232090AbiHYF1q (ORCPT ); Thu, 25 Aug 2022 01:27:46 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC8DF9E6BD; Wed, 24 Aug 2022 22:27:45 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27P3AB66007269; Thu, 25 Aug 2022 05:27:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=u2Gkmj5V4DLfOx9YRRaR1k3C2BrSI3oo9A9oeQegpts=; b=AkpqIKrBCM1op3+i0RNVyUyfI1A9WkOoyIKJIOB1ZIQis9VsBmmaEVPKl493W0lAIZ8X Jn7hXGIxzoPk2YEdrX5beLL3pc+xYy9z+etvI0L/2mLh25RZhnVMGaat6N0XSNbvev9h nyjOeEnXgJB/QAdHr3BFaxkznrUfZz0TnhEvgl1Ph9lCyuXHXvkb8eD7s5eLxhbxuo5J pKNzI8WeKGHUuG4FDxq84hE/Ce8G3+OUeG6T3tYkF2a4/9mS+Uoa5QdG7NS5bVLK1bc3 v6NOnJzPy2EieVLP6rWkb13GTsWbIBmpV4Ng67/CanvHitsQmhy/gaB1cpw/nopXTftM Ug== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3j5xcugkc3-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Aug 2022 05:27:34 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27P5DehQ029387 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Aug 2022 05:13:40 GMT Received: from [10.79.43.230] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 24 Aug 2022 22:13:37 -0700 Subject: Re: [PATCH v8 3/3] arm64: dts: qcom: Add LTE SKUs for sc7280-villager family To: Doug Anderson CC: Jimmy Chen , LKML , Andy Gross , Konrad Dybcio , Rob Herring , Bjorn Andersson , Alan Huang , Krzysztof Kozlowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm References: <20220726094549.263899-1-jinghung.chen3@hotmail.com> <93bf8a59-34e3-e461-35c9-4f0f344dee32@quicinc.com> From: Sibi Sankar Message-ID: <7c60fcfa-9df8-dcb3-e5d8-f24b520c55d2@quicinc.com> Date: Thu, 25 Aug 2022 10:43:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: lCqq5dObxE7uDtAvtxrkCnUc_sHziyjH X-Proofpoint-ORIG-GUID: lCqq5dObxE7uDtAvtxrkCnUc_sHziyjH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-25_03,2022-08-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208250018 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/24/22 8:55 PM, Doug Anderson wrote: > Hi, > > On Wed, Aug 24, 2022 at 3:11 AM Sibi Sankar wrote: >> >> Hey Jimmy, >> >> Thanks for the patch. >> >> On 7/26/22 3:15 PM, Jimmy Chen wrote: >>> This adds LTE skus for villager device tree files. >>> >>> Signed-off-by: Jimmy Chen >>> Reviewed-by: Douglas Anderson >>> --- >>> >>> (no changes since v6) >>> >>> Changes in v6: >>> - Remove v5 accidentally added sc7280-herobrine-herobrine-r1-lte.dts >>> >>> Changes in v5: >>> - Reorder '.dtb' in Makefile >>> - Put the "interconnects" line back >>> >>> Changes in v4: >>> - Reorder 'status' last >>> >>> arch/arm64/boot/dts/qcom/Makefile | 2 ++ >>> .../boot/dts/qcom/sc7280-chrome-common.dtsi | 11 ----------- >>> .../boot/dts/qcom/sc7280-herobrine-crd.dts | 1 + >>> .../dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 + >>> .../boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 17 +++++++++++++++++ >>> .../qcom/sc7280-herobrine-villager-r0-lte.dts | 14 ++++++++++++++ >>> .../qcom/sc7280-herobrine-villager-r1-lte.dts | 14 ++++++++++++++ >>> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 1 + >>> 8 files changed, 50 insertions(+), 11 deletions(-) >>> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0-lte.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index 2c1605e00d349..24eacbf330880 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -103,7 +103,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0-lte.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1-lte.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-idp2.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7280-crd-r3.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi >>> index cfe2741456a1a..25f31c81b2b74 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-chrome-common.dtsi >>> @@ -83,17 +83,6 @@ spi_flash: flash@0 { >>> }; >>> }; >>> >>> -/* Modem setup is different on Chrome setups than typical Qualcomm setup */ >>> -&remoteproc_mpss { >>> - status = "okay"; >>> - compatible = "qcom,sc7280-mss-pil"; >>> - iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; >>> - interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; >>> - memory-region = <&mba_mem>, <&mpss_mem>; >>> - firmware-name = "qcom/sc7280-herobrine/modem/mba.mbn", >>> - "qcom/sc7280-herobrine/modem/qdsp6sw.mbn"; >>> -}; >>> - >>> &remoteproc_wpss { >>> status = "okay"; >>> firmware-name = "ath11k/WCN6750/hw1.0/wpss.mdt"; >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts >>> index e9ca6c5d24a16..921eccfec39ae 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts >>> @@ -9,6 +9,7 @@ >>> >>> #include "sc7280-herobrine.dtsi" >>> #include "sc7280-herobrine-audio-wcd9385.dtsi" >>> +#include "sc7280-herobrine-lte-sku.dtsi" >>> >>> / { >>> model = "Qualcomm Technologies, Inc. sc7280 CRD platform (rev5+)"; >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts >>> index c1647a85a371a..c1a6719687252 100644 >>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts >>> @@ -8,6 +8,7 @@ >>> /dts-v1/; >>> >>> #include "sc7280-herobrine.dtsi" >>> +#include "sc7280-herobrine-lte-sku.dtsi" >>> >>> / { >>> model = "Google Herobrine (rev1+)"; >>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> new file mode 100644 >>> index 0000000000000..a92eeccd2b2a9 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi >>> @@ -0,0 +1,17 @@ >>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>> +/* >>> + * Google Herobrine dts fragment for LTE SKUs >>> + * >>> + * Copyright 2022 Google LLC. >>> + */ >>> +/* Modem setup is different on Chrome setups than typical Qualcomm setup */ >>> + >>> +&remoteproc_mpss { >>> + compatible = "qcom,sc7280-mss-pil"; >>> + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; >>> + interconnects = <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; >>> + memory-region = <&mba_mem>, <&mpss_mem>; >>> + firmware-name = "qcom/sc7280-herobrine/modem/mba.mbn", >>> + "qcom/sc7280-herobrine/modem/qdsp6sw.mbn"; >>> + status = "okay"; >>> +}; >> >> We shoud probably move the mpss_mem, mba_mem and rmtfs_mem here as >> well, that way we save an additional ~255M. > > That sounds like a great idea. I wonder if it would be possible for > Bjorn to land Jimmy's patches as-is and perhaps you could send a > follow-up patch? ack Reviewed-by: Sibi Sankar > > -Doug >