From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=213.97.179.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792846686; b=blPgpLW63rFtH4WSGI9qNOoK6cexbjnSxxeDqxzaW+lHRxeFoQzfKvhRPEzfmMIfE6pL BZg4MslDxkUf8vT6OC9fITlsXzTP32jxjBUkjtP3cVmMqqStWaQYHmswSwb2kuEjl5fay 7xN3QGe7dhx1+semHgnedxWZ3+QWrKXoNHlNTynT2VBiPz6bDh9zvDNEHc1cRO2K6HYkh dQmL3Zwb0NKtGH+sTz/K074FPAsNvC0Ut1itA0wO+Kb/zV0fo+gS0Rq5sanitli02+anu jUjKHpRurDp1PVZDay6srLpoYkVnlZpiXNuR7R0PMdT8l6DxKNRodiYMAOzyoSi9TbA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792846686; h=DMARC-Filter:DKIM-Signature:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:From:Content-Language:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=yXDqyeb3hzfE8o2jGQs5QyRva9K4MrHRBvif9lBWajU=; b=waSDS46s6LtFWn5mFVSurQNGMJCLbHCInhmQLkJ/OW8wKXe7vjwP4uvM1JAaEXp1RM6m ZKs/WWYVwA4A9gIzpMBkvUQ/YwjS/w3uPfzkcl6TO5KkQwVQLu81oKGDf1b/rJ76RZT5v pMNCkUZhDPmHKLtPVK1Zuy+pMG7EyUSxvM92BqsEAVk6vu2XMLeV73YNtqxg2DMBfy9o7 /whxa81rDfC5veTQM152S3fUKETSQZ33Dj5v5NVrt1ZVET3mTMZzHotlwClVyzA53tjhA 44k7G8h228+pj/84yuJR9yYiBtreheHhyWKH2cn/ilcWATWwkM4LxUGuUlEBVcHzq5w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256 header.s=20170329 header.b=YpqeCJOH; arc=none smtp.remote-ip=213.97.179.56 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B21606A31A for ; Sat, 24 Oct 2026 12:58:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 59B21606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=igalia.com header.i=@igalia.com header.a=rsa-sha256 header.s=20170329 header.b=YpqeCJOH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:From:Cc:To:Subject: MIME-Version:Date:Message-ID:From:Reply-To; bh=yXDqyeb3hzfE8o2jGQs5QyRva9K4MrHRBvif9lBWajU=; b=YpqeCJOH2AUcs/eSJM/5cVq6cv HLDPWceRCfOEpW3C0S0j2/+h0Uw/rgZ9J+P5ddGRSAchlCQAJva5JNLt0UrjsFlpu2LfxgvVg4w/Z BMCMcZOViVrGBltAAkHQ3qWVGzgVvwvj5+LhToZPNvB+iqojytcMuJDRTzFmuhoHWcg0U9kYK6h3D DbWU+Sp4YdrWCCjByVCECCEwxzegjPfKpZtO7xi1oPZ/mQ9AFowhyDfCvu/zpHlpk8S8EISRrC309 bl6QVk24L/WxTysFzRNv64pkgp6jFGDBehcTUjOSamJUhI0DLEx86vl+ViYzlzouOuIHBNePPl8YX e9I19vnw==; Received: from [179.105.94.163] (helo=[192.168.0.2]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1xKbJo-008sMg-Tv; Sat, 24 Oct 2026 14:57:53 +0200 Message-ID: <7c634e77-92b6-456e-a186-c1e2442e4790@igalia.com> Date: Sat, 24 Oct 2026 09:57:47 -0300 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] drm/vc4: dpi: stop using deprecated drmm_of_get_bridge() To: Luca Ceresoli , Maxime Ripard , Dave Stevenson , Raspberry Pi Kernel Maintenance , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Paul Cercueil , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20261013-drm-fix-of_get_bridge-build-regression-v3-0-0b4c0b65be82@bootlin.com> <20261013-drm-fix-of_get_bridge-build-regression-v3-1-0b4c0b65be82@bootlin.com> From: =?UTF-8?Q?Ma=C3=ADra_Canal?= Content-Language: en-US Autocrypt: addr=mcanal@igalia.com; keydata= xsBNBGcCwywBCADgTji02Sv9zjHo26LXKdCaumcSWglfnJ93rwOCNkHfPIBll85LL9G0J7H8 /PmEL9y0LPo9/B3fhIpbD8VhSy9Sqz8qVl1oeqSe/rh3M+GceZbFUPpMSk5pNY9wr5raZ63d gJc1cs8XBhuj1EzeE8qbP6JAmsL+NMEmtkkNPfjhX14yqzHDVSqmAFEsh4Vmw6oaTMXvwQ40 SkFjtl3sr20y07cJMDe++tFet2fsfKqQNxwiGBZJsjEMO2T+mW7DuV2pKHr9aifWjABY5EPw G7qbrh+hXgfT+njAVg5+BcLz7w9Ju/7iwDMiIY1hx64Ogrpwykj9bXav35GKobicCAwHABEB AAHNIE1hw61yYSBDYW5hbCA8bWNhbmFsQGlnYWxpYS5jb20+wsCRBBMBCAA7FiEE+ORdfQEW dwcppnfRP/MOinaI+qoFAmcCwywCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQ P/MOinaI+qoUBQgAqz2gzUP7K3EBI24+a5FwFlruQGtim85GAJZXToBtzsfGLLVUSCL3aF/5 O335Bh6ViSBgxmowIwVJlS/e+L95CkTGzIIMHgyUZfNefR2L3aZA6cgc9z8cfow62Wu8eXnq GM/+WWvrFQb/dBKKuohfBlpThqDWXxhozazCcJYYHradIuOM8zyMtCLDYwPW7Vqmewa+w994 7Lo4CgOhUXVI2jJSBq3sgHEPxiUBOGxvOt1YBg7H9C37BeZYZxFmU8vh7fbOsvhx7Aqu5xV7 FG+1ZMfDkv+PixCuGtR5yPPaqU2XdjDC/9mlRWWQTPzg74RLEw5sz/tIHQPPm6ROCACFls7A TQRnAsMsAQgAxTU8dnqzK6vgODTCW2A6SAzcvKztxae4YjRwN1SuGhJR2isJgQHoOH6oCItW Xc1CGAWnci6doh1DJvbbB7uvkQlbeNxeIz0OzHSiB+pb1ssuT31Hz6QZFbX4q+crregPIhr+ 0xeDi6Mtu+paYprI7USGFFjDUvJUf36kK0yuF2XUOBlF0beCQ7Jhc+UoI9Akmvl4sHUrZJzX LMeajARnSBXTcig6h6/NFVkr1mi1uuZfIRNCkxCE8QRYebZLSWxBVr3h7dtOUkq2CzL2kRCK T2rKkmYrvBJTqSvfK3Ba7QrDg3szEe+fENpL3gHtH6h/XQF92EOulm5S5o0I+ceREwARAQAB wsB2BBgBCAAgFiEE+ORdfQEWdwcppnfRP/MOinaI+qoFAmcCwywCGwwACgkQP/MOinaI+qpI zQf+NAcNDBXWHGA3lgvYvOU31+ik9bb30xZ7IqK9MIi6TpZqL7cxNwZ+FAK2GbUWhy+/gPkX it2gCAJsjo/QEKJi7Zh8IgHN+jfim942QZOkU+p/YEcvqBvXa0zqW0sYfyAxkrf/OZfTnNNE Tr+uBKNaQGO2vkn5AX5l8zMl9LCH3/Ieaboni35qEhoD/aM0Kpf93PhCvJGbD4n1DnRhrxm1 uEdQ6HUjWghEjC+Jh9xUvJco2tUTepw4OwuPxOvtuPTUa1kgixYyG1Jck/67reJzMigeuYFt raV3P8t/6cmtawVjurhnCDuURyhUrjpRhgFp+lW8OGr6pepHol/WFIOQEg== In-Reply-To: <20261013-drm-fix-of_get_bridge-build-regression-v3-1-0b4c0b65be82@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 13/10/26 12:23, Luca Ceresoli wrote: > drmm_of_get_bridge() is deprecated, switch to > of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() returns > a refcounted bridge, ensure it is put. > > drm_panel.h becomes unused, drop the include. > > Also remove a comment that is now obvious: now panels are just bridges. > > Signed-off-by: Luca Ceresoli Reviewed-by: Maíra Canal Best regards, - Maíra > > --- > > Changes in v3: > - re-add and update comment > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index 53f36626a50d..feefefcf3ad7 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -279,16 +278,13 @@ static const struct of_device_id vc4_dpi_dt_match[] = { > {} > }; > > -/* Sets up the next link in the display chain, whether it's a panel or > - * a bridge. > - */ > +/* Sets up the next link in the display chain */ > static int vc4_dpi_init_bridge(struct vc4_dpi *dpi) > { > - struct drm_device *drm = dpi->encoder.base.dev; > struct device *dev = &dpi->pdev->dev; > - struct drm_bridge *bridge; > > - bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0); > + struct drm_bridge *bridge __free(drm_bridge_put) = > + of_drm_get_bridge_by_endpoint(dev->of_node, 0, 0); > if (IS_ERR(bridge)) { > /* If nothing was connected in the DT, that's not an > * error. >