From: Hal Feng <hal.feng@starfivetech.com>
To: Andreas Schwab <schwab@suse.de>
Cc: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Conor Dooley <conor@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Jianlong Huang <jianlong.huang@starfivetech.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/5] pinctrl: starfive: Add StarFive JH7110 sys controller driver
Date: Fri, 3 Feb 2023 15:04:46 +0800 [thread overview]
Message-ID: <7c6583eb-2c03-a584-1faf-8cbd44674175@starfivetech.com> (raw)
In-Reply-To: <mvm4js6zthr.fsf@suse.de>
On Tue, 31 Jan 2023 15:08:48 +0100, Andreas Schwab wrote:
> On Dez 20 2022, Hal Feng wrote:
>
>> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
>> new file mode 100644
>> index 000000000000..85df9d0ae1de
>> --- /dev/null
>> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c
>> @@ -0,0 +1,979 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Pinctrl / GPIO driver for StarFive JH7110 SoC
>> + *
>> + * Copyright (C) 2022 Emil Renner Berthing <kernel@esmil.dk>
>> + * Copyright (C) 2022 StarFive Technology Co., Ltd.
>> + */
>> +
>> +#include <linux/bits.h>
>> +#include <linux/clk.h>
>> +#include <linux/gpio/driver.h>
>> +#include <linux/io.h>
>> +#include <linux/mod_devicetable.h>
>> +#include <linux/module.h>
>> +#include <linux/mutex.h>
>> +#include <linux/of.h>
>> +#include <linux/of_device.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/reset.h>
>> +#include <linux/spinlock.h>
>> +
>> +#include <linux/pinctrl/pinctrl.h>
>> +#include <linux/pinctrl/pinmux.h>
>> +
>> +#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
>> +
>> +#include "../core.h"
>> +#include "../pinctrl-utils.h"
>> +#include "../pinmux.h"
>> +#include "../pinconf.h"
>> +#include "pinctrl-starfive-jh7110.h"
>
> This misses a couple of headers, see commit 042b93c9b666.
>
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c: In function 'jh7110_pin_dbg_show':
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:100:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
> 100 | seq_printf(s, "%s", dev_name(pctldev->dev));
> | ^~~~~~~~~~
> | bstr_printf
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c: At top level:
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:538:21: error: variable 'jh7110_pinconf_ops' has initializer but incomplete type
> 538 | static const struct pinconf_ops jh7110_pinconf_ops = {
> | ^~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:539:10: error: 'const struct pinconf_ops' has no member named 'pin_config_get'
> 539 | .pin_config_get = jh7110_pinconf_get,
> | ^~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:539:35: warning: excess elements in struct initializer
> 539 | .pin_config_get = jh7110_pinconf_get,
> | ^~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:539:35: note: (near initialization for 'jh7110_pinconf_ops')
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:540:10: error: 'const struct pinconf_ops' has no member named 'pin_config_group_get'
> 540 | .pin_config_group_get = jh7110_pinconf_group_get,
> | ^~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:540:35: warning: excess elements in struct initializer
> 540 | .pin_config_group_get = jh7110_pinconf_group_get,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:540:35: note: (near initialization for 'jh7110_pinconf_ops')
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:541:10: error: 'const struct pinconf_ops' has no member named 'pin_config_group_set'
> 541 | .pin_config_group_set = jh7110_pinconf_group_set,
> | ^~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:541:35: warning: excess elements in struct initializer
> 541 | .pin_config_group_set = jh7110_pinconf_group_set,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:541:35: note: (near initialization for 'jh7110_pinconf_ops')
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:542:10: error: 'const struct pinconf_ops' has no member named 'pin_config_dbg_show'
> 542 | .pin_config_dbg_show = jh7110_pinconf_dbg_show,
> | ^~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:542:35: warning: excess elements in struct initializer
> 542 | .pin_config_dbg_show = jh7110_pinconf_dbg_show,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:542:35: note: (near initialization for 'jh7110_pinconf_ops')
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:543:10: error: 'const struct pinconf_ops' has no member named 'is_generic'
> 543 | .is_generic = true,
> | ^~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:543:35: warning: excess elements in struct initializer
> 543 | .is_generic = true,
> | ^~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:543:35: note: (near initialization for 'jh7110_pinconf_ops')
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c: In function 'jh7110_gpio_request':
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:548:16: error: implicit declaration of function 'pinctrl_gpio_request' [-Werror=implicit-function-declaration]
> 548 | return pinctrl_gpio_request(gc->base + gpio);
> | ^~~~~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c: In function 'jh7110_gpio_free':
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:553:9: error: implicit declaration of function 'pinctrl_gpio_free' [-Werror=implicit-function-declaration]
> 553 | pinctrl_gpio_free(gc->base + gpio);
> | ^~~~~~~~~~~~~~~~~
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c: At top level:
> ../drivers/pinctrl/starfive/pinctrl-starfive-jh7110.c:538:33: error: storage size of 'jh7110_pinconf_ops' isn't known
> 538 | static const struct pinconf_ops jh7110_pinconf_ops = {
> | ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[4]: *** [../scripts/Makefile.build:253: drivers/pinctrl/starfive/pinctrl-starfive-jh7110.o] Error 1
Will add the missing headers. Thanks for your feedback.
Best regards,
Hal
next prev parent reply other threads:[~2023-02-03 7:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 0:55 [PATCH v3 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC Hal Feng
2022-12-20 0:55 ` [PATCH v3 1/5] riscv: dts: starfive: Add StarFive JH7110 pin function definitions Hal Feng
2022-12-20 0:55 ` [PATCH v3 2/5] dt-bindings: pinctrl: Add StarFive JH7110 sys pinctrl Hal Feng
2022-12-20 20:19 ` Rob Herring
2023-02-03 6:43 ` Hal Feng
2022-12-20 0:55 ` [PATCH v3 3/5] dt-bindings: pinctrl: Add StarFive JH7110 aon pinctrl Hal Feng
2022-12-20 20:20 ` Rob Herring
2023-02-03 6:48 ` Hal Feng
2022-12-20 0:55 ` [PATCH v3 4/5] pinctrl: starfive: Add StarFive JH7110 sys controller driver Hal Feng
2023-01-31 14:08 ` Andreas Schwab
2023-02-03 7:04 ` Hal Feng [this message]
2022-12-20 0:55 ` [PATCH v3 5/5] pinctrl: starfive: Add StarFive JH7110 aon " Hal Feng
2023-01-12 19:30 ` [PATCH v3 0/5] Basic pinctrl support for StarFive JH7110 RISC-V SoC Conor Dooley
2023-01-17 2:38 ` Hal Feng
2023-01-17 6:29 ` Conor Dooley
2023-01-31 0:59 ` Hal Feng
2023-01-31 13:13 ` Linus Walleij
2023-01-31 13:25 ` Conor Dooley
2023-02-03 7:33 ` Hal Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c6583eb-2c03-a584-1faf-8cbd44674175@starfivetech.com \
--to=hal.feng@starfivetech.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=jianlong.huang@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®