From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Nick Crews <ncrews@chromium.org>,
Enric Balletbo Serra <eballetbo@gmail.com>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Duncan Laurie <dlaurie@chromium.org>,
Daniel Erat <derat@google.com>, Dmitry Torokhov <dtor@google.com>,
Simon Glass <sjg@chromium.org>,
bartfab@chromium.org, Oleh Lamzin <lamzin@google.com>,
Jason Wong <jchwong@google.com>
Subject: Re: [PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support
Date: Wed, 15 May 2019 15:00:22 +0200 [thread overview]
Message-ID: <7c672532-e1f4-0e10-94a0-728a7fe575cb@collabora.com> (raw)
In-Reply-To: <CAHX4x8506kfxeuk4n5Q=HjceT5zV-gifGXYNYfge_wV825ki4Q@mail.gmail.com>
Hi,
On 10/5/19 18:09, Nick Crews wrote:
> Thanks for the review Enric!
>
> I can resend the patch with the fixes, or if you think the fixes are
> simple enough, you could tweak them as you apply them. Let
> me know if you want me to resend a clean version.
>
No need to resend, I tweaked them.
The patch is queued to the for-next branch for the autobuilders to play with, if
all goes well I'll add the patch for 5.3 when current merge window closes.
Thanks,
Enric
>>> +
>>> +static DEVICE_ATTR_WO(boot_on_ac);
>>
>> Is not possible to read the flag? From the API description seems that it is.
>
> It is not possible to read the flag. The API description is wrong,
> I'll fix remove
> the line about reading from the documentation.
>
>>> +void wilco_ec_remove_sysfs(struct wilco_ec_device *ec)
>>> +{
>>> + sysfs_create_group(&ec->dev->kobj, &wilco_dev_attr_group);
>>
>> As Guenter pointed: sysfs_remove_group()
>
> Yes, exactly.
>
prev parent reply other threads:[~2019-05-15 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 1:20 Nick Crews
2019-04-17 1:20 ` [PATCH v3 2/2] platform/chrome: wilco_ec: Add USB PowerShare Policy control Nick Crews
2019-05-09 21:46 ` Enric Balletbo Serra
2019-04-18 15:42 ` [PATCH v3 1/2] platform/chrome: wilco_ec: Add Boot on AC support Nick Crews
2019-05-01 17:06 ` Nick Crews
2019-05-09 21:31 ` Enric Balletbo Serra
2019-05-10 16:09 ` Nick Crews
2019-05-15 13:00 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c672532-e1f4-0e10-94a0-728a7fe575cb@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bartfab@chromium.org \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=eballetbo@gmail.com \
--cc=jchwong@google.com \
--cc=lamzin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®