From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Michal Simek <michal.simek@amd.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 02/11] usb: dwc3: st: simplify with dev_err_probe
Date: Tue, 27 Aug 2024 11:35:23 +0200 [thread overview]
Message-ID: <7c6df930-f685-421d-9186-b064d15dfa00@linaro.org> (raw)
In-Reply-To: <20240827011901.zcu3x24ph3bmfwap@synopsys.com>
On 27/08/2024 03:19, Thinh Nguyen wrote:
> On Wed, Aug 14, 2024, Krzysztof Kozlowski wrote:
>> Use dev_err_probe() to make the error paths a bit simpler.
>
> I think it makes more sense to note that this helps with cases of
> -EPROBE_DEFER than making this simpler. Regardless, this is an
> improvement.
>
> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Yeah, I forgot about this argument. Getting resets can defer, so this
actually solves the dmesg flood for deferred probes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-27 9:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 10:35 [PATCH 00/11] usb: dwc3: various cleanups Krzysztof Kozlowski
2024-08-14 10:35 ` [PATCH 01/11] usb: dwc3: st: use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-14 15:43 ` Patrice CHOTARD
2024-08-27 1:08 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 02/11] usb: dwc3: st: simplify with dev_err_probe Krzysztof Kozlowski
2024-08-14 15:44 ` Patrice CHOTARD
2024-08-27 1:19 ` Thinh Nguyen
2024-08-27 9:35 ` Krzysztof Kozlowski [this message]
2024-08-14 10:35 ` [PATCH 03/11] usb: dwc3: st: simplify pdev->dev usage Krzysztof Kozlowski
2024-08-14 15:45 ` Patrice CHOTARD
2024-08-27 1:19 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 04/11] usb: dwc3: imx8mp: simplify with devm_clk_get_enabled Krzysztof Kozlowski
2024-08-14 15:45 ` Frank Li
2024-08-27 1:26 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 05/11] usb: dwc3: imx8mp: simplify with dev_err_probe Krzysztof Kozlowski
2024-08-14 15:44 ` Frank Li
2024-08-27 1:27 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 06/11] usb: dwc3: imx8mp: use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-14 15:43 ` Frank Li
2024-08-27 1:30 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 07/11] usb: dwc3: qcom: " Krzysztof Kozlowski
2024-08-27 1:32 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 08/11] usb: dwc3: qcom: simplify with devm_platform_ioremap_resource Krzysztof Kozlowski
2024-08-27 1:34 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 09/11] usb: dwc3: rtk: use scoped device node handling to simplify error paths Krzysztof Kozlowski
2024-08-27 1:43 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 10/11] usb: dwc3: rtk: return directly and simplify with devm_platform_ioremap_resource Krzysztof Kozlowski
2024-08-27 1:44 ` Thinh Nguyen
2024-08-14 10:35 ` [PATCH 11/11] usb: dwc3: xilinx: simplify with dev_err_probe Krzysztof Kozlowski
2024-08-27 1:45 ` Thinh Nguyen
2024-08-27 1:59 ` [PATCH 00/11] usb: dwc3: various cleanups Thinh Nguyen
2024-08-27 9:36 ` Krzysztof Kozlowski
2024-08-28 2:08 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c6df930-f685-421d-9186-b064d15dfa00@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=patrice.chotard@foss.st.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®