From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902A3745CD for ; Thu, 21 Dec 2023 13:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gcQotWQ+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703163890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKUbSujUcjmbQNVNTnGKXDlRz29Lyk23in1kHV5SnwU=; b=gcQotWQ+m0ZW+T+03cqdoFhb5/Cg7Sns/2HyFf4jFDdKs5JnIgoG8ImFsPJXhb/sA5g/cY r4pUe0WS/DkCqTeKNXDnHdMFEhvIDWn5aMB9I3Y74y78gYdkPkg13AsEWS+UgRplOa/dbM ivVmDZnVXaeSINwI19PlPKDX82B1jYg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-uuOyQurBM-SQ9J5z2PwaaA-1; Thu, 21 Dec 2023 08:04:47 -0500 X-MC-Unique: uuOyQurBM-SQ9J5z2PwaaA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a1f99dd182dso37239366b.3 for ; Thu, 21 Dec 2023 05:04:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703163886; x=1703768686; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cKUbSujUcjmbQNVNTnGKXDlRz29Lyk23in1kHV5SnwU=; b=gQbiDvDiJdpnWUTnXqEnB/iEIiN6SapkZlB3bd2w/KhricM3Q/fRy4YCLgiczfgEcu EoU3oqFz0Ow2xBqZNtZ4wnp4U1iJzZCsmCLhmRNFq/RebDDzl0HHwms5mDelgflwyF5g F1PFF8tYGWrZW2WCTQWauzeArtUJGt++IxR1Wp2kMo3I0BARCqBJsJfyYTaouxCOT2uX PjMwNB1+S/0epBaQqAByuFt7vdO//DwbRmnRbH132PWTHrrgq5F1c/SCeypoK+rTpLJG O8IYl2W+mSaCpqJbvIaosnobbz09Qn0Luyz0Sq0KIrk7gGvYvLuBW9f1z6O55tlFSXzD rO3Q== X-Gm-Message-State: AOJu0Yx44tPNQCsKLoXsRF2EZIvu+Hh+MXXMAyIofmYYGPFtoUwnpuVw THugBPtw5lVJ/mpxg7nzFGsOk/OHFaUXMVwwI6bpFYYVWpLSDAQHy0KYs4OHUVAU5hvCLGdFxL7 EkTodmD7h2b8MniRFlrjG+Y7s X-Received: by 2002:a17:906:4c8e:b0:a1e:9d8b:1e86 with SMTP id q14-20020a1709064c8e00b00a1e9d8b1e86mr11143647eju.72.1703163886053; Thu, 21 Dec 2023 05:04:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+itG5vbj8FUnUO+KnlZB9cMqpbrWwUxk4M61vw39M2ROTdOf09d0+KzfhLbDo/uyzujBEdg== X-Received: by 2002:a17:906:4c8e:b0:a1e:9d8b:1e86 with SMTP id q14-20020a1709064c8e00b00a1e9d8b1e86mr11143643eju.72.1703163885771; Thu, 21 Dec 2023 05:04:45 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id ka23-20020a170907921700b00a236e9cfe74sm926599ejb.103.2023.12.21.05.04.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 05:04:44 -0800 (PST) Message-ID: <7c70b998-6d8c-426e-93d9-eabf9e3475af@redhat.com> Date: Thu, 21 Dec 2023 14:04:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: hp-bioscfg: Removed needless asm-generic Content-Language: en-US, nl To: Nick Desaulniers , Tanzir Hasan Cc: Jorge Lopez , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro References: <20231219-hp-password-v1-1-052fe7b6b7f1@google.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 12/20/23 20:24, Nick Desaulniers wrote: > On Tue, Dec 19, 2023 at 10:10:52PM +0000, Tanzir Hasan wrote: >> asm-generic/posix-types.h is obtained through bioscfg.h so there is no >> need to include it. > > I verified that by: > 1. building with V=1 > 2. taking the compiler invocation and adding -H > > . drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > .. ./include/linux/wmi.h > ... ./include/linux/device.h > .... ./include/linux/dev_printk.h > ..... ./include/linux/compiler.h > ...... ./arch/x86/include/generated/asm/rwonce.h > ....... ./include/asm-generic/rwonce.h > ........ ./include/linux/kasan-checks.h > ......... ./include/linux/types.h > .......... ./include/uapi/linux/types.h > ........... ./arch/x86/include/generated/uapi/asm/types.h > ............ ./arch/x86/include/asm/posix_types.h > ............. ./arch/x86/include/uapi/asm/posix_types_64.h > .............. ./include/uapi/asm-generic/posix_types.h > >> It is also an asm-generic file which should be >> avoided if possible. > > Correct, though there is a linux/posix_types.h file. > > biocfg.h hasn't seen any changes since introduction; perhaps some reference was > removed in follow up changes to passwdobj-attributes.c, but nothing stood out. > > Regardless, this file builds just fine without either (asm/posix_types.h or > linux/posix_types.h), and asm-generic should not be used (as suggested by Al). > > Reviewed-by: Nick Desaulniers > Tested-by: Nick Desaulniers Thank you both for the patch + review, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans >> Suggest-by: Al Viro >> Signed-off-by: Tanzir Hasan >> --- >> drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> index 03d0188804ba..f7efe217a4bb 100644 >> --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c >> @@ -7,7 +7,6 @@ >> */ >> >> #include "bioscfg.h" >> -#include >> >> GET_INSTANCE_ID(password); >> /* >> >> --- >> base-commit: 3fb7c66ac51a87984e043d9f47b7a509e3f53906 >> change-id: 20231219-hp-password-19068dc438b5 >> >> Best regards, >> -- >> Tanzir Hasan >> >