From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: mingo@redhat.com, peterz@infradead.org
Cc: mark.rutland@arm.com, bigeasy@linutronix.de,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
venkat88@linux.ibm.com, tglx@linutronix.de, maddy@linux.ibm.com,
will@kernel.org
Subject: Re: [PATCH v2 1/1] sched: preempt: Move dynamic keys into kernel/sched
Date: Tue, 12 Aug 2025 23:51:10 +0530 [thread overview]
Message-ID: <7c70fac4-3cc7-4bf1-a3f1-aa1c61f67425@linux.ibm.com> (raw)
In-Reply-To: <20250716094745.2232041-2-sshegde@linux.ibm.com>
On 7/16/25 15:17, Shrikanth Hegde wrote:
> Dynamic preemption can be static key or static call based.
> Static key is used to check kernel preemption depending on
> the current preemption model. i.e enable for lazy, full.
>
> Code is currently spread across entry/common.c, arm64 and latest being
> powerpc. There is little arch specific to it. arm64, powerpc have the
> same code. It is better to move it into kernel/sched since preemption
> is more closely associated with scheduler.
>
> Plus, Any new arch that wants dynamic preemption enabled need to have
> only HAVE_PREEMPT_DYNAMIC_KEY.
>
> Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Shrikanth Hegde <sshegde@linux.ibm.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Will Deacon <will@kernel.org>
> Acked-by: Madhavan Srinivasan <maddy@linux.ibm.com>
> ---
> arch/arm64/include/asm/preempt.h | 1 -
> arch/arm64/kernel/entry-common.c | 8 --------
> arch/powerpc/include/asm/preempt.h | 16 ----------------
> arch/powerpc/kernel/interrupt.c | 4 ----
> include/linux/irq-entry-common.h | 1 -
> include/linux/sched.h | 8 ++++++++
> kernel/entry/common.c | 1 -
> kernel/sched/core.c | 4 ++++
> 8 files changed, 12 insertions(+), 31 deletions(-)
> delete mode 100644 arch/powerpc/include/asm/preempt.h
>
Hi Ingo, Peter.
Does this change makes sense? Are there any further concerns that you see?
Also can it go via tip tree?
Patch applies on 6.17-rc1 (at commit ca76508b9352e8c770b58213cc6c4700e459b7c2)
next prev parent reply other threads:[~2025-08-12 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 9:47 [PATCH v2 0/1] powerpc, arm64: move preempt dynamic key " Shrikanth Hegde
2025-07-16 9:47 ` [PATCH v2 1/1] sched: preempt: Move dynamic keys " Shrikanth Hegde
2025-08-04 7:06 ` Venkat
2025-08-12 18:21 ` Shrikanth Hegde [this message]
2025-07-23 7:44 Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c70fac4-3cc7-4bf1-a3f1-aa1c61f67425@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=venkat88@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®