From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbcGSG01 (ORCPT ); Tue, 19 Jul 2016 02:26:27 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:63499 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbcGSG0Z (ORCPT ); Tue, 19 Jul 2016 02:26:25 -0400 X-AuditID: cbfec7f5-f792a6d000001302-96-578dc80d50cf Subject: Re: [PATCH v2 00/10] Exynos IOMMU: proper runtime PM support (use device dependencies) To: Tobias Jakobi , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1466144820-6286-1-git-send-email-m.szyprowski@samsung.com> <5787B2B0.9020809@math.uni-bielefeld.de> <5788E352.3040801@math.uni-bielefeld.de> <578CB6DB.90608@math.uni-bielefeld.de> <6939949e-4c8e-cba0-9858-b37d1ba01869@samsung.com> <578D0716.6060106@math.uni-bielefeld.de> Cc: Joerg Roedel , Inki Dae , Kukjin Kim , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Ulf Hansson , Mark Brown , Greg Kroah-Hartman From: Marek Szyprowski Message-id: <7c770ff5-2b22-adf6-b8d0-e94d1d7d7550@samsung.com> Date: Tue, 19 Jul 2016 08:26:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-version: 1.0 In-reply-to: <578D0716.6060106@math.uni-bielefeld.de> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xq7q8J3rDDY7NMLbYOGM9q8XUh0/Y LJoXr2ezmHR/AovFgv3WFp2zN7BbvH5haNH/+DWzxabH11gtLu+aw2bxufcIo8WM8/uYLM6c vsRq0bb6A6vF8bXhDvweTw7OY/LYtKqTzePOtT1sHvvnrmH32Lyk3mPyjeWMHv+OsXtsudrO 4tG3ZRWjx+dNcgFcUVw2Kak5mWWpRfp2CVwZUy5PZCv4JFzx/s1upgbGHoEuRk4OCQETiZ5p K5kgbDGJC/fWs3UxcnEICSxllLgysxfKec4ocXR3CzNIlbBAokTb3T/sIAkRgRuMEu0zP0JV 3WaSOLh4C1iGWeATk8S1DwtYQVrYBAwlut52AVVxcPAK2EnMO2EDEmYRUJV497YfbKqoQIxE 4+3D7CA2r4CgxI/J91hAbE4BU4nG8z8YQWxmATOJLy8Ps0LY8hKb17xlnsAoMAtJyywkZbOQ lC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERJjX3cwLj1mdYhRgINRiYc3ga03XIg1 say4MvcQowQHs5IIb/QRoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphak FsFkmTg4pRoYd4jlLFu3cn7c9Tcz2bIljB3Pv1gjcIvvyXrL+IsLnqn+likOVOQs4nriLMPq uHv1le7kB48XT7XZ7D7dWfKA4y7DWqe07ctereD4ZZh57wyfwkE+7llBkvM4Jjp5zK0yinYI DrskOEE3rzhz5rGy1Phpctrh/If+vfS11u2+xKPOp8Z84sQGJZbijERDLeai4kQAMKe/+q0C AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tobias On 2016-07-18 18:43, Tobias Jakobi wrote: > Marek Szyprowski wrote: >> On 2016-07-18 13:00, Tobias Jakobi wrote: >>> Marek Szyprowski wrote: >>>> On 2016-07-15 15:21, Tobias Jakobi wrote: >>>>> Tobias Jakobi wrote: >>>>>> Hello Marek, >>>>>> >>>>>> I've tested the patchset on 4.7-rc7 and noticed that it breaks >>>>>> reboot on >>>>>> my ODROID-X2. >>>>>> >>>>>> Going to check where exactly things break. >>>>> Sadly it's the last patch where everything comes together: >>>>> "iommu/exynos: Add proper runtime pm support" >>>>> >>>>> I still have to check if forcing runpm status to 'on' makes a >>>>> difference. I suspect that the aggressive clock gating might be the >>>>> reason? >>>> Thanks for testing. I will check this issue. Could you send me your >>>> .config? >>> This is the config I'm currently using: >>> https://github.com/tobiasjakobi/odroid-environment/blob/master/sourcecode/system/vanilla-4.7-debug.conf >>> >>> >>> Do you think checking this with no_console_suspend makes sense? >> no_console_suspend switch won't provide more information, but I managed >> to reproduce your issue. I'm really confused how enabling runtime pm can >> cause problems with usb/smsc95xx ethernet driver (that is the reason for >> failed reboot). Maybe it is somehow related to the global relations >> between devices and drivers and the fact that creating the runtime pm >> links change the order of operations. I will check this again when >> Rafael send updated patches. Here is the log I got (after waiting some >> time): > thanks for looking into this! I'll try to reproduce this on my board. I > have to admit that I didn't wait too long for the hung task message to > appear. > > I wonder if this has something to do with regulator code cutting some > supplies too early. Is this on a X2 or a U2/U3? I've reproduced it on U3. > I'm not sure if we > currently model the regulator setup correctly here (IIRC then buck8 is > supplying the LAN/USB block on U2/U3). IMHO it is not really related to regulator operations, but the sequence of shutting down logical devices in the system. For some reasons when pm links are used, something changes the order of operations in system shutdown procedure, what causes smsc95xx to hang. I have no idea why, but I don't have time to investigate it further. I will wait for the next release of Rafael's pm links patches and then check everything again. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland