From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ACB9379ECC for ; Mon, 2 Mar 2026 08:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439163; cv=none; b=YO/lFc74P+tkl4VO06kCPvfa85Cb8kxDHUo5N5GlfD2eGXZj4gLPaBrDkwM1pvYTQ+O6XbIh+82dAX0VCaaH4CA5BAEO51IZUUzETXYM65zzStO9fGWvJr+5Hr0VthVMzE16OzKMClSrv9uPifIwd3CiPRMmULT4AO+QHH9kWKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772439163; c=relaxed/simple; bh=YsoqRWEnmbezHwWXwK/cDOGeLeQ6w9y75yey82wwwm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f6v9tuUXMYenKUOl53MtsiKm2/6wH0HULPpkqzsj715U3tvbi+aZJpw0IcI2w7Jw7/HLmU1YCMIYX3z3FdDJ7Nd4FQmha252menC1Yfs2K1q+HWAKeiOzBhYeAPsK7dPIFVMIQpSNumpascPkLpZuO9BFc4++yVy4hB5XFLpuyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zcdf6M3T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D4ilGxuI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zcdf6M3T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D4ilGxuI" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62285YSe662249 for ; Mon, 2 Mar 2026 08:12:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YsoqRWEnmbezHwWXwK/cDOGeLeQ6w9y75yey82wwwm4=; b=Zcdf6M3TDZSqgLfi 2fOACi2y03BjI9OAyOXRdu+xMXNoPtWdj6Ek1x0Qy/8C4fGtH76ZW/iXVF3mWHAA ztFRrpNZLG/8+C5HjF+ze1OXv5Y42H48tv31J8YAeKOdKDxcmE2vUM4XHdK1SH8N jqX0S6BVY+TTHOKa8leb4b0QIf0+mKpOvK/3mI1ThRJe9zUEqvEukp/XDr4nbxUA jTo+HvAOgYjTVPbYEgaxGiCkubU/Qs+Ysfngq2+QgLtFbQ/5LSG4vly1R6QsXvWS TMUF1Drizz87ppE9SsMzmlkgV+Ggb5Rd3yAQJTIXDHGPAD5hIZQufb/rTITsRA5J nkpwuA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn6r2r0w9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 08:12:39 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c70f7110dd1so17352273a12.0 for ; Mon, 02 Mar 2026 00:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772439159; x=1773043959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YsoqRWEnmbezHwWXwK/cDOGeLeQ6w9y75yey82wwwm4=; b=D4ilGxuIfa3j3PfnGkcMNeqt4t782rLpSmgNoJ+y7q3rq3ToOsohHVtfIFy6xQ/HNy 49UL9OQwxuMS7zH8zTd4S7gUSTJ0MHp1yG9mqg8PSCqaNFpL9Ae150VchoLUlBozgid/ ecEwWDAP6iJZ5q632Ztgbd60RKeEn/12tMroIDGZwuMNMA7v2MxAvNddnUUxU8ucJrS0 AMhEDh91Y9or+GfGxSMrpf7ZcYXU0n8V8qpyTJi2DuBM0Wn/kl+eDU/ar5zBRMqloZXn TLEoZVNs0V7oHpGHPO8+IkP+Ie8y98CHTgTCtkVR6LepHaJXvd1D+FaonrNBK7sbU7UH edGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772439159; x=1773043959; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YsoqRWEnmbezHwWXwK/cDOGeLeQ6w9y75yey82wwwm4=; b=BduknDDuMCRbQN29MDuZMs+jb4JsZv/nPoYRmm4+x7ElQ89InjjGITm+GSJzQG2I5W jGJz1mZ7fR0rNEuZaNIDAz+5VwCOgcnRGVmy6XU9TzkwJCQ+Sdac07VcCqY2RRjAtzcs XvNpI9URThvaH0/WTBE9S1Pxdm5DSoJR3ienS8IN6nF+dyDIr+As4CTtu0wtgxEUu5Eb 2pWjKHDqWZguHbUZZzeh8zR2YbRayTWQlh1HtSsf5PqFxSyG5ScNsxTLU35UVn7oIOVf tu8DhT8ien3yOpauX6VKE7mNhG14Fq0HxW3gEmeD1X90yucaqrGpPBdUzKf2rh2MnAGE 9jJQ== X-Forwarded-Encrypted: i=1; AJvYcCXlMSjy6I949tE5pbhSc7Ef80fvk/iGZXZ0taZJMGjqDMDg7FoBwrlzDvRdPdaDS4YpKrfZzqn5jZABht0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2Edo4FoCDwXVDpF5Dd5esyDl8+ugNNVfdY4evu3RztEmrjGtw wf/gWCA/GAeRh86hziyEBIqjWEStZw+jg98TkDolhc+v5hzlEk7lWcuTJ1U9HLMAPToPIYZfvEr yumgoWnZkrT4o8YRnvTnKPJ8/hXPiAd+mi5ZvKcEHwHm21dTfACrbECHhpN3SSB6+uaQ= X-Gm-Gg: ATEYQzy4aUKvurNOBa0CHRG+F9p3s49GE21prnQDIhtLdBLmI+v7I958LRLkBjpNx5k D6SqsTP7PnqQ+TsSIxAFTxLR7fpRWQx9QEZ1uJKzrt/L7YEszyxPO7bwJRetzOgOvyoBsQSGbo9 DQB3SGL3kD3c53sAxFjYrK2gPTIKc5f31FTNQNtDqh/tsZw3IlLmixQR0d9d0wqObvFh6D56VeX vih2kTOftFPWUlWzLkHnfI3yIUUd5v4XSOyc3xHNrBC61lk/8cNKLJ+WXV9KtceizpfzuheOqJk lWER6FfQBrhQQXdr+BNYaE/RmDfdIaAodWvisILLJvMIgrMrutOyDdpTBn10vxQWHpVW33qOoGO rVzHFzsS4jJ3sYM5bodN6Z8kqTk+8/oPl3myoGERU7LPL/S3Nsw== X-Received: by 2002:a05:6a00:414a:b0:81b:8872:ae10 with SMTP id d2e1a72fcca58-8274d8090eemr11014004b3a.0.1772439158732; Mon, 02 Mar 2026 00:12:38 -0800 (PST) X-Received: by 2002:a05:6a00:414a:b0:81b:8872:ae10 with SMTP id d2e1a72fcca58-8274d8090eemr11013957b3a.0.1772439158150; Mon, 02 Mar 2026 00:12:38 -0800 (PST) Received: from [10.206.99.28] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a060071sm12915292b3a.63.2026.03.02.00.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 00:12:37 -0800 (PST) Message-ID: <7c795b4b-3a3f-47fb-9ef9-0b13601f584c@oss.qualcomm.com> Date: Mon, 2 Mar 2026 13:42:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 04/18] accel/qda: Add built-in compute CB bus for QDA and integrate with IOMMU To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Joerg Roedel , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Srinivas Kandagatla , Bharath Kumar , Chenna Kesava Raju References: <20260224-qda-firstpost-v1-0-fe46a9c1a046@oss.qualcomm.com> <20260224-qda-firstpost-v1-4-fe46a9c1a046@oss.qualcomm.com> Content-Language: en-US From: Ekansh Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: nRO3FuIqDGHWGclF5dRyZbxspgJQt4M7 X-Proofpoint-ORIG-GUID: nRO3FuIqDGHWGclF5dRyZbxspgJQt4M7 X-Authority-Analysis: v=2.4 cv=Hpp72kTS c=1 sm=1 tr=0 ts=69a54677 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=jwkSyuDCPDQl0KFoS7wA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA3MCBTYWx0ZWRfX2vbNjuVNLBHj Aq/4yNyJwzLt+DoK0q/ptBgv9Q/CWhTr2hpcuOq74CFg8YQNAqd3PG6c1qPZ+7FOJRGRUmfBTlJ nqhjI9/q+RhowjCUZRcEIndhV0bEtHPGoEvmA56hnlz2q3Hr89ITQjVzsahcvc8pDK7GO0X2k07 Gql7wb07cCBJmX/dnhn0LUWl50pnx4SNElg7u0U6qhvyTxQkodZWM+4FkWRSALh3F5GZBMq17bw FxBbP97A2yguApucy6tRl2rLHr0v9of4WLh17oehGOTWdYXo+oNnuna4MgfR6Ouxx/pi+GP/xVW i3JgyT0cbwozov+X6uxwApgQ6CKbBNpnhZvFMRRvz1Hl/5HlAsRrfNcq7det1e2kraOvjvQunOu 3j25pI8yBoreXK7E0oDlHxt+YnMghPCWIjOlm5lWj5OneGHNB9cHJN1ZzxUxmwOgrv5AoopDK04 6DRizJ7nMhAdhEcvSdw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020070 On 2/26/2026 12:39 AM, Dmitry Baryshkov wrote: > On Wed, Feb 25, 2026 at 11:26:52PM +0530, Ekansh Gupta wrote: >> >> On 2/24/2026 4:14 AM, Dmitry Baryshkov wrote: >>> On Tue, Feb 24, 2026 at 12:38:58AM +0530, Ekansh Gupta wrote: >>>> Introduce a built-in compute context-bank (CB) bus used by the Qualcomm >>>> DSP accelerator (QDA) driver to represent DSP CB devices that require >>>> IOMMU configuration. This separates the CB bus from the QDA driver and >>>> allows QDA to remain a loadable module while the bus is always built-in. >>> Why? What is the actual problem that you are trying to solve? >> Bus needs to be built-in as it is being used by iommu driver. I'll add more details here. > It's an implementation detail. Start your commit message with the > description of the issue or a problem that you are solving. Ack. > >>>> A new bool Kconfig symbol DRM_ACCEL_QDA_COMPUTE_BUS is added and is >>> Don't describe the patch contents. Please. >> Ack. >>>> selected by the main DRM_ACCEL_QDA driver. The parent accel Makefile is >>>> updated to descend into the QDA directory for both built-in and module >>>> builds so that the CB bus is compiled into vmlinux while the driver >>>> remains modular. >>>> >>>> The CB bus is registered at postcore_initcall() time and is exposed to >>>> the IOMMU core through iommu_buses[] in the same way as the Tegra >>>> host1x context-bus. This enables later patches to create CB devices on >>>> this bus and obtain IOMMU domains for them. >>> Note, there is nothing QDA-specific in this patch. Please explain, why >>> the bus is QDA-specific? Can we generalize it? >> I needed a custom bus here to use for the compute cb devices for iommu >> configurations, I don't see any reason to keep it QDA-specific. The only requirement >> is that this should be enabled built in whenever QDA is enabled. > Why? FastRPC uses platform_bus. You need to explain, why it's not > correct. Ack. > >> But if I keep it generic, where should this be placed? Should it be accel(or drm?) specific? > drivers/base? Or drivers/iommu? That would totally depend on the issue > description. E.g. can we use the same code for host1x? I'll evaluate and bring this change separately for fastrpc and host1x. > >