From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: verify MNAN value if ANA is enabled
Date: Mon, 31 May 2021 17:25:38 +0200 [thread overview]
Message-ID: <7c7b96e7-ea31-1d3b-9b5c-3b89133926b5@suse.de> (raw)
In-Reply-To: <20210531103651.109426-1-dwagner@suse.de>
On 5/31/21 12:36 PM, Daniel Wagner wrote:
> The controller is required to have a non-zero MNAN value if it supports
> ANA:
>
> If the controller supports Asymmetric Namespace Access Reporting, then
> this field shall be set to a non-zero value that is less than or equal
> to the NN value.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
> This is a follow up to the discussion in
>
> https://lore.kernel.org/linux-nvme/20210521144734.90044-1-dwagner@suse.de/
>
> drivers/nvme/host/core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index cb1a76a3d42a..4c412adc9e14 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2972,6 +2972,16 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
> if (ret < 0)
> goto out_free;
>
> +#ifdef CONFIG_NVME_MULTIPATH
> + if (ctrl->ana_log_buf && (!ctrl->max_namespaces ||
> + ctrl->max_namespaces > le32_to_cpu(id->nn))) {
> + dev_err(ctrl->device,
> + "Invalid MNAN value %u\n", ctrl->max_namespaces);
> + ret = -EINVAL;
> + goto out_free;
> + }
> +#endif
> +
> if (ctrl->apst_enabled && !prev_apst_enabled)
> dev_pm_qos_expose_latency_tolerance(ctrl->device);
> else if (!ctrl->apst_enabled && prev_apst_enabled)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, 90409 Nürnberg
GF: F. Imendörffer, HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2021-05-31 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 10:36 Daniel Wagner
2021-05-31 15:25 ` Hannes Reinecke [this message]
2021-06-01 17:28 ` Chaitanya Kulkarni
2021-06-03 7:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c7b96e7-ea31-1d3b-9b5c-3b89133926b5@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®