From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BFC633B97D for ; Mon, 23 Feb 2026 18:14:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870448; cv=none; b=MZc9Ss9cSIpAPjyutVLgWfG6oZZOTOK24MzwxEiy6gVYsWC1Ar5RtnBV7MDb9JqE7ffhA6uw4XG2sXjFQ8uSATOrK4mrmdU8G2fGBjFL26JfizjmnlPzp0itbG/BIA0y9RLhqShwgAh/9ohp5mstQz/yiEv4qmDQO5VESnguA1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771870448; c=relaxed/simple; bh=t5c8HTVQFFK6SR65sLMMRCj/tKPnC2Vs90IQgfid574=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ItIzQC8mUSXL6Vr5Nz3b/fURI/cOOGiGk1nG1SEA0ldu1h3QFg2be4Le1UlbR5Vs0Cjds2HEqfEcGxarEajQnvUcnvELs/BD4dKGNi+ftTKiZH6rqe2ttkZZui2PTc5wqoDFarxs9RA+lhjdKA+Tn9POnk46looGDTp2qkG3+AY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iRHSSZKw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ViEwNqC6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iRHSSZKw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ViEwNqC6" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61NGFJOf3936183 for ; Mon, 23 Feb 2026 18:14:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uMxCXETim4pZgjyQEJ9B41Fp8Ce2XQixYnJKPqTI2og=; b=iRHSSZKwbjPahLlg T6knaUfDb+t1XH5kjmEcBh5CdItxGiHt44lnR/MITxPW/gO/FY4Ob9uV6s653OYl g3zq+iucOEjjE2bU7J1ZQSuLhPQk6UbGp5cnCHzSDUS9BGv2U6xRuWFPU+FLpbUo xiYM0na6fNQ2F5GlSNQvCl4EIO4dTXE5xZp+79YRWwswni/t8QT0WNMUUZcaoRUa Q/ybG1sOfznVLTm3hhUcK5AC5VCoUBKrFDpnReRPVoiw/HxSLo9xpfL1IIBgWr8x 5Ll60oweA4nRFXmD7acUvm0Hn94ENpqAyX25gmSn1oQ9AthWac+CJXIpkNCQVTw/ MXe9BA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgt8mgd5s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 18:14:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb52a9c0eeso2085371585a.2 for ; Mon, 23 Feb 2026 10:14:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771870444; x=1772475244; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uMxCXETim4pZgjyQEJ9B41Fp8Ce2XQixYnJKPqTI2og=; b=ViEwNqC6LF7nMdTROpdGOpD7vAuE2cW3DSIhfjs4zdYLoZ9gIwbYZ7Z4zQDRz8piev y8Gd9g7+SLlUujch4Cs3H96wItRJS+AwRrD//TXruv91fp+Tw/KnbYIjP7KCGogaJ3gf LdVIxikoFJld3U1kBZgsiOO0LG9q4oJ6btzyUmvvWp2asCAkPFf3oJ58Wf8CVdV1N9YT j+GRIQ/8aLW7oOYVj+nos8Kb0pXZl93kvbbyT5QPGGQuWh5kkrg5A1y/QzXc8CJ59y45 sQRM4d9i3FcPAIV+Xr1/6hUYW6ndfDdM1Pr1Q7JIRisg2HhU2NbnayCtG4V745M2hRIB Bk3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771870444; x=1772475244; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uMxCXETim4pZgjyQEJ9B41Fp8Ce2XQixYnJKPqTI2og=; b=tqvHsyBPG7JvJgvUvjc82ccsP/WK+t2OmQpIdIbQXUCEP1WaWY+LOQvTZPNtY+ryxF +IaOUmrpJT33J4h+ogd7tnAJCDUcIEVL+7xcIgkNYsGolmsXKToAJfbw+hsmj8BMak6m F1AShphQ5QdWRLXReDGMPWJmeL3pVVL4MC2KdD1l1rBfmIFksX15UlhChKNwv+vnAjZR Ka8IQTqvQ7wR3jHAwIrq3mud0PnEri3CbadiGQeP6Dd/YrzqAXcYviqTvGAuVnfs6L9k Mzg1EW1PKRTKYtiA2rSa9crvoKTVv0vsepM5KJgs1Nu1e1y9PoZ+/6dwpjpwh6NHo/dS ZR7A== X-Forwarded-Encrypted: i=1; AJvYcCXbNhvDj1pxuedbyzTogAKsm5rM9mpdeLjN7kX8f3mrTWfazYdruv4q7Qd5ihFTTD8/DvLi3ILjLAjwjfw=@vger.kernel.org X-Gm-Message-State: AOJu0YzCzm7kWcGUa91b3Eha5aOKndL0LhkuGgnmY9nrbBj7l8kQ2ppd UV4fh41hYZ8AHlwvGLUM9QI3bSHqZ1EwULKIkY3G6VFgt0LADDvxcIBZWRJrnGnTygqlw79Dljc Pu/+PiYIU9ugV02zsyy2txoQJU7YPLh0DMyH1VfIy2KaPRz0vUfYgXSiZd+aU1quSD6U= X-Gm-Gg: AZuq6aKDHfi1wNzkox7iwyhdnSV4ZAVLhERLpuuurJE/nrhXzzA57YqH8X36UYHo7bF p9ynDv3vtux+lgObv9umVAGWsteT0o0lqsozpFJJRLRXRsuy4fMdIcIQ9seloOFZmXCirhDYv53 kQKFK4+DqBh1E/TOUW2kD0Ym+zP+kbipn4Z6i3H55Yp8ND605XCJRqtOdfZnR9A191VGmNK+Wff 1aqiIXEntIFnXcdyYIIiJ1pBV5ncxUkScWKpp/GkRQ21xvv0+Gd1dZYY1Exd/t36m0hoSNFlFxW 7BfR003hb51XjsvWGN9yFV3Ko1HAfVdphiujkKU5VK4ALunNd/7TCDKQfR5GMbrTWenZpqu/i97 bGeH1wL8JTIzGgwG2/BZGFfNQRT6uwKmdtYW5EiA+nWa9434v X-Received: by 2002:a05:620a:1a85:b0:8ca:d5cb:6839 with SMTP id af79cd13be357-8cb8ca7fbd7mr1138922785a.65.1771870443624; Mon, 23 Feb 2026 10:14:03 -0800 (PST) X-Received: by 2002:a05:620a:1a85:b0:8ca:d5cb:6839 with SMTP id af79cd13be357-8cb8ca7fbd7mr1138918385a.65.1771870443184; Mon, 23 Feb 2026 10:14:03 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-43970d4c96csm22839756f8f.30.2026.02.23.10.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 10:14:02 -0800 (PST) Message-ID: <7c7ddd2c-c700-4453-a6f3-7d070016aa1c@oss.qualcomm.com> Date: Mon, 23 Feb 2026 18:14:01 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] dt-bindings: mfd: qcom,spmi-pmic: add compatibles for pm4124-codec To: Rob Herring Cc: lee@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alexey.klimov@linaro.org, r.mereu@arduino.cc, srini@kenrel.org, Krzysztof Kozlowski References: <20260223133950.221234-1-srinivas.kandagatla@oss.qualcomm.com> <20260223133950.221234-3-srinivas.kandagatla@oss.qualcomm.com> <20260223165636.GA3988149-robh@kernel.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260223165636.GA3988149-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=J/unLQnS c=1 sm=1 tr=0 ts=699c98ec cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=bMBjfq_dd7qU7rFTbikA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: HSBgTPYL_MsyiG2RHCC6LihsUY7FQLZP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDE1OCBTYWx0ZWRfX5FedxlvyT691 ySnEWt/zjiTIzR47PyMlCndYGQIeUEplzEyfa/7FGPe9b8WeudhH7k4Z61FCsBOibLbNXAmTEy9 7yknol+moxgbslTSONbtlZjzYdXekbf0vG/nAcQy1CgB+D0r2CybiXl1bSX/MZjiGzwExiquHvb 7dnF8JS6pQXMizErQZA0gJ9UttWR2CFCGulWfGSyZCmLvUGPR4h/Bq7EI3UOmytAwSS16ZZs7UH w2HLNQ+n2XRjUw10gCUcIICrsQhcwUigx1rm9EjXGr8ZGPaSg3yfd2lQeJKB8CvHIx0GP4FMbtv biN5ki43oUPDIEJPII6X0vEI9HUf7KLQ8ykelT3XCOdvlJZLxTjTiDBhZ3itLjD84RpElNCg1Fc aPtmPvq1B2ViqtxEHwbCy1xOptuKEbQTg+AtPInCOnKbacBCObPX2LHdGyVo9CQJxCmzEGrzrcZ mDv4HEGn/tGvSl+6CQA== X-Proofpoint-GUID: HSBgTPYL_MsyiG2RHCC6LihsUY7FQLZP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_04,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230158 On 2/23/26 4:56 PM, Rob Herring wrote: > On Mon, Feb 23, 2026 at 01:39:47PM +0000, Srinivas Kandagatla wrote: >> From: Alexey Klimov >> >> Qualcomm Agatti SoC has PM4125 PMIC, which includes audio codec. >> Audio codec has TX and RX soundwire slave devices to connect to on-chip >> soundwire master. >> >> Add missing qcom,pm4125-codec compatible to pattern of audio-codec node >> properties in mfd qcom,spmi-pmic schema to complete the audio codec support. >> >> Signed-off-by: Alexey Klimov >> [Srini: reworked the patch] >> Signed-off-by: Srinivas Kandagatla >> Reviewed-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index e5931d18d998..f58a85562c26 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -145,7 +145,11 @@ patternProperties: >> >> "^audio-codec@[0-9a-f]+$": >> type: object >> - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml# >> + oneOf: >> + - $ref: /schemas/sound/qcom,pm8916-wcd-analog-codec.yaml# >> + - properties: >> + compatible: >> + const: qcom,pm4125-codec > > Don't mix 2 styles. Just do: > > type: object > properties: > compatible: > contains: > enum: > - qcom,pm4125-codec > - qcom,pm8916-wcd-analog-codec Thanks Rob, will do that in v3. --srini > > required: > - compatible > >> >> "^battery@[0-9a-f]+$": >> type: object >> -- >> 2.47.3 >>