From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ED42C4332F for ; Tue, 14 Nov 2023 18:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233487AbjKNS1p (ORCPT ); Tue, 14 Nov 2023 13:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbjKNS1n (ORCPT ); Tue, 14 Nov 2023 13:27:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB263B8 for ; Tue, 14 Nov 2023 10:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699986459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=U5juBUKVUX+WdnY78HsqgVZ5QyAPcX7+J7Buvj7Sdls=; b=KiMhUnpVNriZGne0MdccJMTiyHsvLsNpP9cQ+atejMpEXcMNSi31yVfCx+h7R+lVNQIj95 31LyIa9mcBTMZ8EyC9ZrABdcp9IOspnsRL/SogKbmPmoiEI9jaKteudBbXRlFUDjeYAq8u cIyCNAGQ5SEu+fc5KoDKQba8oqoCiT0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-i2R_Lv8BNg-Mrlu-X_cMFQ-1; Tue, 14 Nov 2023 13:27:38 -0500 X-MC-Unique: i2R_Lv8BNg-Mrlu-X_cMFQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32db43129c6so3042595f8f.1 for ; Tue, 14 Nov 2023 10:27:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699986457; x=1700591257; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U5juBUKVUX+WdnY78HsqgVZ5QyAPcX7+J7Buvj7Sdls=; b=IXFNrzjUC9MXHuuaO/T+D66Z/dJQ3So4xSl2SDeTiTUBnF8F/BrOYxNd2d3WxD/QN0 qZVQZuPvn8r80zxexLthcfmhvFNwmM2XkVLyDZafrgX1v19uSj7aSKc664ftSmUi2Oxv RT+y+Ae2yrJFkYqXd92TaKae2lAWKgsAVvFnG12g9kPN6JNU58QJx3HjtXWdNN4ZQRqX 8a8TWr6Q0oHlvU2oMpn86E7Xs0Rb1aYfdkt2Sh1CHVdRlfGclQFSoBMm8sE8vXeKjMVa yo9iyK47g+eMS8EIbbSEAEXouz78l/bPnRmfispB3eCNPOveUxMau45t3KoGeJlBH1uB mWKg== X-Gm-Message-State: AOJu0YzoY6cTu3Cn+3u/qiZ0eU40HCtHgCbFtD3WOHvNf1vuQfk7X71R NJgJ3WMab7bIDLq6HlTv+s3ibG5xtgqXejTshjG71EedAYnjnZV4zsT/K7Rd9vGI2oaAIKyUTr1 uhGOLg0PT7CeUK9a48EB9MZZ4 X-Received: by 2002:adf:c6c9:0:b0:331:41c2:4f98 with SMTP id c9-20020adfc6c9000000b0033141c24f98mr7464104wrh.53.1699986457576; Tue, 14 Nov 2023 10:27:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFY61LsbNAuT6y46BF3pRKKrrw53mZ4Dy/kFrmcrVFB/EQ8pBeaCzTA9fgAaEoXr66foicSw== X-Received: by 2002:adf:c6c9:0:b0:331:41c2:4f98 with SMTP id c9-20020adfc6c9000000b0033141c24f98mr7464087wrh.53.1699986457127; Tue, 14 Nov 2023 10:27:37 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd? (p200300cbc73e890002d8c9f0f3fbd4fd.dip0.t-ipconnect.de. [2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd]) by smtp.gmail.com with ESMTPSA id i5-20020a5d4385000000b0032de6f95fb3sm8446944wrq.40.2023.11.14.10.27.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 10:27:36 -0800 (PST) Message-ID: <7c85bd39-8b34-4b09-b503-b0a2f2e58b88@redhat.com> Date: Tue, 14 Nov 2023 19:27:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] mm/memory_hotplug: introduce MEM_PHYS_ONLINE/OFFLINE memory notifiers Content-Language: en-US To: Sumanth Korikkar , linux-mm , Andrew Morton Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-5-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231114180238.1522782-5-sumanthk@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.11.23 19:02, Sumanth Korikkar wrote: > Add new memory notifiers to mimic the dynamic ACPI event triggered logic > for memory hotplug on platforms that do not generate such events. This > will be used to implement "memmap on memory" feature for s390 in a later > patch. > > Platforms such as x86 can support physical memory hotplug via ACPI. When > there is physical memory hotplug, ACPI event leads to the memory > addition with the following callchain: > acpi_memory_device_add() > -> acpi_memory_enable_device() > -> __add_memory() > > After this, the hotplugged memory is physically accessible, and altmap > support prepared, before the "memmap on memory" initialization in > memory_block_online() is called. > > On s390, memory hotplug works in a different way. The available hotplug > memory has to be defined upfront in the hypervisor, but it is made > physically accessible only when the user sets it online via sysfs, > currently in the MEM_GOING_ONLINE notifier. This requires calling > add_memory() during early memory detection, in order to get the sysfs > representation, but we cannot use "memmap on memory" altmap support at > this stage, w/o having it physically accessible. > > Since no ACPI or similar events are generated, there is no way to set up > altmap support, or even make the memory physically accessible at all, > before the "memmap on memory" initialization in memory_block_online(). > > The new MEM_PHYS_ONLINE notifier allows to work around this, by > providing a hook to make the memory physically accessible, and also call > __add_pages() with altmap support, early in memory_block_online(). > Similarly, the MEM_PHYS_OFFLINE notifier allows to make the memory > inaccessible and call __remove_pages(), at the end of > memory_block_offline(). > > Calling __add/remove_pages() requires mem_hotplug_lock, so move > mem_hotplug_begin/done() to include the new notifiers. > > All architectures ignore unknown memory notifiers, so this patch should > not introduce any functional changes. Sorry to say, no. No hacks please, and this is a hack for memory that has already been added to the system. If you want memory without an altmap to suddenly not have an altmap anymore, then look into removing and readding that memory, or some way to convert offline memory. But certainly not on the online/offline path triggered by sysfs. -- Cheers, David / dhildenb