From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37AF7293B5F for ; Mon, 16 Mar 2026 14:35:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671706; cv=none; b=qvnuBIls7gbF0p80a1Hly1f9uOQ8gXxEXBZcQ5ZO36aT8hNa9gUaiNMmeUZ9E3bm50udcO2VlRv3fS38r4D3AwRvjp7XiqKv3RkF4OhRuv3LJ2W8V1qjnycnv5Avq4WDYNWmJ4Mqwyfnp5QjhOG0NW7mzq8NDs834lC3PzDogHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671706; c=relaxed/simple; bh=RzcUKKThV24VYYhOUtSCqR8y1wrm+x+IfKPzNInqHu4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fyowNzCcyTwE9XD4OvrEHYT4wLYaFzZEyvh9iRwbee87D2pvynTUvbORumpgksKm4JKJrZIBxHNtKy/KpCo61YiMuP7+r4AwEdJMl+I6vmsY4rTgkY9k8FTKAVlEnlCL004S5QvZDMaPa31fjlbdgTHXQDIaWFuM4bSI6r1e1R0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fqBcGXJ9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=il/HCTXH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fqBcGXJ9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="il/HCTXH" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GBiaCx1066902 for ; Mon, 16 Mar 2026 14:35:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XBIUg40/M7vmcxFLi5vD+zxo1ud6+bCfvOq5RZgwjA4=; b=fqBcGXJ9G8NakXev 3B/lHvsfDxv2HxZP/QCxDBAixJsPxLBqEsVOQfVRxas+Fy053n0T1i6F+y47xVrC P1mefjk+BuLBtKYWC5Ynq24xxqe1H+ewGtfE2qjv0Ee33KvgmLwoscJrDRkvVyG6 1ysGs/b+YOm0WtsDT76fladma5rdPhHcGS8sQ7N3496H2kFr68+jgyemxONPekox 4YHEDXrxjpESlrCdEC6eBQYpKMiBB7E0DEmh7Kz0pPOGHvZJ55tYvHQ6T4nfpcpI 3PXIc76yBW0yVR0wUvk7bmK1zqA+nfp5KuRwZcl88wPmGxqW7OB1k2gVoxm8ZjyZ lWAbIA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw027e8kt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 14:35:04 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd8e89d19bso312546185a.2 for ; Mon, 16 Mar 2026 07:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773671703; x=1774276503; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XBIUg40/M7vmcxFLi5vD+zxo1ud6+bCfvOq5RZgwjA4=; b=il/HCTXHHj4ZxKimUs0JicgImHa+S5W3AhwcyLjTZNgRlvCl89OazbAE8ozAtYEFM0 qLseMGp51dLTmF/aUlFZsO588+/huRJl3GqC96FUX8lbdFtCWHjDDJPoBruqogOZnfXi tJyJpJyQBnoUTGOFjDt0XoXs5KIk22z0LFsrGTivU/IEE9tUWbfyzxhdzgEk301Q5UlL TQPQjjE847drdCpQjE/LNJKH4al2sEKo/ftZWif4JESTp7BJtAgGwLFjhlbuhWMY4Ab2 +GOlPbi0nrXBRK4EmpAvwV6L2Pn80Kq2boctTylNzGY/7CjZ79ibvAJi1W6/Xuecpooi qPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773671703; x=1774276503; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XBIUg40/M7vmcxFLi5vD+zxo1ud6+bCfvOq5RZgwjA4=; b=Lo5z9J6iM66Kr8LtV+kuRFaJ/ZGEy8pQ0nYSQPD5P6npLqEERuUVHBaWsaGPWmrwzP DDuGGrQk90iZSzOS5FBe73TK3zg+7wFfFViMbmtNtjCOFQbLuwlQ88v6J5E3m3TsksAg 4H8Rmw6xFGYpveTIYH9M+pQPVEa5qyFol1lC3QHmw/mp8ojGn6ePZ3e5ilT6Nq8B8xWU /c2badxbegl++5GRs+wl1z2ux0hmKQN/POi5xjkT9AR4uaiFafaqigUieV4I10iU7Y3J Tw/o18MWtuvtIjZlrbFUgEbr1NKNOQqvtZ6WYx/MGIjagIraQLmhugr/7djNWiFisZ8O lVTA== X-Forwarded-Encrypted: i=1; AJvYcCVWW2wCelp5LUjVY1wl/LCZblF9zah1EikvETIXsFTdoldp41eW6oXckk3ixgFnf9eV5Jv+pZGbGdyromw=@vger.kernel.org X-Gm-Message-State: AOJu0YxsxobcChSqDqHMuc6lJ+72+uYdH9/yk6LRxF3kvAnAXk71SNRG Z/wy1j+4iaGc09YjpQARkgkREPTmKiuYdg6W3KmNtvP8Fkft0zdTdA+qU9oX7U3S2PIfi4IeLKr cIGG2Lr7usIqWQhEbrMxiHy8SyfUQ2b95MLFNG1cnqGHyn2GqzpxBq1xxNOVUkejs7eA= X-Gm-Gg: ATEYQzxBEO9XO+bVvPZsRhrfaKe3PhfMFxQnuFR+jqHCB+Zxtzvapq6+ndkgHYnxukC hLFpByjXjnEfr7WIMuESgbM2a7gjGOXyspgLjzDdyPrV6jGkyCINpvUOTM8Tz7TPRbMXUNQcOKN sB3tB669lBbU8Uza7BFszmhJQL5cEkFIhS7b476YNjpKER96FDq1HfH0udFpEkVO1u+cqoSxiRG Ce0eZbmb+BNi81vzxvPvPHrtoItcIzIyZSWdKOMaW1O7TDDx/AB+fLN73Yk7y+MCgAXPxfFT4U2 h62NovipqwGwP2T4/j73VTnx+WC8OPJ8EBD6QyAsM29HoG12F3pGMSc+GIXTfuUPH5xiX3PMjsK TvG7ol9NeseffxbUK7f7zsxQ6G+pLTM0XjCD10zLD+eMdQAtPH8z5klPyVElVI3d0U6CJeu6e7+ 4/+xY= X-Received: by 2002:a05:620a:29d4:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8cdb5a7e0f1mr1248987485a.3.1773671703427; Mon, 16 Mar 2026 07:35:03 -0700 (PDT) X-Received: by 2002:a05:620a:29d4:b0:8c6:ca3d:4e0a with SMTP id af79cd13be357-8cdb5a7e0f1mr1248984385a.3.1773671702884; Mon, 16 Mar 2026 07:35:02 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66350d80771sm5027648a12.31.2026.03.16.07.34.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 07:35:02 -0700 (PDT) Message-ID: <7c862b46-1d8b-4c93-b675-20f735915bb3@oss.qualcomm.com> Date: Mon, 16 Mar 2026 15:34:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix GMEM_BASE for A650 To: rob.clark@oss.qualcomm.com Cc: Alexander Koskovich , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> <2938aa01-cc1b-4dd8-a4af-45ff8354a061@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 5QUp9HuPdu0_M-SCyeN9KWnV5oRNVKku X-Proofpoint-ORIG-GUID: 5QUp9HuPdu0_M-SCyeN9KWnV5oRNVKku X-Authority-Analysis: v=2.4 cv=AqXjHe9P c=1 sm=1 tr=0 ts=69b81518 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=5SlpSpXkIfRf2ii1CfEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDEwOCBTYWx0ZWRfX1zaAKtCRpYWl q2JjR0slosW2X/eJ81wfzsZR0z/VRYuTkEU4n3/cN7T4XG7R5DFYdpLnlHuwopXMKGG9nv2CfWf EgFashSPwuS281FTrpOC6u6J4tUuc/1qHnCa3wOKftakSNMu7KtCqzBy/4zV5g4YiJHkfVIaq9R ptPwU5zBlfk4arkJst4O/12wv/HKXgzhe2Le9fqVo1QaUE5YEAdH7i7kiIGrMryzYWbayE2dsWM Glqwsk09fl5J4mqey129jkquWKAH+qNs8Wv2UAqqeauFS9xgTLGsPV+lkzxHI+UU4EKxGk6LkCi pQ38BoeDZBykE7yPbvGNxStg9UCdUStIqdD5usOkqOkvAcm7VF1TqGcd0ANO/Tw9kK4HUuKs59d Bpzs9gvlaXHcSFlTEIgB3fnU0sayOIXN4F10KJ2ABJQL66ckfORP6GHqf6XJXjvWEWLeszWslLG VWNF7sYjERxiOA53FCQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160108 On 3/16/26 3:31 PM, Rob Clark wrote: > On Mon, Mar 16, 2026 at 2:22 AM Konrad Dybcio > wrote: >> >> On 3/14/26 5:14 AM, Alexander Koskovich wrote: >>> Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the >>> GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() >>> to family >= ADRENO_6XX_GEN4. >>> >>> This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report >>> an incorrect GMEM_BASE which results in severe rendering corruption. >>> >>> Update check to also include ADRENO_6XX_GEN3 to fix A650. >>> >>> Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") >> >> Hm, that commit also changed the value for A730 - Akhil/Rob, should >> that be changed back? > > No, it was incorrect before my patch. The only problem was the change > happened in a6xx_gen3, not a6xx_gen4. So this patch is correct. OK, thanks Reviewed-by: Konrad Dybcio Konrad