From: "stephane eranian" <eranian@googlemail.com>
To: "Andi Kleen" <andi@firstfloor.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Markus Metzger" <markus.t.metzger@intel.com>,
andi-suse@firstfloor.org, hpa@zytor.com,
linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
markus.t.metzger@gmail.com, suresh.b.siddha@intel.com,
roland@redhat.com, mtk.manpages@gmail.com,
juan.villacis@intel.com
Subject: Re: [patch 1/1] x86, ptrace: PEBS support
Date: Wed, 16 Apr 2008 10:51:57 +0200 [thread overview]
Message-ID: <7c86c4470804160151w75aaa1doaf98a46543ba03f9@mail.gmail.com> (raw)
In-Reply-To: <4805A798.7050004@firstfloor.org>
On Wed, Apr 16, 2008 at 9:15 AM, Andi Kleen <andi@firstfloor.org> wrote:
>
> > Should we skip the RLIMIT_MEMLOCK check if capable(CAP_IPC_LOCK)?
>
> FWIW I don't think we should. They are not really related.
>
That is true even though I see in mlock() that both are actually used.
I don't check against capabilities in perfmon, but I check RLIMIT_MEMLOCK
for the sampling buffer.
I see the capset()/capget() syscalls, however, I am still not clear as to how a
sysadmin could set up the capabilities for users via PAM or other
security interface.
>
> > It's a fairly large patch.
>
> The original version was much smaller -- a lot of the increase came out of
> review feedback for "more infrastructure" etc. I don't think you can blame
> Markus for that.
>
I believe the patch could potentially be broken into multiple pieces:
ds/bts, pebs, ptrace.
next prev parent reply other threads:[~2008-04-16 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 9:01 Markus Metzger
2008-04-16 0:35 ` Andrew Morton
2008-04-16 7:15 ` Andi Kleen
2008-04-16 8:51 ` stephane eranian [this message]
2008-04-16 14:47 ` Ingo Molnar
2008-04-16 22:59 ` stephane eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c86c4470804160151w75aaa1doaf98a46543ba03f9@mail.gmail.com \
--to=eranian@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=andi-suse@firstfloor.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=juan.villacis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=mtk.manpages@gmail.com \
--cc=roland@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®