From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Suraj Jaiswal <quic_jsuraj@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Prasad Sodagudi <psodagud@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>
Cc: kernel@quicinc.com
Subject: Re: [PATCH net-next v3 1/3] dt-bindings: net: qcom,ethqos: add binding doc for fault IRQ for sa8775p
Date: Fri, 24 Nov 2023 09:18:18 +0100 [thread overview]
Message-ID: <7c9135e0-da6e-4e1a-b673-af6c73d8ee45@linaro.org> (raw)
In-Reply-To: <ff458955a24c0cb4ba41158b8b53fbef00c8237d.1700737841.git.quic_jsuraj@quicinc.com>
On 23/11/2023 12:38, Suraj Jaiswal wrote:
> Add binding doc for fault IRQ. The fault IRQ will be
> trigger for ECC,DPP,FSM error.
>
> Signed-off-by: Suraj Jaiswal <quic_jsuraj@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 7bdb412a0185..e013cb51fb07 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -37,12 +37,14 @@ properties:
> items:
> - description: Combined signal for various interrupt events
> - description: The interrupt that occurs when Rx exits the LPI state
> + - description: The interrupt that occurs when HW fault occurs
Adding required items is breaking the ABI and introducing new dtbs_check
warnings. I don't see rationale for this in the commit msg.
I don't see any fixes for the warnings, either. I am quite picky on this
part, so to avoid wasting my time - are you 100% sure you do not
introduce any new warning?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-24 8:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 11:38 [PATCH net-next v3 0/3] Ethernet DWMAC5 fault IRQ support Suraj Jaiswal
2023-11-23 11:38 ` [PATCH net-next v3 1/3] dt-bindings: net: qcom,ethqos: add binding doc for fault IRQ for sa8775p Suraj Jaiswal
2023-11-23 11:44 ` Konrad Dybcio
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-23 12:04 ` Suraj Jaiswal
2023-11-23 12:36 ` Rob Herring
2023-11-24 8:18 ` Krzysztof Kozlowski [this message]
2023-11-24 11:39 ` Suraj Jaiswal
2023-11-23 11:38 ` [PATCH net-next v3 2/3] arm64: dts: qcom: sa8775p: enable Fault IRQ Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-24 8:19 ` Krzysztof Kozlowski
2023-11-24 8:20 ` Krzysztof Kozlowski
2023-11-24 15:23 ` kernel test robot
2023-11-23 11:38 ` [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support Suraj Jaiswal
2023-11-23 11:53 ` Suraj Jaiswal
2023-11-23 11:55 ` Konrad Dybcio
2023-11-23 14:34 ` Simon Horman
2023-11-23 20:02 ` Andrew Lunn
2023-11-24 13:19 ` kernel test robot
2023-11-24 14:39 ` kernel test robot
2023-11-27 20:08 ` Andrew Halaney
2023-11-23 11:53 ` [PATCH net-next v3 0/3] Ethernet DWMAC5 fault IRQ support Suraj Jaiswal
2023-11-23 11:57 ` Konrad Dybcio
2023-11-23 11:57 ` Konrad Dybcio
2023-11-23 19:54 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c9135e0-da6e-4e1a-b673-af6c73d8ee45@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=psodagud@quicinc.com \
--cc=quic_jsuraj@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®