From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923DFC282CE for ; Tue, 9 Apr 2019 10:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6028220818 for ; Tue, 9 Apr 2019 10:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="blV4sA8E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbfDIKgU (ORCPT ); Tue, 9 Apr 2019 06:36:20 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:45641 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfDIKgR (ORCPT ); Tue, 9 Apr 2019 06:36:17 -0400 Received: by mail-lf1-f68.google.com with SMTP id t15so8042623lfl.12 for ; Tue, 09 Apr 2019 03:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UAw9QiYDP8ZLR6rjqbOsp057BTBy4N/6x7Ni502ccbM=; b=blV4sA8E2tZ0+Gj2ekGzQGWHuPSgSyxG/zW1xetjm/mlCakJ88/z/wh7ZMu2CFOMGq av1Ho5mN+m1qZdyL8f5TcaoEJCnX8nWB8Zutaw/70hQNW1ATZ1sxOpnizUVQeixkshH6 NayXs8IKKbUm8gPWpbFqKNecbz0gJUdC1F9pj4RN7vsj/t6ilVlEcTwHo9AfaViIrh7u KUxiS7zztefUqo7wSJsLAk+gyIfbguaDMpU5JCuTCF8I4OgCfUUdtAogKllDkey6k5XI ZQIkXilwB7kZ09pJ/7iqs2aUVaAt8F/wmTjMd25RyjcHvBBedSbysxpWKei1U7NV4StF T2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UAw9QiYDP8ZLR6rjqbOsp057BTBy4N/6x7Ni502ccbM=; b=RSlJCRYKg3bo090J5OIAyzIHe+pb02L+GiZeirmVO9XZBbRmwIKBU8/hZI2PhTo3CS JhiljBt6uWneEqRcfAqWdrd1i4yeFtNcOWRzFc6RrB5nZBdQJHs0GFG1XwzP6THQHBLe soWfiA6y3A99vBcDWxIPLkdrRanMuiw9tObkK6Bsl6Uf+qxjbL8KU5C0TektRNPnU0Jg pLYXaE14G/IPRRrKHgTAxikwOQcTNqKT8IKbY3CFcRxWYKEt0pyxgQ6sHYES8o+fPx5h aL1G+LGDWPYULayM22uCFXoHkNUOHDOwOHIS87hPs2+DeQho7DGGRJ07OeMBaCpEMglm SXbg== X-Gm-Message-State: APjAAAVGaFvaVmAWILgO2Mdf8OIOws+5c6s6YWCs7EWmZUIuMwIBtCOy zWHmoHv2DH+9i723P4JVtV0RuIkBWzw= X-Google-Smtp-Source: APXvYqy2mabD3xIsJEgr4+SjQt0GXR4BE6NUZHwOv5sQiYKZrh6xm3WLuAKC417d7KZv+WEXZl0rxw== X-Received: by 2002:a19:7503:: with SMTP id y3mr19059196lfe.83.1554806175295; Tue, 09 Apr 2019 03:36:15 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.87.225]) by smtp.gmail.com with ESMTPSA id q5sm5129872lff.30.2019.04.09.03.36.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 03:36:14 -0700 (PDT) Subject: Re: [PATCH v3 2/6] usb: ohci-da8xx: let the regulator framework keep track of use count To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski References: <20190409082855.15373-1-brgl@bgdev.pl> <20190409082855.15373-3-brgl@bgdev.pl> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <7c968006-0cdc-d4cf-622f-9cda52490aa1@cogentembedded.com> Date: Tue, 9 Apr 2019 13:36:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190409082855.15373-3-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/2019 11:28 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no reason to have a separate variable to keep track of the > regulator state. The regulator core already does that. Remove > reg_enabled from struct da8xx_ohci_hcd. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Alan Stern > --- > drivers/usb/host/ohci-da8xx.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c > index ca8a94f15ac0..9c6d1f03b871 100644 > --- a/drivers/usb/host/ohci-da8xx.c > +++ b/drivers/usb/host/ohci-da8xx.c [...] > @@ -100,21 +99,18 @@ static int ohci_da8xx_set_power(struct usb_hcd *hcd, int on) > if (!da8xx_ohci->vbus_reg) > return 0; > > - if (on && !da8xx_ohci->reg_enabled) { > + if (on) { > ret = regulator_enable(da8xx_ohci->vbus_reg); > if (ret) { > dev_err(dev, "Failed to enable regulator: %d\n", ret); > return ret; > } > - da8xx_ohci->reg_enabled = 1; > - > - } else if (!on && da8xx_ohci->reg_enabled) { > + } else if (!on) { This can be reduced to simple *else* now. > ret = regulator_disable(da8xx_ohci->vbus_reg); > if (ret) { > dev_err(dev, "Failed to disable regulator: %d\n", ret); > return ret; > } > - da8xx_ohci->reg_enabled = 0; > } > > return 0; MBR, Sergei