From: Helge Deller <deller@gmx.de>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] linux/vt_buffer.h: allow either builtin or modular for macros
Date: Sat, 22 Apr 2023 11:36:35 +0200 [thread overview]
Message-ID: <7ca1b3e1-39ff-50b8-caa5-12ae40357f22@gmx.de> (raw)
In-Reply-To: <20230329021529.16188-1-rdunlap@infradead.org>
On 3/29/23 04:15, Randy Dunlap wrote:
> Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m.
> This allows the ARCH macros to be the only ones defined.
>
> In file included from ../drivers/video/console/mdacon.c:37:
> ../arch/alpha/include/asm/vga.h:17:40: error: expected identifier or '(' before 'volatile'
> 17 | static inline void scr_writew(u16 val, volatile u16 *addr)
> | ^~~~~~~~
> ../include/linux/vt_buffer.h:24:34: note: in definition of macro 'scr_writew'
> 24 | #define scr_writew(val, addr) (*(addr) = (val))
> | ^~~~
> ../include/linux/vt_buffer.h:24:40: error: expected ')' before '=' token
> 24 | #define scr_writew(val, addr) (*(addr) = (val))
> | ^
> ../arch/alpha/include/asm/vga.h:17:20: note: in expansion of macro 'scr_writew'
> 17 | static inline void scr_writew(u16 val, volatile u16 *addr)
> | ^~~~~~~~~~
> ../arch/alpha/include/asm/vga.h:25:29: error: expected identifier or '(' before 'volatile'
> 25 | static inline u16 scr_readw(volatile const u16 *addr)
> | ^~~~~~~~
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-fbdev@vger.kernel.org
applied to fbdev git tree.
Thanks!
Helge
> ---
> include/linux/vt_buffer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/include/linux/vt_buffer.h b/include/linux/vt_buffer.h
> --- a/include/linux/vt_buffer.h
> +++ b/include/linux/vt_buffer.h
> @@ -16,7 +16,7 @@
>
> #include <linux/string.h>
>
> -#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_MDA_CONSOLE)
> +#if IS_ENABLED(CONFIG_VGA_CONSOLE) || IS_ENABLED(CONFIG_MDA_CONSOLE)
> #include <asm/vga.h>
> #endif
>
prev parent reply other threads:[~2023-04-22 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 2:15 Randy Dunlap
2023-04-22 9:36 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ca1b3e1-39ff-50b8-caa5-12ae40357f22@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®