mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2] dt-bindings: nvmem: layouts: add fixed-layout
Date: Fri, 10 Mar 2023 07:51:12 +0100	[thread overview]
Message-ID: <7ca3ab00-5146-7d78-aa56-9c412fd415cb@gmail.com> (raw)
In-Reply-To: <8478b23e903d5236500ef2f6f7edb88f@walle.cc>

On 9.03.2023 14:07, Michael Walle wrote:
> Am 2023-03-09 12:39, schrieb Rafał Miłecki:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> With the introduction of NVMEM layouts we should prefer and support
>> describing all NVMEM devices content in the "nvmem-layout" node. That
>> inludes using it for fixed NVMEM cells (those with hardcoded offset &
>> size).
>>
>> This seems to be cleaner design and more explicit.
>>
>> Introduce a binding allowing fixed NVMEM cells as a type of layout. To
>> avoid code duplication put shared part in the fixed-cell.yaml.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> 
> I don't feel comfortable to add an acked-by or reviewed-by here
> because I don't do much with dt-bindings myself, but this looks
> good to me.

Thank you!


>  From a device tree binding POV, could there be a
> 
> nvmem-layout@0 {
>    reg = <0>;
>    compatible = "layout1";
> };
> 
> nvmem-layout@1000 {
>    reg = <1000>;
>    compatible = "layout2";
> };
> 
> for partitioned eeproms for example?

Maybe. Could you send a patch adding such binding with a proper
explanation what devices need it, please? It's out of scope of this
patch.

      reply	other threads:[~2023-03-10  6:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 11:39 Rafał Miłecki
2023-03-09 13:07 ` Michael Walle
2023-03-10  6:51   ` Rafał Miłecki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ca3ab00-5146-7d78-aa56-9c412fd415cb@gmail.com \
    --to=zajec5@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®