From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96BFF3321BF for ; Fri, 17 Apr 2026 07:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776410602; cv=none; b=QkLWb7oOsthQxHbIRPaaKvrdpuyUErZC4Nb1zPB7SoCXiv7xBc3xYmk4AZ8CQCELvQlbyxQh65ESBcU1bpc/N9N5X5Ze71cWFW8ac/4elEA+hnJldi5bzOPuZqubKeAfAdpCdcCsYobXh7lvHvQKhqPyb7Kh8BFDPEH2/JI/hRY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776410602; c=relaxed/simple; bh=zAO4yiZIspj/B9kX9m52ii9BBdRAiIgRVZAlZgVeJ64=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A1VNwZdyaugWxm/lh5TF8Ba7Xw7B+B+r9+bU0FraPZ4KNtt9Dip3HMk2Lkba92vbgqmUHUZx9XG7E9DvNvEs07Vxxd1kQl5Ax5Z41PO+ZaeXjMpCez0pDgNsy1OSwbnVKCtXbyOOsGO6XFKUJNX+MAqry2wwe5D1G7K3GmoJrxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PSuI4xNK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jD+6mpzO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PSuI4xNK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jD+6mpzO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63H185qR667584 for ; Fri, 17 Apr 2026 07:23:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= njJoLDDTMciPrudwZKOk2MghYIVD6S5mzTyqW4fpstw=; b=PSuI4xNKAwKmlDIb cvFoOa4IT4KA0EEWhdZR6Cj3HvFkW5Ap25EcMghv82WI0qTsE8sf8F9fRq0tR4p/ FC3T+wy7MN6cEQs+fY+PjACYAim8+XBQ5HJexM2WvmmWUxcFO2ves81nm/VcB2Fa FBpb3xoLO6CjRaAKg7kc5/oPeGyTuFYyVwmWptLPj0q0Ko5asUPywPFn+bcJG9rp sjKdWUWvHYTT2aoIzPZcXjtiwjX4tHbtSDf3ETfRbZFM79/Y0u8L1w5hDHgwh8CV 6IUcBD2N2FJGwExtqzLfNWBneUAZ4f2qls7Hj4nazcYnFUy4kSYxaf8fxCqdaMHp iHS+ww== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dkaxcs09a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Apr 2026 07:23:20 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b249541063so3739555ad.3 for ; Fri, 17 Apr 2026 00:23:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776410599; x=1777015399; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=njJoLDDTMciPrudwZKOk2MghYIVD6S5mzTyqW4fpstw=; b=jD+6mpzOLybvcscxHooDn5EJlq5YvjyeRlMwOk+796bXr4W0v4mvoDcs9+PdJQDi9S HlaAYwiJxT/XslSmkt6ZbJc7drSB09fTtSkqFloZOOOeiyCHBvkPWDqs9h99SzaEZKIq 6+QEFE+9qAe4U9aE4MCN1U3GaPO0ffOHUhINYr24hcAVnmh3TTWwff44vmO9pcPj0sVZ hFd+WPnS4FJaNMrB9sjg5DTBWhtYhdnrbGwvoKm4i4JlIMG7285cv94xyYFJfPHiedcR e4fFVdHSsOZ3djJs0W/S3nj0BslkRI6Wkjpi4K2fSLkX+DJhtUSLFtGwjE+idM6asS+Y +gwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776410599; x=1777015399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=njJoLDDTMciPrudwZKOk2MghYIVD6S5mzTyqW4fpstw=; b=Ymr1rCtwSu+vQmO8GOGkgab1lBwqRlyoifr3v2roHy7s7SmTDEExqUoReHC+Y+tRjH zOd7+LJgjCi7PoP2Ktp8yxVfFYaE07DPElmdJCWdmxwTAJAarIF/uKdrAqm+8lIHBwYm H5941fPfFdeAvbFs9HIcCEKm3qmLUQJwvhZLdA1bVgYmAkjbsMHG5RFfS07dLh4tl+5k pI0lXA1u458KPoWtwNbgtgNEOaYOAaCpUAvNSXydTl1lJeqKvM6QldTDG7ITHWLrd2qv EtCsyjDEfEMI5vhTAWKFKu1BKBgxi+zhCl0jWDOdc9DcU1nVsVvehlb+Su0VOsZ98MPv Q5cQ== X-Forwarded-Encrypted: i=1; AFNElJ/Ac73H/CD/Q4YDBL7CHf8k4COIWQr/Mo5GFfT29ducUzdI3eu+8TZ2EERblIQi4FSKqL+nChX4kMoCaog=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9GxHyLoFvDA8T4UzMT4A31rTyQcG0LjYp0Z6NltXUUOblg19n L+z8Ly1baBRDJYwZroF8Z5IWugCXz3UFYbrIe7AWUe9OXKp82dMKcoN3E+5FelHjM/+R2g2unAA S8TowpDLCP4zyIR6XzSMwiA3fpODAEUMxyybkrIFZxQ8+Hme8ObRor8dOuY0JQu8Mr+I= X-Gm-Gg: AeBDieu/EkbcYYody+UIwNnMtQpn1mH7UHmE3m6yZ25umCVSsJ9L19vIZtUlNDJpc05 0/pTtf4XtIOdZ9hJtua7sGs8W5Blyc/qGVgg6axyus1tqt4tGhIlbP1LZaGj4RFoOkxlhsF/00f KvhvqvBJdvRlsW1FFvVPecdsAo2KEh79746Z+iMtfwFbsc8eaDRTTRvLLXei2kVx/INhYdOx9xL gM6d7ibOyhSHInCcDz6S1Uuo56BiVPJkKUpVFePAcECQzaY67sM0DRtsw6petYNumoEiHrrQiZV DFub3thP9UA28O4xblGl/9iaofDAYAJi2gmnWxP/W00A/lD5Io6LOK3k3FAlJ1fY9dgBUQPQ+ug fvaeZOT5JiECJqE8BkCrYm3g3UaHKxgOr7ab8bR7VJTbRRNCFjul+UF/jpAi1kz03 X-Received: by 2002:a17:902:d30b:b0:2b0:673a:7c90 with SMTP id d9443c01a7336-2b5f9f50051mr11957195ad.28.1776410599562; Fri, 17 Apr 2026 00:23:19 -0700 (PDT) X-Received: by 2002:a17:902:d30b:b0:2b0:673a:7c90 with SMTP id d9443c01a7336-2b5f9f50051mr11956935ad.28.1776410599091; Fri, 17 Apr 2026 00:23:19 -0700 (PDT) Received: from [10.0.0.3] ([106.222.231.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab4cc47sm10964765ad.82.2026.04.17.00.23.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Apr 2026 00:23:18 -0700 (PDT) Message-ID: <7ca67466-51d7-0003-47c6-9d0e6518745e@oss.qualcomm.com> Date: Fri, 17 Apr 2026 12:53:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH RFC 3/7] media: qcom: iris: add helpers for 8bit and 10bit formats Content-Language: en-US To: Neil Armstrong , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org> <20260408-topic-sm8x50-iris-10bit-decoding-v1-3-428c1ec2e3f3@linaro.org> From: Dikshita Agarwal In-Reply-To: <20260408-topic-sm8x50-iris-10bit-decoding-v1-3-428c1ec2e3f3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JcqMa0KV c=1 sm=1 tr=0 ts=69e1dfe8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=llJV7PLoYzplBNayqe3woA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8 a=o9wjZkula7dpSB38lCoA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE3MDA3MiBTYWx0ZWRfXwt4mYb8AkT6Y ZwPqlovAIXa2gWwv75FAOKO75LGyd4R6fIGOuqy4sm/vDvDixaUxIDvUwHQxSIsXOspNGpoLi0s 9rn/BV7zSBlm9i4MF/CpDgeQoy6kR7unLXn4DSTEDRd0okMwfYKo9J4SeQo6dTtG06gF7B9OWks jtv4XTt0Bth8f0OJd7/teKfZn/dffzGQnTKPIL0x1/eogeC6jLgPjB4AtGt1G7xylyuQ31wrma6 ItAyt7Juiyvku5K+nBKk6H0PvibUt5bGF79h8Bbed9IFKy+rreHiptAKB0PDbUBsVY596WLiMha LAiPJ3Ct7izhmQK/KUDGUsbneS/jxJriMk4SVK5mcVcEi9codeKrfbjMmG8b/LfU/jRzJo3OnJq 81vMGDe3kU+Y/zWfwTXEqkazjrM+KQlSFuQAUaiCw5iENtYTx2K1IT7/B95DR6JpeN6iNJEc7oi 2jEW1PRXz9zHMkeDU5w== X-Proofpoint-GUID: c1FmWrXe-UvhGxnCnxjRMzlodUX7xcTc X-Proofpoint-ORIG-GUID: c1FmWrXe-UvhGxnCnxjRMzlodUX7xcTc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170072 On 4/8/2026 10:13 PM, Neil Armstrong wrote: > To simplify code checking for pixel formats, add helpers to > check for 8bit and 10bit formats. > > Signed-off-by: Neil Armstrong > --- > drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++ > drivers/media/platform/qcom/iris/iris_utils.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c > index 26f51a0ccd04..c75dcb8e671e 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.c > +++ b/drivers/media/platform/qcom/iris/iris_utils.c > @@ -40,6 +40,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst) > inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC10C; > } > > +bool iris_fmt_is_8bit(__u32 pixelformat) > +{ > + return pixelformat == V4L2_PIX_FMT_NV12 || > + pixelformat == V4L2_PIX_FMT_QC08C; > +} > + > +bool iris_fmt_is_10bit(__u32 pixelformat) > +{ > + return pixelformat == V4L2_PIX_FMT_P010 || > + pixelformat == V4L2_PIX_FMT_QC10C; > +} A similar check is required in the current first patch of the series. So you can move this patch earlier in the series? Thanks, Dikshita