From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792500285; b=0q1ABmTmzMfNzRosN0JQVmuph3CLvbaZ3mNIVJhgiuiVdHiEWuzaf725TDfdxrPO8U6m A7rHDCG60EeHqLpRAGdVAA7RZ19fbhj9YU/m8MAMWCqSWOcBMERDmFFvfqyCQ4ipnBrRH hm68gMtehyJrFfLugw1VWwU3hO5UhvvnnD1qoPUzM+Te5R4D3wZq3Bn5WFqaSDwpqHUWp NYgFiipVw3EdmThKerAI3gZa9sbvYm+XccDFUSo+k2CpYLfNgF4daFOElljfHFxQSFo4D NwwbbLt88yPYOGmzZ2D1vD2KNKOnpIC+Czzx3jPzQrDGO83wYJRAU9xtryeZ1DoIHXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792500285; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Details-Enc: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=VYAsIZfOfOOdrWKotexzjBSPJizPU25cltjgjHnE40g=; b=UkzIWQrR8+Kp0tgQaPygKETFjotrxERI8jIG4zdbV/egoqqmN+jwlC1E5Ff/uzVwxGN0 jxjc/YsldHfhnLJBrdYlt9KUkQGdNeFGlr4X950XDAL+tCLnfJV55vRSjYR4K/BDHCom0 DcU4T/PmBtCOQKnL50bswZwA31231L5ZENKPfRmHMWwIQ1p74dIubfqXgVd7xm6yw2RTc Z3C2qQIQewENrmljC4XpcRwgsiwwnygvLwDGAS1BucHcYu64zmbf3eYNrcv6SD3e7EQVk p10frLHwLN4VUZdEaRIl4Zd3MF56JMw717HL/ni9J+GqonLldSwjfEwK5m0uyR0Jtdw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=KPgguQ0w; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=g2Fog2h+; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7512E606A319 for ; Tue, 20 Oct 2026 12:44:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7512E606A319 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=KPgguQ0w; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=g2Fog2h+ Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69KAwtgU1929062 for ; Tue, 20 Oct 2026 12:44:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VYAsIZfOfOOdrWKotexzjBSPJizPU25cltjgjHnE40g=; b=KPgguQ0wbKjaowTM T2JqPto0HnRXnD2+amMCpJjuNJNdjRdi+dkg2CLG87xqKP0lO8malGNdtS11Q6nu MsMUlpsnXJLm4kRK9Sj6IYrAtKqLf/KR09qv+ZsE0b19TTWwBPZ6xvU3V/0rILoN AzKmRNsow9hWhZccvM3s26jcZjGgGmbk3bogUwQ7emfqFFzXJvdZ1QPVfeSweFOa SkBqpqhIpZXQTxQc68ZYXllq85H5B0q7/3gB0T3oiFZIsq0qIQilpIM23nTne6UL phh7/cN5/zTHFbZk71xbvOCVsklIKwLigvo6wNEpHSpwqfXoLgvpkX7nODnsKux0 NFh16g== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5ntdka-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 12:44:39 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93f13c143c8so597025085a.3 for ; Tue, 20 Oct 2026 05:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792500279; x=1793105079; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VYAsIZfOfOOdrWKotexzjBSPJizPU25cltjgjHnE40g=; b=g2Fog2h+SzjdMLQYXVDkHJ0m9WmId2+O+ou7+iNhFxX1yKvVMrWgvwMNlAlUKg6rSV 3GxMrCuTZoRQzP9XfjrqJ8vta6s3ysrd4oRfva5w5hQOb8EAJ4/qWZaoEyKZiiJWPlke /XlcP3lbqGwKScaTf9Ix/vbhJodDQ2MmMcSGfWuSRP0gTAl991FNs+sDLd5Q19rLmoe2 J8SVwZyIRFkMpmEAS+8pHQD/FRjipT9bFX10oj1I+E+MmDpsUUC3LygmaLMpCx95oJjZ yMXYDsoJx/CBV0M0wmHQMShHcy9z2rHQexClp1IMi5C9GFRWKDnD+iNhPEfwra+zz9u9 fBXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792500279; x=1793105079; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VYAsIZfOfOOdrWKotexzjBSPJizPU25cltjgjHnE40g=; b=tXsDB0iH+7UEBNrj/T4Z7fWaKq0af7B7N46W8hMPeW34tyK7HuwQSLDfnEZVoM93pL RLf/swVt0P5t4rBaunIXUev5YKDUQkhr3sLpbQHsoJLyL/3RzLyT4804OZjfK5yIPMgH b+HQP1DOaw5hjeRO3DmrrsqGJ60t5Ur4kyDy7P4ZjLs5WceapEorhQ9LkD70n5wv5NhK MMiDqfZKc9Pd9oK6jWk449S+E/OygqAyr/xmtU3lBiHH03u6sv0Zi8eAcia6jgukR6Ci Mv4c/wGGuODMk1oLOAOC1ivQOKrdQD0KjAJBiraWVO3u0iq+75APqB8YW0zwMXu0EMWW IQkw== X-Forwarded-Encrypted: i=1; AKwUvBya9wrIB0F5omPJGM2cO7P1Qeb04qiZhw3nH4GFTONLHMhC7GauXiPZeYr9ySY/7mCU354WJI007uVgu9I=@vger.kernel.org X-Gm-Message-State: AFq9FYIrRpl+kFaXyxwkKFd5ubK6fMy3iqqlhPJ2PLPNrfEmoj8xrIqP 4LnyGBFkiwCGSB5DT3kV7ZfOXQaRWJmf34ycUxlfirpq0cdlXc0NosLz/hmV9Dj6TjuqR3a05b5 003/iE/S4OxKU5vIIyk2JIBtEmAMF/E+xFXdRB45EqGKLxGqv87X1WwzODuS6SqWrh9U= X-Gm-Gg: AYBFou17WMh2WTQJRvodKnrXQ+J6W+OcBRwfhjiX2HUc6O4m3K0MTwb9XBJFlH/LDdz 4GOaON60My4DsTzQrvwTDSAJVUTkhy4AOfFLNblr6B40NYzVmvzV015jbzvCo6/+XzBjkzPpVan 7/CJ3FIUiptJb8nyAhIUSTQk77vZk2QngG583icjsInfpfiY0p0S4TwjOGhPf5qc7xCAs4XeyFC K9gAMesCCymnr9Fn7Dw+zrhDkw+mjRxss57Yur6fcBqm7s/CeswgrdCOyly5+0L8xdKLaDZt7ZS AVv4JuThnItTNEi8e3PBw6NlMT91TMqh4S1Onj7/z5O7xlLBX+c/kegpF8DC09778wNQv+cJjNe uoerTJtIq99z4wbauQ84EO0iPW+6JzZo= X-Received: by 2002:a05:620a:31a7:b0:93a:1048:7d2f with SMTP id af79cd13be357-93f29d307e5mr1871424285a.41.1792500278791; Tue, 20 Oct 2026 05:44:38 -0700 (PDT) X-Received: by 2002:a05:620a:31a7:b0:93a:1048:7d2f with SMTP id af79cd13be357-93f29d307e5mr1871420285a.41.1792500278289; Tue, 20 Oct 2026 05:44:38 -0700 (PDT) Received: from [192.168.1.73] ([92.247.57.178]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e1d82dec7sm5868592f8f.46.2026.10.20.05.44.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Oct 2026 05:44:37 -0700 (PDT) Message-ID: <7ca815b3-4712-42e4-996d-4a1e53cad492@oss.qualcomm.com> Date: Tue, 20 Oct 2026 15:44:34 +0300 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: clock: qcom,camcc-sm8250: add interconnect provider To: Krzysztof Kozlowski Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Jonathan Marek , Bryan O'Donoghue , Dmitry Baryshkov , Konrad Dybcio , Gjorgji Rosikopulos , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261016170701.1504338-1-atanas.filipov@oss.qualcomm.com> <20261016170701.1504338-2-atanas.filipov@oss.qualcomm.com> <20261020-bloodhound-of-remarkable-debate-11afe3@quoll> Content-Language: en-US From: Atanas Filipov In-Reply-To: <20261020-bloodhound-of-remarkable-debate-11afe3@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfX6KHSJRvxIhDL 70czk7+0jMww+2YJzVnajWKjBTnQgdL2695pKvr5o6YiGs32b2n3/RZYSFPDYibFgfRtuVjVjMY N5nqnpp3Jywo42NSVhJ/I7RFdGXAslw= X-Proofpoint-GUID: aMipMctUuOoPkBEfgRT9ehvJL1wC1kQb X-Proofpoint-ORIG-GUID: aMipMctUuOoPkBEfgRT9ehvJL1wC1kQb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDA1MCBTYWx0ZWRfX7Ct72RjnnuCU nvar+w9tpnYl0Iry+/GujGN3XA2VlkKP2D16QzbXet0Z2FGXso4XcCQqvq0FJ2DlNIapTrdKp7g AejuWOoc7lA4Rv4FNpZPQTf0iH6TU8l22pTAwGzdePMQmskyQrCy2rOGDGHDomYb41sRvLPRSs7 hSkq+9kshFgvovBtSAJERRu72V0igwQvRGe6MfVeluaQWsMylFhbuQyd5FiHRcFWw2Eg/80Un9S aqhae5gO4vUMQbZMn7leZ9fXy26NXHZVfDXmUEAok5XZeCz3RhVD0rAKpe6iwZYrOpMB538hKUf 9KoMeXEgjLN7cSxeQmq1+Rsy747ODi85Ryo/QA9KoEVzDWBPJpC81W7I5jHqoOEF4czokti3Paj M9eUVSU8jFcK3IVPOe3WG+C6DKjY9Myx9ynhCWOEyDY4SOUMj8NWYI8PEhbVvn0+PMRh6enbXDO HNKbkdmO8VdyCuRsJzg== X-Authority-Analysis: v=2.4 cv=TcsDJhQh c=1 sm=1 tr=0 ts=6ad76237 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ybD9qRDIDfZaXNPQ7Ca20A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=YZ1k_EG-GQ4t5jaSdRAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200050 On 10/20/2026 10:12 AM, Krzysztof Kozlowski wrote: > On Fri, Oct 16, 2026 at 08:06:59PM +0300, Atanas Filipov wrote: >> CAM_CC_CAMNOC_AXI_CLK is shared by several camera blocks. Setting its > > Clock is not an interconnect, although AXI suggests this could be > something with bus, but it seems you solve driver problem with > interconnect description. > Agreed, the problem is in the drivers. Today each CAMSS VFE calls clk_set_rate() on camnoc_axi based on its own load only. The last caller wins, and the rate is never lowered after streaming stops. > If you only need to solve "last writer" problem, why not fixing the > clock framework to accept the votes? Otherwise this should have > description why it is an interconnect. > > Best regards, > Krzysztof I checked clk_set_min_rate() and clk_set_rate_range(). The clock core takes the highest minimum of all users, but when a user drops its request, the core only clamps the last requested rate to the new range. The RCG keeps that rate and does not go to the lowest allowed one, so the clock stays high. Fixing this needs a change in the clock core. icc-clk already does this: the interconnect core aggregates the requests and icc-clk is the only one that sets the clock rate. The camnoc AXI clock drives the camera NoC, the bus between the camera blocks and the MMSS NoC, so a bandwidth request matches the hardware. gcc-ipq9574 uses icc-clk for its NoC clocks in the same way. Which direction do you prefer? If icc-clk stays, I will add this explanation to the commit message in v4. Best regards, Atanas