mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Franziska Naepelt <franziska.naepelt@googlemail.com>,
	linux-staging@lists.linux.dev
Cc: linux-kernel@vger.kernel.org, eperi1024@gmail.com,
	hdegoede@redhat.com, quic_vjakkam@quicinc.com,
	johannes.berg@intel.com, tegongkang@gmail.com,
	gregkh@linuxfoundation.org,
	Franziska Naepelt <franziska.naepelt@gmail.com>
Subject: Re: [PATCH v3 0/3] Fix some checkpatch issues
Date: Mon, 26 Jun 2023 19:09:44 +0200	[thread overview]
Message-ID: <7caa96fb-4fb6-fb87-5d0c-fa6985fa127b@gmail.com> (raw)
In-Reply-To: <20230625155632.32403-1-franziska.naepelt@gmail.com>

On 6/25/23 17:56, Franziska Naepelt wrote:
> This is a series of patches to fix some trivial checkpatch issues. Not all
> issues have been fixed. I intend to submit another series to fix more stuff.
> 
> Testing:
> 
> ---
> v3: Series to contain only remaining patches.
> 
> Franziska Naepelt (3):
>    staging: rtl8723bs: Fix space issues
>    staging: rtl8723bs: Fix alignment open parenthesis
>    staging: rtl8723bs: Fix remaining blank line issue
> 
>   .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 164 +++++++++---------
>   1 file changed, 85 insertions(+), 79 deletions(-)
> 
> --
> 2.39.2 (Apple Git-143)
> 
> 

checkpatch prints the following warning:
WARNING: From:/Signed-off-by: email address mismatch: 'From: Franziska 
Naepelt <franziska.naepelt@googlemail.com>' != 'Signed-off-by: Franziska 
Naepelt <franziska.naepelt@gmail.com>'

I propose you change the git email matching the one that you use to send.

When testing you can compile the driver with this command:
make -C . M=drivers/staging/rtl8723bs
Typically a compile of the entire kernel is not required.

Please use the subsystem and driver also for the Subject line of the 
cover letter.

Bye Philipp

  parent reply	other threads:[~2023-06-26 17:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-25 15:56 Franziska Naepelt
2023-06-25 15:59 ` [PATCH v3 1/3] staging: rtl8723bs: Fix space issues Franziska Naepelt
2023-06-25 16:00 ` [PATCH v3 2/3] staging: rtl8723bs: Fix alignment open parenthesis Franziska Naepelt
2023-06-25 16:00 ` [PATCH v3 3/3] staging: rtl8723bs: Fix remaining blank line issue Franziska Naepelt
2023-06-25 16:02 ` [PATCH v3 0/3] Fix some checkpatch issues Franziska Näpelt
2023-06-26 17:09 ` Philipp Hortmann [this message]
2023-06-28 16:38   ` Franziska Näpelt
2023-06-28 20:17     ` Philipp Hortmann
2023-06-29  7:40     ` Dan Carpenter
2023-07-01 10:35       ` Franziska Näpelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7caa96fb-4fb6-fb87-5d0c-fa6985fa127b@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=eperi1024@gmail.com \
    --cc=franziska.naepelt@gmail.com \
    --cc=franziska.naepelt@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=quic_vjakkam@quicinc.com \
    --cc=tegongkang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome