From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932554AbdJJXXk (ORCPT ); Tue, 10 Oct 2017 19:23:40 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37192 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932478AbdJJXXj (ORCPT ); Tue, 10 Oct 2017 19:23:39 -0400 Subject: Re: [PATCH] tracing/xen: Hide events that are not used when X86_PAE is not defined To: Steven Rostedt , LKML References: <20171010191256.3d6d72cb@gandalf.local.home> Cc: Ingo Molnar , Juergen Gross , "Kirill A. Shutemov" , Jeremy Linton From: Boris Ostrovsky Message-ID: <7caeb51a-9fd0-1a5e-83eb-08b85ba93e9b@oracle.com> Date: Tue, 10 Oct 2017 19:25:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171010191256.3d6d72cb@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/10/2017 07:12 PM, Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > TRACE_EVENTS() take up memory. If they are defined but not used, then > they simply waste space. If their use case is behind a define, then the > trace events should be as well. > > The trace events xen_mmu_set_pte_atomic, xen_mmu_pte_clear, and > xen_mmu_pmd_clear are not used when CONFIG_X86_PAE is not defined. > > Signed-off-by: Steven Rostedt (VMware) Reviewed-by: Boris Ostrovsky