mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: weibu@redadmin.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner
Date: Tue, 09 Sep 2025 14:36:00 +0900	[thread overview]
Message-ID: <7cba51d1668a9efaacd59b1bb64e32b3@redadmin.org> (raw)
In-Reply-To: <2025090917-tribute-dividers-abd6@gregkh>

Hi Greg,

Thanks for your feedback. You were right — I had mixed two changes in 
one patch.
I’ve now split them and resent as v2:
   [PATCH v2 1/2] simplify copyright banner
   [PATCH v2 2/2] fix double space in PwrState parameter

Sorry for the noise, and thank you for your review.

Best regards,
Akiyoshi Kurita

On 2025-09-09 13:43, Greg KH wrote:
> On Tue, Sep 09, 2025 at 12:58:04PM +0900, Akiyoshi Kurita wrote:
>> Replace the banner-style copyright comment with a single-line comment.
>> No functional changes.
>> 
>> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
>> ---
>>  drivers/staging/rtl8723bs/include/rtw_efuse.h | 9 +++------
>>  1 file changed, 3 insertions(+), 6 deletions(-)
>> 
>> diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h 
>> b/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> index 669565fa1c69..d791e35db769 100644
>> --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h
>> @@ -1,9 +1,6 @@
>>  /* SPDX-License-Identifier: GPL-2.0 */
>> -/******************************************************************************
>> - *
>> - * Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved.
>> - *
>> - 
>> ******************************************************************************/
>> +/* Copyright(c) 2007 - 2011 Realtek Corporation. All rights reserved. 
>> */
>> +
>>  #ifndef __RTW_EFUSE_H__
>>  #define __RTW_EFUSE_H__
>> 
>> @@ -95,7 +92,7 @@ void EFUSE_GetEfuseDefinition(struct adapter 
>> *padapter, u8 efuseType, u8 type, v
>>  u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data, 
>> bool	 bPseudoTest);
>>  u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, 
>> bool	 bPseudoTest);
>> 
>> -void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8  
>> PwrState);
>> +void Efuse_PowerSwitch(struct adapter *padapter, u8 bWrite, u8 
>> PwrState);
> 
> This doesn't look like a copyright banner change :(

  reply	other threads:[~2025-09-09  5:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  3:58 Akiyoshi Kurita
2025-09-09  4:43 ` Greg KH
2025-09-09  5:36   ` weibu [this message]
2025-09-09  5:33 ` [PATCH v2 1/2] " Akiyoshi Kurita
2025-09-09  5:33   ` [PATCH v2 2/2] staging: rtl8723bs: rtw_efuse.h: fix double space in PwrState parameter Akiyoshi Kurita
2025-09-12 13:53     ` Greg KH
2025-09-12 16:16 [PATCH] staging: rtl8723bs: rtw_efuse.h: simplify copyright banner Akiyoshi Kurita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cba51d1668a9efaacd59b1bb64e32b3@redadmin.org \
    --to=weibu@redadmin.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®