From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CD48331EC0 for ; Thu, 20 Aug 2026 07:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787210265; cv=none; b=VN6ZF25Busq1hyhKm72bTMyWAg0LjIIaLzU2A77Fvr0LfXMjf0EJzRAtrLuAh0bjso1NoXHGxTW2Mh4o43+serifiBjrtlh4LPPm/zeajpci9rULnL/4huk1QQw7sbtOX5rLYnnSQ7eJbQjvKFgqOjS31pUnq6C/qz/3420YK8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787210265; c=relaxed/simple; bh=Su4YKEuwWJ+3xCqh7QzAqtOPLcP5BDjYVFRKQ++WCQk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DflDKQjhTX78SH6jRFC1yS3duCOTCnKl1oNxGDPa5CU5d89i7sf/xOtvVDUsCxwXf62SLVVfICJfV//kU4b8j6OH+zQTKsiJb5XFluyn0PH2gcUn6g5ntoZHOHrrVtyj+QIWOHObyvqtvCbUsNkgjBTiTtrRpgCk7OuR4B20Id8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UzVtrGvd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kxFi+/mO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UzVtrGvd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kxFi+/mO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787210262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7O3R2nP04nUifzg3R2bdZHOOMihm3gKGZeeAij5TDc8=; b=UzVtrGvd/R0kPD8zP7nTTRvVV36Dca7c3zxdIiu9Rqh9DXo+5aSN70Ab9mnsa6PuO6BUpw gVq8zcsLmjTq9qkZsJ/hlHetX6azKt+Z1ZLs4JCRttzpP7ENKytJqA0+QILkHTpWC2I9eK ZAdnsbZDtFtFWznO66CTfXTyuKhMRJI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-0L5i_wlLOfucSEpVClFTVg-1; Thu, 20 Aug 2026 03:17:30 -0400 X-MC-Unique: 0L5i_wlLOfucSEpVClFTVg-1 X-Mimecast-MFC-AGG-ID: 0L5i_wlLOfucSEpVClFTVg_1787210249 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-499913d1a79so13063185e9.0 for ; Thu, 20 Aug 2026 00:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787210249; x=1787815049; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7O3R2nP04nUifzg3R2bdZHOOMihm3gKGZeeAij5TDc8=; b=kxFi+/mO9QqNDA4Ht80TC4wwHE3eBHCxNYHZKeuUk7zmcEBHAcMgSSMCJp2AGSuJzM txEZxRbKG1tL6s6PDHCkKSyVAXkxPhjLt4wv0E/dVTgFss+fHNrOIa8oESaI+aHqYm4C G9eNFdx8qEMrt9iqxH3c+LhH/N0QJci+Yt9zuMwb37VvABSydiDNjbfH0JxMpw/3CbpC RP+5Y7uRE0OoGD50Vb+MjcqskgR62edjQ9jBO3YUd/lI3eiyjgfFRBYciQRMyoZAW7cg /tzX5MS7U7rqn1iRQmltevfIbPvu0JYhVAp6Fq0XLs93P4L9Y5VWen7Qc3DK1KqzzOWW T7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787210249; x=1787815049; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7O3R2nP04nUifzg3R2bdZHOOMihm3gKGZeeAij5TDc8=; b=c1sCZeQD5wBpAmzKOxXb6mDMclqdAmh+lw3LbyTZE1UKLD5JT0+twStpKOCqUB0XQB 5vTT1tjxYtilk0gUnDKx9gBG/MYemjnwfXVwY4KadsAxk/jic6C8ux+XjY07TSJyc4jw WiL760WLPYT6WZtwG/NJRzyWyK71u7gvEQtTOMZvw2iE9PRq25CebCK3RDb+mdaxSsob K48W2Yng1sTJagw71V6xKXBjKrUwaqVu2u+agdgH5qMqnulsCMPDjiUE6KLwW7LKvhwO BMGuR86S4BNcrNbIqaEMQkk3Kakld9sm0L2rXUUvVbKOJ6R+cp7iy2/AxKdaElnaGkYr m++Q== X-Forwarded-Encrypted: i=1; AHgh+RrpqZe/TwHfv07T8b2K0CDXA2zTpyIe6rlIs2mOQfviIKZXkEF4OpE9oRcSkryk2rjHKgvFryXRkHN1FzE=@vger.kernel.org X-Gm-Message-State: AOJu0YzwziejkaL93CbXPa2aiLqTl3Pesq4Z+UsuL5X8KwKQ7KcYgREB zths5U+DQDuLUKVHWzluOkNXvyiKfRaMvCGjpje5yMfjzN45tWAVhFA5uFMQ6fCtxFj9aDzSyiQ FW/ojxpiK4YpVr8X4PFa1eQRTWF3s+9gJ49qzagjzEShZmbXWz5/2mid44Blw5IyNSg== X-Gm-Gg: AR+sD11TBDGEYoVtRkZPcv6ve+plAFJ5cAqzXWBO2WFrJgc7yJLojR+Zv964zp8H0/G MfvD8qUtDnO7q4LLZA7iQgwakNNrDmg8E9NofjccFMP8jwCxNAUN8r4M97VpXbH7r9fPafrBCMs 5X9jqpI2tD5/xah0zFfyEWtwB/NZbXwqBbE5+hMsREkSoYgbWhxScSi2BY5JRUhtO/CUMtCIoTP dpSvDMVJQt1rnGDQgltAaua/goIS2FPPj66t8e5JejtbWeT9SYedZ6RkHIBwLs2BWh5opgLqPUA sgem/HaUUb6ANG72q5aWJ4TS/AWPBlrvd1P3IpLaR8PmhUyflb+btMppMHfjJQCL6UPmiUY= X-Received: by 2002:a05:600c:a012:b0:499:593b:a15b with SMTP id 5b1f17b1804b1-499aa1431a5mr199558745e9.1.1787210248749; Thu, 20 Aug 2026 00:17:28 -0700 (PDT) X-Received: by 2002:a05:600c:a012:b0:499:593b:a15b with SMTP id 5b1f17b1804b1-499aa1431a5mr199557895e9.1.1787210248261; Thu, 20 Aug 2026 00:17:28 -0700 (PDT) Received: from [10.22.3.81] ([91.26.127.10]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa1111b2sm169051195e9.5.2026.08.20.00.17.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 00:17:27 -0700 (PDT) Message-ID: <7cbad13f-d7ad-4b7b-b09b-bc8c577a405f@redhat.com> Date: Thu, 20 Aug 2026 09:17:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/headers: Remove "#include " from set_memory.h To: Coiby Xu Cc: x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org References: <20260409144819.2000120-1-thuth@redhat.com> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/04/2026 02.52, Coiby Xu wrote: > On Thu, Apr 09, 2026 at 04:48:19PM +0200, Thomas Huth wrote: >> From: Thomas Huth >> >> The "#include " has been added to set_memory.h in >> commit e1e6cd01d933 ("Revert "x86/mm: Remove unused __set_memory_prot()"") >> to provide the "pgprot_t" type in the prototype of __set_memory_prot(). >> Later, the prototype of __set_memory_prot() has been removed again, see >> commit 8a4e92b3260a ("x86/crash: Use set_memory_p() instead of >> __set_memory_prot()"), but the pgtable.h line has been left in the header. >> Thus, since it's not required here anymore, remove it now from >> set_memory.h. However, there is a indirect dependency on pgtable.h >> in the sev.h header file instead, so we now have to include it there >> to avoid that the build breaks. >> >> Signed-off-by: Thomas Huth >> --- >> arch/x86/include/asm/set_memory.h | 1 - >> arch/x86/include/asm/sev.h        | 1 + >> 2 files changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/include/asm/set_memory.h b/arch/x86/include/asm/ >> set_memory.h >> index 4362c26aa992d..8d9f1c9aaa4ce 100644 >> --- a/arch/x86/include/asm/set_memory.h >> +++ b/arch/x86/include/asm/set_memory.h >> @@ -4,7 +4,6 @@ >> >> #include >> #include >> -#include >> >> #define set_memory_rox set_memory_rox >> int set_memory_rox(unsigned long addr, int numpages); >> diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h >> index 0e6c0940100f3..3936c821d6b0a 100644 >> --- a/arch/x86/include/asm/sev.h >> +++ b/arch/x86/include/asm/sev.h >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> -- >> 2.53.0 >> > > I forgot to drop unneeded pgtable.h. Thanks for addressing it! > > Acked-by: Coiby Xu Friendly ping! Could anybody pick this up? Thanks, Thomas