From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06C40C432C0 for ; Tue, 26 Nov 2019 09:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC79120659 for ; Tue, 26 Nov 2019 09:49:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727638AbfKZJtN convert rfc822-to-8bit (ORCPT ); Tue, 26 Nov 2019 04:49:13 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:53646 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727422AbfKZJtN (ORCPT ); Tue, 26 Nov 2019 04:49:13 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-111-dVxmoB-BOb-077JA22lhHQ-1; Tue, 26 Nov 2019 09:49:09 +0000 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 26 Nov 2019 09:49:08 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 26 Nov 2019 09:49:08 +0000 From: David Laight To: 'Fenghua Yu' , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Andy Lutomirski , Peter Zijlstra , Ashok Raj , Tony Luck , Ravi V Shankar CC: linux-kernel , x86 Subject: RE: [PATCH v2 1/4] drivers/net/b44: Change to non-atomic bit operations Thread-Topic: [PATCH v2 1/4] drivers/net/b44: Change to non-atomic bit operations Thread-Index: AQHVo8boYhlrH/hYn0umhpEaMdAbOKedM4/w Date: Tue, 26 Nov 2019 09:49:08 +0000 Message-ID: <7cbe0135c6234700bebdefd0fdaa4f6a@AcuMS.aculab.com> References: <1574710984-208305-1-git-send-email-fenghua.yu@intel.com> <1574710984-208305-2-git-send-email-fenghua.yu@intel.com> In-Reply-To: <1574710984-208305-2-git-send-email-fenghua.yu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: dVxmoB-BOb-077JA22lhHQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fenghua Yu > Sent: 25 November 2019 19:43 > From: Peter Zijlstra > > Since "pwol_mask" is local and never exposed to concurrency, there is > no need to set bit in pwol_mask by costly atomic operations. > > Signed-off-by: Peter Zijlstra > Signed-off-by: Fenghua Yu > --- > drivers/net/ethernet/broadcom/b44.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c > index 97ab0dd25552..5738ab963dfb 100644 > --- a/drivers/net/ethernet/broadcom/b44.c > +++ b/drivers/net/ethernet/broadcom/b44.c > @@ -1520,7 +1520,7 @@ static int b44_magic_pattern(u8 *macaddr, u8 *ppattern, u8 *pmask, int offset) > > memset(ppattern + offset, 0xff, magicsync); > for (j = 0; j < magicsync; j++) > - set_bit(len++, (unsigned long *) pmask); > + __set_bit(len++, (unsigned long *)pmask); While this stops the misaligned locks, the code is still horribly borked on BE systems. The way pmask is used definitely wanst a u32[] not a u64[] one. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)